Re: [PATCH 1/4] common/rc: add _require_scratch_dax

[Eryu Guan <eguan@redhat.com>]

On Wed, Jan 18, 2017 at 11:07:03AM +0800, Xiong Zhou wrote:
> To make sure we can test DAX feature on SCRATCH_DEV.
> 
> Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> ---
>  common/rc | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 892c46e..ea7956b 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2632,6 +2632,16 @@ _require_scratch_shutdown()
>  	_scratch_unmount
>  }
>  
> +# Does dax mount option work on this dev/fs?
> +_require_scratch_dax()
> +{
> +	_scratch_unmount

Use _require_scratch instead of _scratch_unmount here. _require_scratch
ensures we have SCRATCH_DEV defined and unmounts it if it's mounted.

Thanks,
Eryu

> +	_scratch_mkfs > /dev/null 2>&1
> +	_scratch_mount -o dax || \
> +		_notrun "$SCRATCH_DEV $FSTYP does not support -o dax"
> +	_scratch_unmount
> +}
> +
>  # Does norecovery support by this fs?
>  _require_norecovery()
>  {
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html