From: Xiong Zhou <xzhou@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Xiong Zhou <xzhou@redhat.com>,
eguan@redhat.com, linux-nvdimm@ml01.01.org,
fstests@vger.kernel.org
Subject: Re: [PATCH v2 1/2] xfs: test per-inode DAX flag by IO
Date: Fri, 20 Jan 2017 09:15:45 +0800 [thread overview]
Message-ID: <20170120011545.eq72oj33467uigb5@XZHOUW.usersys.redhat.com> (raw)
In-Reply-To: <20170119204925.GB28456@linux.intel.com>
On Thu, Jan 19, 2017 at 01:49:25PM -0700, Ross Zwisler wrote:
> On Thu, Jan 19, 2017 at 06:13:57PM +0800, Xiong Zhou wrote:
...snip..
> > + ret = munmap(map, len);
> > + if (ret < 0)
> > + err_exit("munmap", len, argv[4]);
>
> Small nit: you munmap() to clean up the mmap(), but you don't close fd or fd2.
Thanks Ross and Eryu reviewing!
I'll send v3 of this patch shortly.
--
Xiong
next prev parent reply other threads:[~2017-01-20 1:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 3:07 [PATCH 0/4] mmap dio and DAX Xiong Zhou
2017-01-18 3:07 ` [PATCH 1/4] common/rc: add _require_scratch_dax Xiong Zhou
2017-01-19 4:17 ` Eryu Guan
2017-01-18 3:07 ` [PATCH 2/4] src/t_mmap_dio: add mmap dio test Xiong Zhou
2017-01-18 3:07 ` [PATCH 3/4] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-01-19 4:24 ` Eryu Guan
2017-01-18 3:07 ` [PATCH 4/4] generic: test mmap dio through DAX and non-DAX Xiong Zhou
2017-01-19 5:54 ` Eryu Guan
2017-01-19 10:13 ` [PATCH v2 0/2] mmap dio and DAX Xiong Zhou
2017-01-19 10:13 ` [PATCH v2 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-01-19 20:49 ` Ross Zwisler
2017-01-20 1:15 ` Xiong Zhou [this message]
2017-01-20 2:21 ` [PATCH v3] " Xiong Zhou
2017-01-20 6:15 ` [PATCH v4 0/2] mmap dio and DAX Xiong Zhou
2017-01-20 6:15 ` [PATCH v4 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-02-04 15:17 ` [PATCH] fixup! " Ross Zwisler
2017-02-05 6:21 ` [PATCH v5 0/2] mmap dio and DAX Xiong Zhou
2017-02-05 6:21 ` [PATCH v5 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-02-06 19:13 ` Ross Zwisler
2017-02-05 6:21 ` [PATCH v5 2/2] generic: test mmap io through DAX and non-DAX Xiong Zhou
2017-02-06 19:17 ` Ross Zwisler
2017-02-08 4:11 ` [PATCH v6 0/2] mmap dio and DAX Xiong Zhou
2017-02-08 4:11 ` [PATCH v6 1/2] xfs: test per-inode DAX flag by IO Xiong Zhou
2017-02-08 4:11 ` [PATCH v6 2/2] generic: test mmap io through DAX and non-DAX Xiong Zhou
2017-02-17 6:46 ` Eryu Guan
2017-02-17 6:52 ` Xiong Zhou
2017-01-20 6:15 ` [PATCH v4 " Xiong Zhou
2017-01-24 22:28 ` [PATCH v4 0/2] mmap dio and DAX Ross Zwisler
2017-02-03 5:57 ` Xiong Zhou
2017-02-03 6:29 ` Eryu Guan
2017-02-03 16:57 ` Ross Zwisler
2017-02-04 10:14 ` Xiong Zhou
2017-01-19 10:13 ` [PATCH v2 2/2] generic: test mmap dio through DAX and non-DAX Xiong Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120011545.eq72oj33467uigb5@XZHOUW.usersys.redhat.com \
--to=xzhou@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox