Re: [PATCH v6 2/2] generic: test mmap io through DAX and non-DAX

[Eryu Guan <eguan@redhat.com>]

On Wed, Feb 08, 2017 at 12:11:18PM +0800, Xiong Zhou wrote:
> Mount TEST_DEV as non-DAX, SCRATCH_DEV as DAX, then
> do some IO between them. In this case we use mmap
> and dio/buffered IO read/write test programme.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> ---
>  tests/generic/407     | 152 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/generic/407.out |   2 +
>  tests/generic/group   |   1 +
>  3 files changed, 155 insertions(+)
>  create mode 100755 tests/generic/407
>  create mode 100644 tests/generic/407.out
> 
> diff --git a/tests/generic/407 b/tests/generic/407
> new file mode 100755
> index 0000000..b5b2ce4
> --- /dev/null
> +++ b/tests/generic/407
> @@ -0,0 +1,152 @@
> +#! /bin/bash
> +# FS QA Test 407
> +#
> +# mmap direct/buffered io between DAX and non-DAX mountpoints.
[snip]
> +
> +# make fs 2Mb aligned for PMD fault testing
> +if [[ $FSTYP =~ ext ]] ; then
> +	_scratch_mkfs "-E stride=512,stripe_width=1" \
> +		> /dev/null 2>&1
> +elif [[ $FSTYP =~ xfs ]] ; then
> +	_scratch_mkfs "-d su=2m,sw=1" > /dev/null 2>&1
> +fi

If FSTYP isn't extN nor xfs, then scratch device is not mkfs'ed, I think
you're missing a default "else" here, which calls _scratch_mkfs without
any options.

If you're OK with this update, I can fix it at commit time.

Thanks,
Eryu