[PATCH 0/4] fstests: GDBM detection cleanup

[PATCH 0/4] fstests: GDBM detection cleanup

[jeffm]

From: Jeff Mahoney <jeffm@suse.com>

Commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c
to build) fixed building on newer SUSE systems but broke older ones.  Where
we used to skip building src/dbtest on SLES systems, now we'd fail
to build on SLES11.  The reason was that we were now detecting
ndbm.h but also including gdbm.h, which doesn't work on older systems due
to both defining the datum type.  It turns out that no system needs
gdbm.h at all.

This series cleans up the macros and fixes detection for all systems that
only have /usr/include/ndbm.h.

-Jeff

---

Jeff Mahoney (4):
  build: remove dead AC_PACKAGE_WANT_NDBM macro
  build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection
    fails
  build: clean up AC_PACKAGE_WANT_GDBM
  build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBM

 m4/package_gdbmdev.m4 | 104 ++++++++++++++++++++++----------------------------
 src/dbtest.c          |   3 --
 2 files changed, 46 insertions(+), 61 deletions(-)

-- 
2.15.1

[PATCH 0/4] fstests: GDBM detection cleanup

[jeffm]

From: Jeff Mahoney <jeffm@suse.com>

Commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c
to build) fixed building on newer SUSE systems but broke older ones.  Where
we used to skip building src/dbtest on SLES systems, now we'd fail
to build on SLES11.  The reason was that we were now detecting
ndbm.h but also including gdbm.h, which doesn't work on older systems due
to both defining the datum type.  It turns out that no system needs
gdbm.h at all.

This series cleans up the macros and fixes detection for all systems that
only have /usr/include/ndbm.h.

-Jeff

---

Jeff Mahoney (4):
  build: remove dead AC_PACKAGE_WANT_NDBM macro
  build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection
    fails
  build: clean up AC_PACKAGE_WANT_GDBM
  build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBM

 m4/package_gdbmdev.m4 | 104 ++++++++++++++++++++++----------------------------
 src/dbtest.c          |   3 --
 2 files changed, 46 insertions(+), 61 deletions(-)

-- 
2.15.1

Re: [PATCH 0/4] fstests: GDBM detection cleanup

[Eryu Guan]

On Thu, Mar 15, 2018 at 05:54:51PM -0400, jeffm@suse.com wrote:
> From: Jeff Mahoney <jeffm@suse.com>
> 
> Commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c
> to build) fixed building on newer SUSE systems but broke older ones.  Where
> we used to skip building src/dbtest on SLES systems, now we'd fail
> to build on SLES11.  The reason was that we were now detecting
> ndbm.h but also including gdbm.h, which doesn't work on older systems due
> to both defining the datum type.  It turns out that no system needs
> gdbm.h at all.
> 
> This series cleans up the macros and fixes detection for all systems that
> only have /usr/include/ndbm.h.

Thanks for the fixes and cleanups! I tested them on Fedora 27, RHEL7 and
Debian stretch, with/without gdbm devel package installed, all worked
fine. But I don't have SUSE systems by hand, I assume you've tested them
successfully.

Thanks,
Eryu