From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: anju@linux.vnet.ibm.com
Subject: [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools
Date: Mon, 11 Oct 2021 13:25:50 +0530 [thread overview]
Message-ID: <20211011075552.196688-3-anju@linux.vnet.ibm.com> (raw)
In-Reply-To: <20211011075552.196688-1-anju@linux.vnet.ibm.com>
For xfs we need the quota-tools containing commit fdd774bf08e568
("quota-tools: pass quota type to QCMD for Q_XFS_GETQSTAT")to run this
test. Otherwise this test will fail on xfs, as the grace time is not set
correctly. So check for the quota-tool with the required commit before
running this test on xfs.
Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
---
tests/generic/594 | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/generic/594 b/tests/generic/594
index 88f9a0dc..668c1fae 100755
--- a/tests/generic/594
+++ b/tests/generic/594
@@ -6,6 +6,8 @@
#
# Test per-type(user, group and project) filesystem quota timers, make sure
# each of grace time can be set/get properly.
+# For xfs, you need a quota-tools containing commit fdd774bf08e568 for this
+# test to run properly- v4.06 should do.
#
. ./common/preamble
_begin_fstest auto quick quota
@@ -18,9 +20,13 @@ _begin_fstest auto quick quota
_supported_fs generic
_require_scratch
_require_setquota_project
+version=$(setquota -V | head -n1 | cut -d" " -f4)
# V4 XFS doesn't support to mount project and group quota together
if [ "$FSTYP" = "xfs" ];then
_require_scratch_xfs_crc
+ if [ "$version" \< "4.06" ];then
+ _notrun "This test requires quota-tools 4.06 or greater"
+ fi
fi
_require_quota
--
2.24.1
next prev parent reply other threads:[~2021-10-11 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 7:55 [PATCH 0/4] Random fixes for xfstest Anju T Sudhakar
2021-10-11 7:55 ` [PATCH 1/4] xfs/432: Skip this test for dax config and pagesize not equal to the specified block size Anju T Sudhakar
2021-10-11 8:27 ` Dave Chinner
2021-10-11 7:55 ` Anju T Sudhakar [this message]
2021-10-11 8:32 ` [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools Dave Chinner
2021-10-11 16:46 ` Darrick J. Wong
2021-10-12 2:57 ` Eryu Guan
2021-10-12 5:25 ` xuyang2018.jy
2021-10-11 7:55 ` [PATCH 3/4] generic/600: Fix this test on xfs with " Anju T Sudhakar
2021-10-11 7:55 ` [PATCH 4/4] generic/219: Fix test failure on 64k block size Anju T Sudhakar
2021-10-11 8:36 ` Dave Chinner
2021-10-12 17:33 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011075552.196688-3-anju@linux.vnet.ibm.com \
--to=anju@linux.vnet.ibm.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox