public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: anju@linux.vnet.ibm.com
Subject: [PATCH 3/4] generic/600: Fix this test on xfs with older quota-tools
Date: Mon, 11 Oct 2021 13:25:51 +0530	[thread overview]
Message-ID: <20211011075552.196688-4-anju@linux.vnet.ibm.com> (raw)
In-Reply-To: <20211011075552.196688-1-anju@linux.vnet.ibm.com>

For xfs, we need quota-tools containing commit be96da2353669d ("quota-tools:
Set FS_DQ_TIMER_MASK for individual xfs grace times"), to run this test.
Otherwise the test fails on xfs. Check the quota-tools before running
the test.

Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
---
 tests/generic/600 | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/generic/600 b/tests/generic/600
index a4233ecc..c8dc1bd5 100755
--- a/tests/generic/600
+++ b/tests/generic/600
@@ -10,6 +10,9 @@
 # This test only exercises user quota because it's not known whether the
 # filesystem can set individual grace timers for each quota type
 #
+# For xfs, you need a quota-tools containing commit be96da2353669d to
+# run this test properly- 4.06 should do.
+
 . ./common/preamble
 _begin_fstest auto quick quota
 
@@ -24,6 +27,11 @@ _require_quota
 _require_user
 _require_setquota_project
 
+version=$(setquota -V | head -n1 | cut -d" " -f4)
+if [ "$FSTYP" = "xfs" ] && [ "$version" \< "4.06" ];then
+	_notrun "This test requires quota-tools 4.06 or greater"
+fi
+
 _scratch_mkfs >$seqres.full 2>&1
 _qmount_option "usrquota"
 _qmount
-- 
2.24.1


  parent reply	other threads:[~2021-10-11  7:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11  7:55 [PATCH 0/4] Random fixes for xfstest Anju T Sudhakar
2021-10-11  7:55 ` [PATCH 1/4] xfs/432: Skip this test for dax config and pagesize not equal to the specified block size Anju T Sudhakar
2021-10-11  8:27   ` Dave Chinner
2021-10-11  7:55 ` [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools Anju T Sudhakar
2021-10-11  8:32   ` Dave Chinner
2021-10-11 16:46   ` Darrick J. Wong
2021-10-12  2:57     ` Eryu Guan
2021-10-12  5:25       ` xuyang2018.jy
2021-10-11  7:55 ` Anju T Sudhakar [this message]
2021-10-11  7:55 ` [PATCH 4/4] generic/219: Fix test failure on 64k block size Anju T Sudhakar
2021-10-11  8:36   ` Dave Chinner
2021-10-12 17:33     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011075552.196688-4-anju@linux.vnet.ibm.com \
    --to=anju@linux.vnet.ibm.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox