From: Anju T Sudhakar <anju@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: anju@linux.vnet.ibm.com
Subject: [PATCH 4/4] generic/219: Fix test failure on 64k block size
Date: Mon, 11 Oct 2021 13:25:52 +0530 [thread overview]
Message-ID: <20211011075552.196688-5-anju@linux.vnet.ibm.com> (raw)
In-Reply-To: <20211011075552.196688-1-anju@linux.vnet.ibm.com>
Skip this test on 64k, as 4k as taken as the default block size.
Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
---
But I have a Query:
This test fails on ext4&xfs with 64k block size. Do we need to
rephrase this test to incorporate the 64k bs scenario as well?
If not we can skip this test.
tests/generic/219 | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/generic/219 b/tests/generic/219
index d3d257f1..d38fd033 100755
--- a/tests/generic/219
+++ b/tests/generic/219
@@ -79,6 +79,11 @@ test_accounting()
# real QA test starts here
+# Skip this test on 64k block size scenario
+bsize=$(_get_block_size $SCRATCH_MNT)
+if [ $bsize -ge 4096 ];then
+ _notrun "Test assumes 4k as the default block size"
+fi
_scratch_unmount 2>/dev/null
_scratch_mkfs >> $seqres.full 2>&1
_scratch_mount "-o usrquota,grpquota"
--
2.24.1
next prev parent reply other threads:[~2021-10-11 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 7:55 [PATCH 0/4] Random fixes for xfstest Anju T Sudhakar
2021-10-11 7:55 ` [PATCH 1/4] xfs/432: Skip this test for dax config and pagesize not equal to the specified block size Anju T Sudhakar
2021-10-11 8:27 ` Dave Chinner
2021-10-11 7:55 ` [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools Anju T Sudhakar
2021-10-11 8:32 ` Dave Chinner
2021-10-11 16:46 ` Darrick J. Wong
2021-10-12 2:57 ` Eryu Guan
2021-10-12 5:25 ` xuyang2018.jy
2021-10-11 7:55 ` [PATCH 3/4] generic/600: Fix this test on xfs with " Anju T Sudhakar
2021-10-11 7:55 ` Anju T Sudhakar [this message]
2021-10-11 8:36 ` [PATCH 4/4] generic/219: Fix test failure on 64k block size Dave Chinner
2021-10-12 17:33 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011075552.196688-5-anju@linux.vnet.ibm.com \
--to=anju@linux.vnet.ibm.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox