Re: [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools

[Dave Chinner <david@fromorbit.com>]

On Mon, Oct 11, 2021 at 01:25:50PM +0530, Anju T Sudhakar wrote:
> For xfs we need the quota-tools containing commit fdd774bf08e568
> ("quota-tools: pass quota type to QCMD for Q_XFS_GETQSTAT")to run this
> test. Otherwise this test will fail on xfs, as the grace time is not set
> correctly. So check for the quota-tool with the required commit before
> running this test on xfs.
> 
> Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
> ---
>  tests/generic/594 | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/generic/594 b/tests/generic/594
> index 88f9a0dc..668c1fae 100755
> --- a/tests/generic/594
> +++ b/tests/generic/594
> @@ -6,6 +6,8 @@
>  #
>  # Test per-type(user, group and project) filesystem quota timers, make sure
>  # each of grace time can be set/get properly.
> +# For xfs, you need a quota-tools containing commit fdd774bf08e568 for this
> +# test to run properly- v4.06 should do.
>  #
>  . ./common/preamble
>  _begin_fstest auto quick quota
> @@ -18,9 +20,13 @@ _begin_fstest auto quick quota
>  _supported_fs generic
>  _require_scratch
>  _require_setquota_project
> +version=$(setquota -V | head -n1 | cut -d" " -f4)
>  # V4 XFS doesn't support to mount project and group quota together
>  if [ "$FSTYP" = "xfs" ];then
>  	_require_scratch_xfs_crc
> +	if [ "$version" \< "4.06" ];then
> +		_notrun "This test requires quota-tools 4.06 or greater"
> +	fi

We don't test for version numbers, because feature and bug fix back
ports make testing version numbers unreliable. What needs to be done
here is to test whether the feature is available of not via a
_require_setquota_xfs_getqstat() rule that encapsulates the feature
test and _notrun call if the feature is not supported.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com