[PATCH 0/2]: minor compiler warning and lsqa fixes

[PATCH 0/2]: minor compiler warning and lsqa fixes

[David Disseldorp]

I couple of minor clean-ups I had laying around:

 lsqa.pl                | 2 +-
 src/seek_sanity_test.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

[PATCH 1/2] lsqa.pl: fix --header output

[David Disseldorp]

7e98d41a ("fstests: move test group info to test files") replaces the
post-header "seq" assignment with "./common/preamble\n_begin_fstest ..."
Update lsqa.pl to recognise the "./common/preamble" line as a header
divider.

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 lsqa.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lsqa.pl b/lsqa.pl
index 8ca1167f..63bee582 100755
--- a/lsqa.pl
+++ b/lsqa.pl
@@ -99,7 +99,7 @@ sub get_qa_header($) {
 	m/^# SPDX/i		and next; # SPDX tags
 	m/^# Copyright/i	and next; # Copyright tags
 	m/^#\s*\-{10}/		and last; # dashed lines
-	m/^seq/i		and last; # test start
+	m/^\. \.\/common\/preamble/ and last; # test start
 
 	s/^# *//;
 
-- 
2.35.3

Re: [PATCH 1/2] lsqa.pl: fix --header output

[Zorro Lang]

On Tue, Oct 11, 2022 at 11:23:39AM +0200, David Disseldorp wrote:
> 7e98d41a ("fstests: move test group info to test files") replaces the
> post-header "seq" assignment with "./common/preamble\n_begin_fstest ..."
> Update lsqa.pl to recognise the "./common/preamble" line as a header
> divider.
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
>  lsqa.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lsqa.pl b/lsqa.pl
> index 8ca1167f..63bee582 100755
> --- a/lsqa.pl
> +++ b/lsqa.pl
> @@ -99,7 +99,7 @@ sub get_qa_header($) {
>  	m/^# SPDX/i		and next; # SPDX tags
>  	m/^# Copyright/i	and next; # Copyright tags
>  	m/^#\s*\-{10}/		and last; # dashed lines
> -	m/^seq/i		and last; # test start
> +	m/^\. \.\/common\/preamble/ and last; # test start

I think that makes sense, I don't have better idea, so ..

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  
>  	s/^# *//;
>  
> -- 
> 2.35.3
> 

[PATCH 2/2] seek_sanity_test: drop unused pagesz

[David Disseldorp]

b91889d7 ("seek_sanity_test: use XFS ioctls to determine file allocation
unit size") left this unused, resulting in:

seek_sanity_test.c: In function 'get_io_sizes':
seek_sanity_test.c:70:6: warning: unused variable 'pagesz'
  int pagesz = sysconf(_SC_PAGE_SIZE);
      ^~~~~~

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
 src/seek_sanity_test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index 78f835e8..8a586f74 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -67,7 +67,6 @@ static int get_io_sizes(int fd)
 	off_t pos = 0, offset = 1;
 	struct stat buf;
 	int shift, ret;
-	int pagesz = sysconf(_SC_PAGE_SIZE);
 
 	ret = detect_xfs_alloc_unit(fd);
 	if (!ret)
-- 
2.35.3

Re: [PATCH 2/2] seek_sanity_test: drop unused pagesz

[Zorro Lang]

On Tue, Oct 11, 2022 at 11:23:40AM +0200, David Disseldorp wrote:
> b91889d7 ("seek_sanity_test: use XFS ioctls to determine file allocation
> unit size") left this unused, resulting in:
> 
> seek_sanity_test.c: In function 'get_io_sizes':
> seek_sanity_test.c:70:6: warning: unused variable 'pagesz'
>   int pagesz = sysconf(_SC_PAGE_SIZE);
>       ^~~~~~
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---

OK, finally we can't stand this warning :)

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  src/seek_sanity_test.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 78f835e8..8a586f74 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -67,7 +67,6 @@ static int get_io_sizes(int fd)
>  	off_t pos = 0, offset = 1;
>  	struct stat buf;
>  	int shift, ret;
> -	int pagesz = sysconf(_SC_PAGE_SIZE);
>  
>  	ret = detect_xfs_alloc_unit(fd);
>  	if (!ret)
> -- 
> 2.35.3
>