[PATCH] generic/193: add to perms group

[PATCH] generic/193: add to perms group

[Christian Brauner]

This test changes permissions and specifically tests for setuid and
setgid bits to be dropped or kept. It really needs to be run when -g
perms is specified.

Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
---
 tests/generic/193 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/193 b/tests/generic/193
index ddaff69b..e2710b07 100755
--- a/tests/generic/193
+++ b/tests/generic/193
@@ -7,7 +7,7 @@
 # Test permission checks in ->setattr
 #
 . ./common/preamble
-_begin_fstest metadata auto quick
+_begin_fstest metadata auto quick perms
 
 _register_cleanup "_cleanup_files"
 tag="added by qa $seq"

base-commit: a75c5f50584e03ca7862ad51f48efd2d524d1dc5
-- 
2.34.1

Re: [PATCH] generic/193: add to perms group

[xuyang2018.jy]

on 2022/10/17 17:53, Christian Brauner wrote:
> This test changes permissions and specifically tests for setuid and
> setgid bits to be dropped or kept. It really needs to be run when -g
> perms is specified.

Yes, Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>

ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should 
also add perms group.

Best Regards
Yang Xu
> 
> Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> ---
>   tests/generic/193 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/193 b/tests/generic/193
> index ddaff69b..e2710b07 100755
> --- a/tests/generic/193
> +++ b/tests/generic/193
> @@ -7,7 +7,7 @@
>   # Test permission checks in ->setattr
>   #
>   . ./common/preamble
> -_begin_fstest metadata auto quick
> +_begin_fstest metadata auto quick perms
>   
>   _register_cleanup "_cleanup_files"
>   tag="added by qa $seq"
> 
> base-commit: a75c5f50584e03ca7862ad51f48efd2d524d1dc5

Re: [PATCH] generic/193: add to perms group

[Zorro Lang]

On Mon, Oct 17, 2022 at 10:01:13AM +0000, xuyang2018.jy@fujitsu.com wrote:
> 
> 
> on 2022/10/17 17:53, Christian Brauner wrote:
> > This test changes permissions and specifically tests for setuid and
> > setgid bits to be dropped or kept. It really needs to be run when -g
> > perms is specified.
> 
> Yes, Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> 
> ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should 
> also add perms group.

OK, if Christian agrees with this point and would like to help that, please
help to check and add "perms" to more proper cases in one patch.

Thanks,
Zorro

> 
> Best Regards
> Yang Xu
> > 
> > Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> > ---
> >   tests/generic/193 | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/193 b/tests/generic/193
> > index ddaff69b..e2710b07 100755
> > --- a/tests/generic/193
> > +++ b/tests/generic/193
> > @@ -7,7 +7,7 @@
> >   # Test permission checks in ->setattr
> >   #
> >   . ./common/preamble
> > -_begin_fstest metadata auto quick
> > +_begin_fstest metadata auto quick perms
> >   
> >   _register_cleanup "_cleanup_files"
> >   tag="added by qa $seq"
> > 
> > base-commit: a75c5f50584e03ca7862ad51f48efd2d524d1dc5

Re: [PATCH] generic/193: add to perms group

[Christian Brauner]

On Mon, Oct 17, 2022 at 09:29:14PM +0800, Zorro Lang wrote:
> On Mon, Oct 17, 2022 at 10:01:13AM +0000, xuyang2018.jy@fujitsu.com wrote:
> > 
> > 
> > on 2022/10/17 17:53, Christian Brauner wrote:
> > > This test changes permissions and specifically tests for setuid and
> > > setgid bits to be dropped or kept. It really needs to be run when -g
> > > perms is specified.
> > 
> > Yes, Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > 
> > ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should 
> > also add perms group.
> 
> OK, if Christian agrees with this point and would like to help that, please
> help to check and add "perms" to more proper cases in one patch.

I think that's a good idea. Yang, would you be open to sending a patch
to add all these test to the "perms" group in one go?

Re: [PATCH] generic/193: add to perms group

[xuyang2018.jy]

on 2022/10/17 23:04, Christian Brauner wrote:
> On Mon, Oct 17, 2022 at 09:29:14PM +0800, Zorro Lang wrote:
>> On Mon, Oct 17, 2022 at 10:01:13AM +0000, xuyang2018.jy@fujitsu.com wrote:
>>>
>>>
>>> on 2022/10/17 17:53, Christian Brauner wrote:
>>>> This test changes permissions and specifically tests for setuid and
>>>> setgid bits to be dropped or kept. It really needs to be run when -g
>>>> perms is specified.
>>>
>>> Yes, Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>>>
>>> ps: generic/67[3-4] and generic/68[3-7] test suid and sgid, they should
>>> also add perms group.
>>
>> OK, if Christian agrees with this point and would like to help that, please
>> help to check and add "perms" to more proper cases in one patch.
> 
> I think that's a good idea. Yang, would you be open to sending a patch
> to add all these test to the "perms" group in one go?

Of course, I will look for more case to add perms group in one patch as 
zorro and you sugguested.

Best Regards
Yang Xu