FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 2/2] generic/455: skip the test if the file system doesn't support journaling
Date: Tue, 11 Jun 2024 04:58:53 -0400	[thread overview]
Message-ID: <20240611085853.200102-2-tytso@mit.edu> (raw)
In-Reply-To: <20240611085853.200102-1-tytso@mit.edu>

This test uses dm-log-writes to test power fail scenarios, so it won't
work if the file system doesn't support metadata journaling.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/generic/455 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/generic/455 b/tests/generic/455
index da803de08..75437b90d 100755
--- a/tests/generic/455
+++ b/tests/generic/455
@@ -65,6 +65,13 @@ _log_writes_init $DMTHIN_VOL_DEV
 
 _log_writes_mkfs >> $seqres.full 2>&1
 
+# This test requires metadata journaling since it simulates a power failure
+msg=$(_has_metadata_journaling "$LOGWRITES_DMDEV")
+if [ -n "$msg" ]; then
+    _log_writes_remove
+    _notrun "$msg"
+fi
+
 # Log writes emulates discard support, turn it on for maximum crying.
 _log_writes_mount -o discard
 
-- 
2.43.0


  reply	other threads:[~2024-06-11  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  8:58 [PATCH 1/2] ext4/045: skip test if the block size is 1k Theodore Ts'o
2024-06-11  8:58 ` Theodore Ts'o [this message]
2024-06-11 14:27   ` [PATCH 2/2] generic/455: skip the test if the file system doesn't support journaling Darrick J. Wong
2024-06-11 22:26     ` Theodore Ts'o
2024-06-11 14:27 ` [PATCH 1/2] ext4/045: skip test if the block size is 1k Darrick J. Wong
2024-06-11 16:40   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611085853.200102-2-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox