FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4/045: skip test if the block size is 1k
Date: Tue, 11 Jun 2024 07:27:54 -0700	[thread overview]
Message-ID: <20240611142754.GF52977@frogsfrogsfrogs> (raw)
In-Reply-To: <20240611085853.200102-1-tytso@mit.edu>

On Tue, Jun 11, 2024 at 04:58:52AM -0400, Theodore Ts'o wrote:
> If the file system is 1k, this test will fail because with dir_index
> enabled, the directory tree will get too deep, and the kernel will
> return ENOSPC and log the EXT4-fs warning "Directory (ino: NNN) index
> full, reach max htree level: 2".  So if the blocksize is less than 2k,
> _notrun this test.

Didn't ext4 recently gain support for 3-level htrees?

--D

> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
>  tests/ext4/045 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/ext4/045 b/tests/ext4/045
> index 4f0ad4aa7..5ae7a45b5 100755
> --- a/tests/ext4/045
> +++ b/tests/ext4/045
> @@ -44,6 +44,10 @@ workout()
>  
>         _scratch_mkfs "-O extent,dir_nlink,dir_index -I 256" >> $seqres.full 2>&1
>         _scratch_mount
> +       blocksize=$(_get_block_size $SCRATCH_MNT)
> +       if [ "$blocksize" -lt 2048 ]; then
> +	   _notrun "blocksize $blocksize, too small"
> +       fi
>  
>         # create directories
>         mkdir -p $3 2> /dev/null
> -- 
> 2.43.0
> 
> 

  parent reply	other threads:[~2024-06-11 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  8:58 [PATCH 1/2] ext4/045: skip test if the block size is 1k Theodore Ts'o
2024-06-11  8:58 ` [PATCH 2/2] generic/455: skip the test if the file system doesn't support journaling Theodore Ts'o
2024-06-11 14:27   ` Darrick J. Wong
2024-06-11 22:26     ` Theodore Ts'o
2024-06-11 14:27 ` Darrick J. Wong [this message]
2024-06-11 16:40   ` [PATCH 1/2] ext4/045: skip test if the block size is 1k Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240611142754.GF52977@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox