From: "Theodore Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/455: skip the test if the file system doesn't support journaling
Date: Tue, 11 Jun 2024 23:26:46 +0100 [thread overview]
Message-ID: <20240611222646.GA1906022@mit.edu> (raw)
In-Reply-To: <20240611142701.GE52977@frogsfrogsfrogs>
On Tue, Jun 11, 2024 at 07:27:01AM -0700, Darrick J. Wong wrote:
>
> _require_metadata_journaling $LOGWRITES_DMDEV ?
>
> afaict the _cleanup() function will call _log_writes_cleanup ->
> _log_writes_remove for you.
Good point, I had forgotten that rely on the _cleanup handling. I'll
fix that in the next version of these patches.
- Ted
next prev parent reply other threads:[~2024-06-11 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 8:58 [PATCH 1/2] ext4/045: skip test if the block size is 1k Theodore Ts'o
2024-06-11 8:58 ` [PATCH 2/2] generic/455: skip the test if the file system doesn't support journaling Theodore Ts'o
2024-06-11 14:27 ` Darrick J. Wong
2024-06-11 22:26 ` Theodore Ts'o [this message]
2024-06-11 14:27 ` [PATCH 1/2] ext4/045: skip test if the block size is 1k Darrick J. Wong
2024-06-11 16:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611222646.GA1906022@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox