Re: [PATCH 1/2] ext4/045: skip test if the block size is 1k

["Theodore Ts'o" <tytso@mit.edu>]

On Tue, Jun 11, 2024 at 07:27:54AM -0700, Darrick J. Wong wrote:
> On Tue, Jun 11, 2024 at 04:58:52AM -0400, Theodore Ts'o wrote:
> > If the file system is 1k, this test will fail because with dir_index
> > enabled, the directory tree will get too deep, and the kernel will
> > return ENOSPC and log the EXT4-fs warning "Directory (ino: NNN) index
> > full, reach max htree level: 2".  So if the blocksize is less than 2k,
> > _notrun this test.
> 
> Didn't ext4 recently gain support for 3-level htrees?

Ext4 has support for a while, but it's an optional feature which is
not enabled by default.  I suppose we could try to set the feature,
and skip the test if the kernel doesn't support it.  (Or decide that
no one cares about RHEL7, and just YOLO, since who else still cares
about kernels older than 4.13?  :-)

I'm just not sure whether it's worth the extra complexity to do it,
but for those people who care about code coverage statistics, it would
help a tiny amount....

						- Ted