FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: [PATCH 1/3] dmthin: _notrun when dm-thin setup fails
Date: Mon, 18 Aug 2025 09:27:16 +0200	[thread overview]
Message-ID: <20250818072724.1559133-2-hch@lst.de> (raw)
In-Reply-To: <20250818072724.1559133-1-hch@lst.de>

dm-think does not work on device with protection information.  Instead
of failing the tests using it in obscure ways, _norun them.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 common/dmthin | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/dmthin b/common/dmthin
index 453e43a0499e..a1e1fb8763c0 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -105,13 +105,13 @@ _dmthin_init()
 	# Metadata device
 	DMTHIN_META_TABLE="0 $meta_dev_size linear $dm_backing_dev $meta_dev_offset"
 	_dmsetup_create $DMTHIN_META_NAME --table "$DMTHIN_META_TABLE" || \
-		_fatal "failed to create dm thin meta device"
+		_notrun "failed to create dm thin meta device"
 
 	# Data device
 	local data_dev_offset=$((meta_dev_offset + $meta_dev_size))
 	DMTHIN_DATA_TABLE="0 $data_dev_size linear $dm_backing_dev $data_dev_offset"
 	_dmsetup_create $DMTHIN_DATA_NAME --table "$DMTHIN_DATA_TABLE" || \
-		_fatal "failed to create dm thin data device"
+		_notrun "failed to create dm thin data device"
 
 	# Zap the pool metadata dev.  Explicitly fsync the zeroes to disk
 	# because a slow-running udev running concurrently with dd can maintain
@@ -124,16 +124,16 @@ _dmthin_init()
 	# "start length thin-pool metadata_dev data_dev data_block_size low_water_mark"
 	DMTHIN_POOL_TABLE="0 $data_dev_size thin-pool $DMTHIN_META_DEV $DMTHIN_DATA_DEV $cluster_size $low_water"
 	_dmsetup_create $DMTHIN_POOL_NAME --table "$DMTHIN_POOL_TABLE" || \
-		_fatal "failed to create dm thin pool device"
+		_notun "failed to create dm thin pool device"
 
 	# Thin volume
 	$DMSETUP_PROG message $DMTHIN_POOL_DEV 0 "create_thin $pool_id" || \
-		_fatal "failed to message pool device"
+		_notrun "failed to message pool device"
 
 	# start length thin pool_dev dev_id [external_origin_dev]
 	DMTHIN_VOL_TABLE="0 $virtual_size thin $DMTHIN_POOL_DEV $pool_id"
 	_dmsetup_create $DMTHIN_VOL_NAME --table "$DMTHIN_VOL_TABLE" || \
-		_fatal "failed to create dm thin volume device"
+		_notrun "failed to create dm thin volume device"
 
 }
 
-- 
2.47.2


  reply	other threads:[~2025-08-18  7:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  7:27 fixes for running on devices with protetion information Christoph Hellwig
2025-08-18  7:27 ` Christoph Hellwig [this message]
2025-08-18 20:51   ` [PATCH 1/3] dmthin: _notrun when dm-thin setup fails Darrick J. Wong
2025-08-25 15:44     ` Zorro Lang
2025-08-26 13:22       ` Christoph Hellwig
2025-08-27 16:20         ` Zorro Lang
2025-08-18  7:27 ` [PATCH 2/3] generic/081: don't hang when running on devices with protection information Christoph Hellwig
2025-08-18 20:51   ` Darrick J. Wong
2025-08-18  7:27 ` [PATCH 3/3] generic/450: " Christoph Hellwig
2025-08-18 20:52   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818072724.1559133-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox