Re: [PATCH 2/3] generic/081: don't hang when running on devices with protection information

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 18, 2025 at 09:27:17AM +0200, Christoph Hellwig wrote:
> The dm snapshot target does not work on devices with protection
> information, and the udevadm settle command simply hangs when lvcreate
> failed because of that.  Avoid that by doing a strategic _notrun when
> lvcreate fails.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Makes sense to me
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  tests/generic/081 | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/generic/081 b/tests/generic/081
> index 97928bf4a435..00280e9cff3b 100755
> --- a/tests/generic/081
> +++ b/tests/generic/081
> @@ -73,7 +73,8 @@ $LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1 || \
>  	_notrun "LVM is too stupid for this device"
>  # We use yes pipe instead of 'lvcreate --yes' because old version of lvm
>  # (like 2.02.95 in RHEL6) don't support --yes option
> -yes | $LVM_PROG lvcreate -L ${lvsize}M -n $lvname $vgname >>$seqres.full 2>&1
> +yes | $LVM_PROG lvcreate -L ${lvsize}M -n $lvname $vgname >>$seqres.full 2>&1 \
> +	|| _notrun "Can't set up LVM"
>  _udev_wait /dev/mapper/$vgname-$lvname
>  
>  
> -- 
> 2.47.2
> 
>