From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org
Subject: Re: [PATCH 1/3] dmthin: _notrun when dm-thin setup fails
Date: Tue, 26 Aug 2025 15:22:30 +0200 [thread overview]
Message-ID: <20250826132230.GA1870@lst.de> (raw)
In-Reply-To: <20250825154410.dt5avycrauhtd2te@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Mon, Aug 25, 2025 at 11:44:10PM +0800, Zorro Lang wrote:
> > Anyhow, failure to set up a dm-thinp volume sounds like failing to meet
> > a test precondition, sooo
>
> I'm wondering, if we choose _notrun when _dmthin_init/dmsetup_create fails,
> but others _dmxxxx_init/dmsetup_create [1] fails, we still call _fatal. Isn't
> that an inconsistent behavior :)
I think more notrun would be fine. These are the ones I ran into
with a totally normal setup that has PI enabled on the test and
scratch devices, so they were my priority.
next prev parent reply other threads:[~2025-08-26 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 7:27 fixes for running on devices with protetion information Christoph Hellwig
2025-08-18 7:27 ` [PATCH 1/3] dmthin: _notrun when dm-thin setup fails Christoph Hellwig
2025-08-18 20:51 ` Darrick J. Wong
2025-08-25 15:44 ` Zorro Lang
2025-08-26 13:22 ` Christoph Hellwig [this message]
2025-08-27 16:20 ` Zorro Lang
2025-08-18 7:27 ` [PATCH 2/3] generic/081: don't hang when running on devices with protection information Christoph Hellwig
2025-08-18 20:51 ` Darrick J. Wong
2025-08-18 7:27 ` [PATCH 3/3] generic/450: " Christoph Hellwig
2025-08-18 20:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826132230.GA1870@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox