FS/XFS testing framework
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: [PATCH 3/3] generic/450: don't hang when running on devices with protection information
Date: Mon, 18 Aug 2025 09:27:18 +0200	[thread overview]
Message-ID: <20250818072724.1559133-4-hch@lst.de> (raw)
In-Reply-To: <20250818072724.1559133-1-hch@lst.de>

The dm thinp target does not work on devices with protection information,
and the udevadm settle command simply hangs when lvcreate failed because
of that.  Avoid that by doing a strategic _notrun when lvcreate fails.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/generic/459 | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/generic/459 b/tests/generic/459
index 3f5f0f2b7dc1..48520f9f4af0 100755
--- a/tests/generic/459
+++ b/tests/generic/459
@@ -93,12 +93,14 @@ $LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1
 
 $LVM_PROG lvcreate  --thinpool $poolname  --errorwhenfull y \
 		    --zero n -L $origpsize \
-		    --poolmetadatasize 4M $vgname >>$seqres.full 2>&1
+		    --poolmetadatasize 4M $vgname >>$seqres.full 2>&1 || \
+	_notrun "Can't create thin pool"
 
 # Create a overprovisioned 300MB dm-thin virt. device
 $LVM_PROG lvcreate  --virtualsize $virtsize \
 		    -T $vgname/$poolname \
-		    -n $lvname >>$seqres.full 2>&1
+		    -n $lvname >>$seqres.full 2>&1 || \
+	_notrun "Can't create thin volume"
 _udev_wait /dev/mapper/$vgname-$lvname
 _mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
 
-- 
2.47.2


  parent reply	other threads:[~2025-08-18  7:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  7:27 fixes for running on devices with protetion information Christoph Hellwig
2025-08-18  7:27 ` [PATCH 1/3] dmthin: _notrun when dm-thin setup fails Christoph Hellwig
2025-08-18 20:51   ` Darrick J. Wong
2025-08-25 15:44     ` Zorro Lang
2025-08-26 13:22       ` Christoph Hellwig
2025-08-27 16:20         ` Zorro Lang
2025-08-18  7:27 ` [PATCH 2/3] generic/081: don't hang when running on devices with protection information Christoph Hellwig
2025-08-18 20:51   ` Darrick J. Wong
2025-08-18  7:27 ` Christoph Hellwig [this message]
2025-08-18 20:52   ` [PATCH 3/3] generic/450: " Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818072724.1559133-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox