Re: [PATCH 06/13] xfs/2301: test lazy bounce buffering mode

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Sep 24, 2026 at 12:07:47PM +0200, Christoph Hellwig wrote:
> Run fsx (based on generic/091) while injecting lazy bounce buffer
> retries for reads.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/2301     | 43 +++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/2301.out | 13 +++++++++++++
>  2 files changed, 56 insertions(+)
>  create mode 100755 tests/xfs/2301
>  create mode 100644 tests/xfs/2301.out
> 
> diff --git a/tests/xfs/2301 b/tests/xfs/2301
> new file mode 100755
> index 000000000000..605510c6dbc8
> --- /dev/null
> +++ b/tests/xfs/2301
> @@ -0,0 +1,43 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2000-2004 Silicon Graphics, Inc.  All Rights Reserved.
> +# Copyright (c) 2026 Christoph Hellwig.
> +#
> +# FS QA Test No. 2301
> +#
> +# Run fsx with error injection for re-retries with bounce buffers, simulating

Aren't these just retries?

> +# users modifying the in-flight data buffer.
> +#
> +. ./common/preamble
> +_begin_fstest rw auto quick datacsum
> +
> +. ./common/filter
> +. ./common/inject
> +
> +_require_test
> +_require_odirect
> +_require_xfs_data_csum $TEST_DIR
> +
> +psize=`$here/src/feature -s`
> +bsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV`
> +
> +_test_inject_error bounce_reread 100

Were it not for this I'd say this should be a generic test.  But I guess
generic/091 tests the no-bounce code paths just fine, right?

> +# fsx load similar to generic/091
> +echo "Testing direct I/O"
> +run_fsx -N 10000            -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +run_fsx -N 10000  -o 8192   -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +run_fsx -N 10000  -o 32768  -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +run_fsx -N 10000  -o 8192   -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +run_fsx -N 10000  -o 32768  -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +run_fsx -N 10000  -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W
> +
> +# fsx load similar to generic/091 but using buffered I/O
> +echo "Testing buffered I/O"
> +run_fsx -N 10000            -l 500000
> +run_fsx -N 10000  -o 8192   -l 500000
> +run_fsx -N 10000  -o 32768  -l 500000
> +run_fsx -N 10000  -o 128000 -l 500000
> +
> +status=0
> +exit

_exit 0

--D

> diff --git a/tests/xfs/2301.out b/tests/xfs/2301.out
> new file mode 100644
> index 000000000000..221a3185970c
> --- /dev/null
> +++ b/tests/xfs/2301.out
> @@ -0,0 +1,13 @@
> +QA output created by 2301
> +Testing direct I/O
> +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W
> +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W
> +Testing buffered I/O
> +fsx -N 10000 -l 500000
> +fsx -N 10000 -o 8192 -l 500000
> +fsx -N 10000 -o 32768 -l 500000
> +fsx -N 10000 -o 128000 -l 500000
> -- 
> 2.53.0
> 
>