Re: [PATCH 09/13] xfs/2304: version of generic/388 that run xfs_scrub -x for each iteration

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Oct 07, 2026 at 03:42:02PM +0200, Christoph Hellwig wrote:
> On Mon, Oct 05, 2026 at 08:20:57AM -0700, Darrick J. Wong wrote:
> > I was about to repy "Sounds like a good idea for g388 and probably g475
> > as well" but then I remembered something from my notes.  The two tests
> > run without _check_filesystems on the assumption that accidental
> > corruptions will multiply until either (a) the cycle_mount will fail or
> > (b) the post-test _check_filesystems will have a lot to complain about.
> > Doing the check every loop cycle reduces the number of log recoveries
> > that we can do in a given SOAK_DURATION by a significant amount.
> > 
> > What if we ran $XFS_IO_PROG -c verifymedia once per loop if
> > XFS_VERIFY_FILE_DATA?  That would avoid a full xfs_{repair,scrub} run
> > (+ extra mount cycle) but catch problems earlier.
> 
> $XFS_IO_PROG -c verifymedia would also verify potentially unwritten
> areas.  We'd still need the full xfs_scrub space map scan at least,
> but I can look into an option to only do media verification in
> scrub, which also sounds useful outside of just xfstests.

XFS_SCRUB_PHASE=6 xfs_scrub -d -x $SCRATCH_MNT

--D