From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: [PATCH 0/7] git_hash_*() quality-of-life improvements
Date: Tue, 7 Jul 2026 00:55:56 -0400 [thread overview]
Message-ID: <20260707045556.GA1288172@coredump.intra.peff.net> (raw)
This implements the "idempotent git_hash_discard()" discussed in this
subthread:
https://lore.kernel.org/git/20260702080707.GG2029434@coredump.intra.peff.net/
with associated cleanups.
It should be applied on top of jk/hash-algo-leak-fixes.
[1/7]: hash: use git_hash_init() consistently
[2/7]: hash: convert remaining direct function calls
[3/7]: hash: document function pointers and wrappers
[4/7]: hash: make git_hash_discard() idempotent
[5/7]: csum-file: use idempotent git_hash_discard()
[6/7]: http: use idempotent git_hash_discard()
[7/7]: hash: check ctx->active flag in all wrapper functions
builtin/fast-import.c | 4 +--
builtin/index-pack.c | 6 ++--
builtin/patch-id.c | 2 +-
builtin/receive-pack.c | 6 ++--
builtin/submodule--helper.c | 10 +++---
builtin/unpack-objects.c | 4 +--
csum-file.c | 23 +++++---------
diff.c | 4 +--
hash.c | 16 ++++++++++
hash.h | 44 +++++++++++++++++++-------
http-push.c | 2 +-
http.c | 9 ++----
http.h | 1 -
object-file.c | 17 +++++-----
pack-check.c | 2 +-
pack-write.c | 6 ++--
read-cache.c | 6 ++--
rerere.c | 5 +--
t/helper/test-hash-speed.c | 2 +-
t/helper/test-hash.c | 2 +-
t/helper/test-synthesize.c | 33 ++++++++++---------
t/unit-tests/u-hash.c | 2 +-
tools/coccinelle/hash.cocci | 63 +++++++++++++++++++++++++++++++++++++
trace2/tr2_sid.c | 2 +-
24 files changed, 181 insertions(+), 90 deletions(-)
create mode 100644 tools/coccinelle/hash.cocci
-Peff
next reply other threads:[~2026-07-07 4:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 4:55 Jeff King [this message]
2026-07-07 5:01 ` [PATCH 1/7] hash: use git_hash_init() consistently Jeff King
2026-07-07 14:39 ` Junio C Hamano
2026-07-07 20:13 ` Jeff King
2026-07-07 20:17 ` Junio C Hamano
2026-07-07 20:25 ` Jeff King
2026-07-07 21:25 ` brian m. carlson
2026-07-08 3:54 ` Jeff King
2026-07-07 5:04 ` [PATCH 2/7] hash: convert remaining direct function calls Jeff King
2026-07-07 16:15 ` Junio C Hamano
2026-07-07 5:05 ` [PATCH 3/7] hash: document function pointers and wrappers Jeff King
2026-07-07 14:26 ` Patrick Steinhardt
2026-07-07 20:05 ` Jeff King
2026-07-07 5:07 ` [PATCH 4/7] hash: make git_hash_discard() idempotent Jeff King
2026-07-07 16:22 ` Junio C Hamano
2026-07-07 20:18 ` Jeff King
2026-07-07 21:41 ` brian m. carlson
2026-07-07 22:25 ` Junio C Hamano
2026-07-07 5:07 ` [PATCH 5/7] csum-file: use idempotent git_hash_discard() Jeff King
2026-07-07 5:08 ` [PATCH 6/7] http: " Jeff King
2026-07-07 16:25 ` Junio C Hamano
2026-07-07 5:09 ` [PATCH 7/7] hash: check ctx->active flag in all wrapper functions Jeff King
2026-07-07 14:26 ` Patrick Steinhardt
2026-07-07 16:33 ` Junio C Hamano
2026-07-07 20:10 ` Jeff King
2026-07-07 14:26 ` [PATCH 0/7] git_hash_*() quality-of-life improvements Patrick Steinhardt
2026-07-08 3:52 ` [PATCH v2 " Jeff King
2026-07-08 3:52 ` [PATCH v2 1/7] hash: use git_hash_init() consistently Jeff King
2026-07-08 3:52 ` [PATCH v2 2/7] hash: convert remaining direct function calls Jeff King
2026-07-08 3:52 ` [PATCH v2 3/7] hash: document function pointers and wrappers Jeff King
2026-07-08 3:52 ` [PATCH v2 4/7] hash: make git_hash_discard() idempotent Jeff King
2026-07-08 3:53 ` [PATCH v2 5/7] csum-file: use idempotent git_hash_discard() Jeff King
2026-07-08 3:53 ` [PATCH v2 6/7] http: " Jeff King
2026-07-08 3:53 ` [PATCH v2 7/7] hash: check ctx->active flag in all wrapper functions Jeff King
2026-07-08 8:05 ` [PATCH v2 0/7] git_hash_*() quality-of-life improvements Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707045556.GA1288172@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox