Git development
 help / color / mirror / Atom feed
From: Vsevolod Myalitsin <ub4nal@mail.ru>
To: git@vger.kernel.org
Cc: ub4nal@mail.ru, ben.knoble@gmail.org, gitster@pobox.me, peff@peff.net
Subject: [PATCH v4 3/3] advice: use global config for default branch name
Date: Thu, 10 Sep 2026 11:53:53 +0300	[thread overview]
Message-ID: <20260910085353.109373-4-ub4nal@mail.ru> (raw)
In-Reply-To: <20260910085353.109373-1-ub4nal@mail.ru>

The advice for setting the default branch name currently suggests
disabling it with a local configuration value.

This makes the advice appear again when a new repository is initialized.
Suggest using the global configuration scope instead, so that disabling
the advice applies to future repositories as well.

Signed-off-by: Vsevolod Myalitsin <ub4nal@mail.ru>
---
 advice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/advice.c b/advice.c
index 12a68ea716..6964a6e2ba 100644
--- a/advice.c
+++ b/advice.c
@@ -54,7 +54,7 @@ static struct advice_setting advice_setting[] = {
 	[ADVICE_AM_WORK_DIR] 				= { "amWorkDir" },
 	[ADVICE_CHECKOUT_AMBIGUOUS_REMOTE_BRANCH_NAME] 	= { "checkoutAmbiguousRemoteBranchName" },
 	[ADVICE_COMMIT_BEFORE_MERGE]			= { "commitBeforeMerge" },
-	[ADVICE_DEFAULT_BRANCH_NAME]			= { "defaultBranchName" },
+	[ADVICE_DEFAULT_BRANCH_NAME]			= { "defaultBranchName", CONFIG_SCOPE_GLOBAL },
 	[ADVICE_DETACHED_HEAD]				= { "detachedHead" },
 	[ADVICE_DIVERGING]				= { "diverging" },
 	[ADVICE_FETCH_SET_HEAD_WARN]			= { "fetchRemoteHEADWarn" },
-- 
2.50.1


      parent reply	other threads:[~2026-09-10  8:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2027-08-29  0:49 [PATCH v3] advice: use global config for default branch name Vsevolod Myalitsin
2026-09-09 20:27 ` Jeff King
2026-09-09 21:21   ` Junio C Hamano
2026-09-09 21:22   ` Vsevolod Myalitsin
2026-09-09 22:46     ` Jeff King
2026-09-10  4:43       ` Vsevolod Myalitsin
2026-09-09 20:50 ` Junio C Hamano
2026-09-09 21:30   ` Vsevolod Myalitsin
2026-09-09 22:31     ` Junio C Hamano
2026-09-10  8:53 ` [PATCH v4 0/3] defaultBranchName advice is useless Vsevolod Myalitsin
2026-09-10  8:53   ` [PATCH v4 1/3] advice: pass the entire advice_setting to vadvise() Vsevolod Myalitsin
2026-09-10 17:43     ` SZEDER Gábor
2026-09-10  8:53   ` [PATCH v4 2/3] advice: introduce advice scoping mechanism Vsevolod Myalitsin
2026-09-10 15:36     ` Junio C Hamano
2026-09-10 15:52       ` Jeff King
2026-09-10 17:54         ` Vsevolod Myalitsin
2026-09-10 19:05           ` Jeff King
2026-09-10 18:35         ` Junio C Hamano
2026-09-10 19:03           ` Jeff King
2026-09-10 19:54             ` Junio C Hamano
2026-09-10 20:11               ` Jeff King
2026-09-10 20:25                 ` Junio C Hamano
2026-09-12  8:12                   ` Vsevolod Myalitsin
2026-09-13 16:32                     ` Junio C Hamano
2026-09-10  8:53   ` Vsevolod Myalitsin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910085353.109373-4-ub4nal@mail.ru \
    --to=ub4nal@mail.ru \
    --cc=ben.knoble@gmail.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.me \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox