Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

[Junio C Hamano <gitster@pobox.com>]

Jeff King <peff@peff.net> writes:

> I'd be surprised if anybody really thought carefully about it, though.
> When I introduced advice.* in 2009 (geez, has it really been that long?)
> I had assumed people would just set it in their user config. The actual
> "git config" command advice came much later, but I don't see any
> discussion of global vs local in that thread:
>
>   https://lore.kernel.org/git/pull.548.git.1581311049547.gitgitgadget@gmail.com/
>
> Amusingly that thread also touches on some of the "could we just convert
> everything to advise_if_enabled()" issues we've discussed here. I had
> zero recollection of it, despite participating.

I do not think I added much input into the topic at the
philosophical design level---just the usual usability and
correctness review.  No wonder I do not recall anything particular I
contributed to the discussion there ;-)

It is very much understandable if we didn't mean the "use 'git
config advice.foo false' to disable" as a cut-and-paste ready
instruction, and rather meant as a general instruction that any
intelligent users would tweak for their own situation.  And it is
not surprising, from such a stance, the 'git config' hint would not
come with any scope indicator.