Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Vsevolod Myalitsin <ub4nal@mail.ru>,
	 git@vger.kernel.org, gitster@pobox.me,  ben.knoble@gmail.org
Subject: Re: [PATCH v3] advice: use global config for default branch name
Date: Wed, 09 Sep 2026 14:21:18 -0700	[thread overview]
Message-ID: <xmqqecf2p1dd.fsf@gitster.g> (raw)
In-Reply-To: <20260909202718.GA183838@coredump.intra.peff.net> (Jeff King's message of "Wed, 9 Sep 2026 16:27:18 -0400")

Jeff King <peff@peff.net> writes:

> I had somehow hoped we could reuse the existing CONFIG_SCOPE enum
> without having to redeclare it ourselves. But there are a lot more
> scopes than these three! On the other hand, I think it would be possible
> to use config_scope_name() to convert them into options.

I had the same thought, and do not have strong opinion myself either
way.

For everything else you suggested in your review, I think we would
want a hopefully small and final reroll.

Thanks.


  reply	other threads:[~2026-09-09 21:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2027-08-29  0:49 [PATCH v3] advice: use global config for default branch name Vsevolod Myalitsin
2026-09-09 20:27 ` Jeff King
2026-09-09 21:21   ` Junio C Hamano [this message]
2026-09-09 21:22   ` Vsevolod Myalitsin
2026-09-09 22:46     ` Jeff King
2026-09-10  4:43       ` Vsevolod Myalitsin
2026-09-09 20:50 ` Junio C Hamano
2026-09-09 21:30   ` Vsevolod Myalitsin
2026-09-09 22:31     ` Junio C Hamano
2026-09-10  8:53 ` [PATCH v4 0/3] defaultBranchName advice is useless Vsevolod Myalitsin
2026-09-10  8:53   ` [PATCH v4 1/3] advice: pass the entire advice_setting to vadvise() Vsevolod Myalitsin
2026-09-10 17:43     ` SZEDER Gábor
2026-09-10  8:53   ` [PATCH v4 2/3] advice: introduce advice scoping mechanism Vsevolod Myalitsin
2026-09-10 15:36     ` Junio C Hamano
2026-09-10 15:52       ` Jeff King
2026-09-10 17:54         ` Vsevolod Myalitsin
2026-09-10 19:05           ` Jeff King
2026-09-10 18:35         ` Junio C Hamano
2026-09-10 19:03           ` Jeff King
2026-09-10 19:54             ` Junio C Hamano
2026-09-10 20:11               ` Jeff King
2026-09-10 20:25                 ` Junio C Hamano
2026-09-12  8:12                   ` Vsevolod Myalitsin
2026-09-13 16:32                     ` Junio C Hamano
2026-09-10  8:53   ` [PATCH v4 3/3] advice: use global config for default branch name Vsevolod Myalitsin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqecf2p1dd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.me \
    --cc=peff@peff.net \
    --cc=ub4nal@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox