From: Muhammed Dilshad A <dilsheddilu123@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, ps@pks.im,
Muhammed Dilshad A <dilsheddilu123@gmail.com>
Subject: Re: [PATCH v3 1/4] mergesort: move sorting tests to Clar
Date: Mon, 12 Oct 2026 09:41:18 +0530 [thread overview]
Message-ID: <20261012041118.14682-1-dilsheddilu123@gmail.com> (raw)
In-Reply-To: <xmqqy0c4emvk.fsf@gitster.g>
Hi Junio,
Using more headers would not prevent this move. That first sentence
doesn't explain the reason, so I'll remove it.
These tests work on lists in memory and don't need a Git repository.
Moving them to Clar replaces the helper's hand-written pass/fail code
with the existing unit-test assertions and reporting. It also removes
the shell test and the helper's test command.
I'll rewrite the commit message to explain that reason.
Regards,
Dilshad
next prev parent reply other threads:[~2026-10-12 4:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 3:42 [PATCH] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 6:13 ` Patrick Steinhardt
2026-10-07 17:27 ` Junio C Hamano
2026-10-07 13:50 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 1/3] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 2/3] mergesort: move sorting tests to the unit-test framework Muhammed Dilshad A
2026-10-09 11:52 ` Patrick Steinhardt
2026-10-09 13:55 ` Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 3/3] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
2026-10-09 11:52 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Patrick Steinhardt
2026-10-09 13:56 ` Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 0/4] mergesort: move tests to Clar and remove " Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 1/4] mergesort: move sorting tests to Clar Muhammed Dilshad A
2026-10-11 7:07 ` Junio C Hamano
2026-10-12 4:11 ` Muhammed Dilshad A [this message]
2026-10-09 15:08 ` [PATCH v3 2/4] mergesort: simplify the unit tests Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 3/4] mergesort: cover empty and small lists Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 4/4] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012041118.14682-1-dilsheddilu123@gmail.com \
--to=dilsheddilu123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox