From: Junio C Hamano <gitster@pobox.com>
To: Muhammed Dilshad A <dilsheddilu123@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH v3 1/4] mergesort: move sorting tests to Clar
Date: Sun, 11 Oct 2026 00:07:27 -0700 [thread overview]
Message-ID: <xmqqy0c4emvk.fsf@gitster.g> (raw)
In-Reply-To: <21f46a2c9046d1da68233467bafb4b69226f35e6.1791556668.git.dilsheddilu123@gmail.com> (Muhammed Dilshad A.'s message of "Fri, 9 Oct 2026 20:38:47 +0530")
Muhammed Dilshad A <dilsheddilu123@gmail.com> writes:
> The numeric sorting tests only use mergesort.h. Move them from test-tool
> to Clar, keeping the same inputs and checks for sorted order, stable
> ordering of equal values, and list length.
The above I can parse, I know what these words mean, yet I do not
think I understand what the sentences want to say. What is the
point of saying the first sentence, for example? Is it the reason
why "Move them ... to Clar" is a good idea? Is it what allows us to
"Move them ... to Clar" (in other words, if the tests used more than
just mergesort.h, moving to Clar would have been impossible)?
> Store the list items in an array so cleanup can free them even if the
> sort leaves the links broken.
>
> Remove t0071 and the helper's generate and test commands. Keep the sort
> command for p0071 for now.
>
> Suggested-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Muhammed Dilshad A <dilsheddilu123@gmail.com>
next prev parent reply other threads:[~2026-10-11 7:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 3:42 [PATCH] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 6:13 ` Patrick Steinhardt
2026-10-07 17:27 ` Junio C Hamano
2026-10-07 13:50 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 1/3] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 2/3] mergesort: move sorting tests to the unit-test framework Muhammed Dilshad A
2026-10-09 11:52 ` Patrick Steinhardt
2026-10-09 13:55 ` Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 3/3] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
2026-10-09 11:52 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Patrick Steinhardt
2026-10-09 13:56 ` Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 0/4] mergesort: move tests to Clar and remove " Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 1/4] mergesort: move sorting tests to Clar Muhammed Dilshad A
2026-10-11 7:07 ` Junio C Hamano [this message]
2026-10-12 4:11 ` Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 2/4] mergesort: simplify the unit tests Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 3/4] mergesort: cover empty and small lists Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 4/4] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0c4emvk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dilsheddilu123@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox