Git development
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Junio C Hamano <gitster@pobox.com>,
	graysongordon-gl <graysongordon1@gmail.com>,
	git@vger.kernel.org, peff@peff.net, avarab@gmail.com
Subject: Re: [PATCH v7] http: add http.sslVerifyStatus to check stapled OCSP responses
Date: Fri, 25 Sep 2026 11:28:58 +0200	[thread overview]
Message-ID: <arY+2p3YZWlyL9Gq@szeder.dev> (raw)
In-Reply-To: <arTYVLnW-2GHpGGm@pks.im>

On Thu, Sep 24, 2026 at 09:59:16AM +0200, Patrick Steinhardt wrote:
> On Thu, Sep 24, 2026 at 09:41:41AM +0200, SZEDER Gábor wrote:
> > On Wed, Sep 23, 2026 at 02:47:18PM -0700, Junio C Hamano wrote:
> > > SZEDER Gábor <szeder.dev@gmail.com> writes:
> > > 
> > > > On Tue, Sep 15, 2026 at 12:23:48PM -0400, graysongordon-gl wrote:
> > > >> From: Grayson Gordon <graysongordon1@gmail.com>
> > > >> 
> > > >> git never sets CURLOPT_SSL_VERIFYSTATUS, so libcurl never requests the
> > > >> OCSP "Certificate Status Request" extension and any stapled response a
> > > >> server sends is ignored, including responses that explicitly state the
> > > >> certificate has been revoked.
> > > > ...
> > > > This patch was merged to 'next' the other day, and the last test in
> > > > the new t5585 fails on my system.
> > > 
> > > Sorry about a premature merge.  Since we are not in a hurry to take
> > > this topic in (or no new feature topic in general), let me revert it
> > > out of 'next' and give it a clean slate to try again.
> > 
> > Well, if you hadn't merged it, we would perhaps still be none the
> > wiser, because, alas, I don't have the bandwidth to run tests on the
> > seen branch regularly...
> > 
> > However, CI does, but I can't seem to find any CI runs that failed
> > because of this, which makes me worried that something is wrong on my
> > end.
> 
> Do you maybe run with a curl backend that doesn't properly support OCSP?
> But even if so, our test suite should notice and skip the tests.

Apparently I did!  Removing 'libcurl4-gnutls-dev' and installing
'libcurl4-openssl-dev' instead makes t5585 succeed.  Go figure.

Thanks for the hint!


  reply	other threads:[~2026-09-25  9:29 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 17:02 [PATCH] http: add http.sslVerifyStatus to check stapled OCSP responses graysongordon-gl
2026-08-11 19:28 ` Junio C Hamano
2026-08-11 20:44 ` [PATCH v2] " graysongordon-gl
2026-08-12  6:25   ` Patrick Steinhardt
2026-08-12 15:53     ` Grayson Gordon
2026-08-12 14:17   ` Junio C Hamano
2026-08-12 18:25     ` [PATCH v3] " graysongordon-gl
2026-08-12 21:34       ` Junio C Hamano
2026-08-13 16:06         ` Junio C Hamano
2026-08-17 18:52           ` [PATCH v4] " graysongordon-gl
2026-08-17 19:19             ` Junio C Hamano
2026-08-18  7:50             ` Patrick Steinhardt
2026-08-18 14:51               ` Grayson Gordon
2026-08-19  8:14                 ` Patrick Steinhardt
2026-08-18 16:40               ` Junio C Hamano
2026-08-18 19:37           ` [PATCH v5] " graysongordon-gl
2026-08-18 20:12             ` Junio C Hamano
2026-08-18 21:22               ` Grayson Gordon
2026-08-18 21:48           ` [PATCH v6] " graysongordon-gl
2026-08-26 22:01             ` Junio C Hamano
2026-08-28 13:51               ` Grayson Gordon
2026-08-28 17:20                 ` Junio C Hamano
2026-08-31  6:56                   ` Patrick Steinhardt
2026-08-31 14:16                     ` Junio C Hamano
2026-08-31 14:24                       ` Patrick Steinhardt
2026-08-31 14:31                         ` Junio C Hamano
2026-09-08 12:55                           ` Grayson Gordon
2026-09-15 16:23                           ` [PATCH v7] " graysongordon-gl
2026-09-16 19:29                             ` Junio C Hamano
2026-09-23 12:42                             ` Patrick Steinhardt
2026-09-23 21:43                               ` Junio C Hamano
2026-09-23 21:07                             ` SZEDER Gábor
2026-09-23 21:47                               ` Junio C Hamano
2026-09-24  7:41                                 ` SZEDER Gábor
2026-09-24  7:59                                   ` Patrick Steinhardt
2026-09-25  9:28                                     ` SZEDER Gábor [this message]
2026-09-25 16:13                                       ` Junio C Hamano
2026-09-24 16:22                                   ` Junio C Hamano
2026-10-07 18:18                                   ` Junio C Hamano
2026-10-08  4:57                                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arY+2p3YZWlyL9Gq@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=graysongordon1@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox