Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] ident: remove unused author_ident_sufficiently_given()
Date: Wed, 4 Nov 2026 07:41:16 +0100	[thread overview]
Message-ID: <aurTjEgKc5yw_vwD@pks.im> (raw)
In-Reply-To: <xmqqtslx7nam.fsf@gitster.g>

On Tue, Nov 03, 2026 at 11:00:33AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > On Fri, Oct 30, 2026 at 10:39:53AM -0700, Junio C Hamano wrote:
> >> A pair of functions {author,committer}_ident_sufficiently_given()
> >> were created to replace user_ident_explicitly_given() in d6991ceedc
> >
> > Nit, not worth a reroll, but isn't it "was created" as it is a singular
> > pair? Might just be me not being a native speaker though.
> 
> Neither am I a native speaker, but "Syntactic vs Notional Agreement"
> is what makes both valid.
> 
> Treating the "pair" as a singular subject is the strictly formal
> choice preferred by most academic and traditional style guides.
> 
> Even though "pair" is grammatically singular, it represents two
> distinct things, and in this particular case, we are retiring one of
> them while keeping the other, treating the "pair" as a separable
> two.

Thanks, today I learned :)

Patrick

  reply	other threads:[~2026-11-04  6:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 17:39 [PATCH 0/4] mark symbols that are unnecessarily public static Junio C Hamano
2026-10-30 17:39 ` [PATCH 1/4] ident: remove unused author_ident_sufficiently_given() Junio C Hamano
2026-10-30 18:22   ` Jeff King
2026-11-03 10:23   ` Patrick Steinhardt
2026-11-03 19:00     ` Junio C Hamano
2026-11-04  6:41       ` Patrick Steinhardt [this message]
2026-10-30 17:39 ` [PATCH 2/4] add -i: hide init/clear_add_i_state() functions Junio C Hamano
2026-11-03 10:23   ` Patrick Steinhardt
2026-11-03 19:01     ` Junio C Hamano
2026-10-30 17:39 ` [PATCH 3/4] read-cache: hide refresh_cache_entry() Junio C Hamano
2026-10-30 18:25   ` Jeff King
2026-10-30 17:39 ` [PATCH 4/4] unpack-trees: hide verify_uptodate() Junio C Hamano
2026-10-30 18:26 ` [PATCH 0/4] mark symbols that are unnecessarily public static Jeff King
2026-11-03 10:23   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aurTjEgKc5yw_vwD@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox