Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] add -i: hide init/clear_add_i_state() functions
Date: Tue, 03 Nov 2026 11:01:13 -0800	[thread overview]
Message-ID: <xmqqpkwl7n9i.fsf@gitster.g> (raw)
In-Reply-To: <aum2HcP3BlSDQCGJ@pks.im> (Patrick Steinhardt's message of "Tue, 3 Nov 2026 11:23:25 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> On Fri, Oct 30, 2026 at 10:39:54AM -0700, Junio C Hamano wrote:
>> The "add -i" machinery is encapsulated in run_add_i() function,
>> which uses init_add_i_state() to initialize the machinery, does its
>> thing, and clear_add_i_state() to tear it down.  External callers
>> have no need to call anything other than run_add_i(), starting at
>> d51b61f5da (add-patch: remove dependency on "add-interactive"
>> subsystem, 2026-03-02) refactored the code paths involved.
>
> This sentence reads a bit odd. Probably missing a "which"?
>
> Patrick

Thanks.  ", which refactored the code paths..." is what it should
have said.

  reply	other threads:[~2026-11-03 19:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 17:39 [PATCH 0/4] mark symbols that are unnecessarily public static Junio C Hamano
2026-10-30 17:39 ` [PATCH 1/4] ident: remove unused author_ident_sufficiently_given() Junio C Hamano
2026-10-30 18:22   ` Jeff King
2026-11-03 10:23   ` Patrick Steinhardt
2026-11-03 19:00     ` Junio C Hamano
2026-11-04  6:41       ` Patrick Steinhardt
2026-10-30 17:39 ` [PATCH 2/4] add -i: hide init/clear_add_i_state() functions Junio C Hamano
2026-11-03 10:23   ` Patrick Steinhardt
2026-11-03 19:01     ` Junio C Hamano [this message]
2026-10-30 17:39 ` [PATCH 3/4] read-cache: hide refresh_cache_entry() Junio C Hamano
2026-10-30 18:25   ` Jeff King
2026-10-30 17:39 ` [PATCH 4/4] unpack-trees: hide verify_uptodate() Junio C Hamano
2026-10-30 18:26 ` [PATCH 0/4] mark symbols that are unnecessarily public static Jeff King
2026-11-03 10:23   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpkwl7n9i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox