Git development
 help / color / mirror / Atom feed
* [PATCH 0/4] Improve performance of reflog expiration
@ 2026-11-18  9:30 Patrick Steinhardt
  2026-11-18  9:31 ` [PATCH 1/4] refs/reftable: don't write new table on dry-run expire Patrick Steinhardt
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Patrick Steinhardt @ 2026-11-18  9:30 UTC (permalink / raw)
  To: git

Hi,

I recently noticed that a bunch of commands started hanging for almost a
second after they're essentially done already. As it turns out, this was
caused by auto-maintenance, which was blocking in the foreground for
~800ms.

The root cause of this is that the auto-condition of "reflog-expire"
doesn't properly evaluate reachability of reflog entries, so it instead
considered every single reflog entry to point to an unreachable commit.
Hence, all entries were evaluated against "gc.reflogExpireUnreachable"
instead of "gc.reflogExpire", and thus the auto-condition significantly
overcounts the number of entries that we'd prune. So every single run of
git-maintenance(1) ultimately ended up spawning `git reflog expire`.

This is fixed by the last patch in this series. But I was a bit
surprised that a no-op `git reflog expire` took this long, so the first
two patches optimize the reftable backend to be more efficient, too.
In my copy of "git.git":

  Benchmark 1: git maintenance run --auto (commit = master) (10 runs)
                  mean     ±       σ          min     …     max
    Wall Time    853.2 ms  ±    99.9 ms     570.9 ms  …   901.9 ms
    Memory       117.5 MiB ±     0.3 MiB    117.2 MiB …   118.2 MiB

  Benchmark 2: git maintenance run --auto (commit = reftable-optimizations) (10 runs)
                  mean     ±       σ          min     …     max
    Wall Time    392.3 ms  ±     2.3 ms     388.0 ms  …   396.6 ms           -54.0%  (2.2x faster)
    Memory       117.2 MiB ±     0.2 MiB    116.8 MiB …   117.4 MiB           -0.2%

  Benchmark 3: git maintenance run --auto (commit = auto-condition-optimizations) (10 runs)
                  mean     ±       σ          min     …     max
    Wall Time     18.6 ms  ±     1.1 ms      17.4 ms  …    20.9 ms           -97.8%  (45.8x faster)
    Memory        81.2 MiB ±     0.1 MiB     80.9 MiB …    81.4 MiB          -30.9%  (1.4x less)

So yeah, it's a bit more efficient now. :)

Thanks!

Patrick

---
Patrick Steinhardt (4):
      refs/reftable: don't write new table on dry-run expire
      refs/reftable: don't write new table when expire is a no-op
      builtin/maintenance: only consider `gc.reflogExpire` for "--auto"
      Documentation/config: fix typo in "maintenance.reflog-expire.auto"

 Documentation/config/maintenance.adoc |  2 +-
 builtin/gc.c                          | 33 +++++++++++++++++++++------------
 refs/reftable-backend.c               | 21 +++++++++++++++++----
 t/t0610-reftable-basics.sh            | 30 ++++++++++++++++++++++++++++++
 4 files changed, 69 insertions(+), 17 deletions(-)


---
base-commit: e1ec09b23c8e0deb21a0b95ac5996422277395d4
change-id: 20261118-pks-reflog-expire-performance-e051b93f901a


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2026-11-18 16:51 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  9:30 [PATCH 0/4] Improve performance of reflog expiration Patrick Steinhardt
2026-11-18  9:31 ` [PATCH 1/4] refs/reftable: don't write new table on dry-run expire Patrick Steinhardt
2026-11-18 11:28   ` Karthik Nayak
2026-11-18 12:05     ` Patrick Steinhardt
2026-11-18 16:51   ` Junio C Hamano
2026-11-18  9:31 ` [PATCH 2/4] refs/reftable: don't write new table when expire is a no-op Patrick Steinhardt
2026-11-18 11:33   ` Karthik Nayak
2026-11-18 12:05     ` Patrick Steinhardt
2026-11-18 15:34   ` Toon Claes
2026-11-18  9:31 ` [PATCH 3/4] builtin/maintenance: only consider `gc.reflogExpire` for "--auto" Patrick Steinhardt
2026-11-18 15:52   ` Toon Claes
2026-11-18  9:31 ` [PATCH 4/4] Documentation/config: fix typo in "maintenance.reflog-expire.auto" Patrick Steinhardt
2026-11-18 15:54   ` Toon Claes
2026-11-18 15:56 ` [PATCH 0/4] Improve performance of reflog expiration Toon Claes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox