Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ted Nyman <tnyman@openai.com>
Cc: git@vger.kernel.org,  me@ttaylorr.com,  peff@peff.net,
	 ps@pks.im, karthik.188@gmail.com,  sandals@crustytoothpaste.net,
	 avarab@gmail.com
Subject: Re: [PATCH v6 0/6] packfile URIs: support concurrent downloads
Date: Wed, 29 Jul 2026 14:41:51 -0700	[thread overview]
Message-ID: <xmqqcxw5o4m8.fsf@gitster.g> (raw)
In-Reply-To: <cover.1785111375.git.tnyman@openai.com> (Ted Nyman's message of "Sun, 26 Jul 2026 17:28:37 -0700")

Ted Nyman <tnyman@openai.com> writes:

> Changes since v5:
>
> * Split the existing double-close fix, HTTP 416 handling, generic
>   concurrent-download fix, and Windows sharing fix into separate
>   patches.
> * Replace the FIFO-based concurrent HTTP 416 test with a standalone
>   completed-partial test. Besides simplifying the test, this covers the
>   non-concurrent interrupted-download case directly.
> * Keep the final production code unchanged.
>
> Each patch passes t5550-http-fetch-dumb.sh. The final series also passes
> t5702-protocol-v2.sh, and the overlapping-download test passes 240 runs
> with 12 parallel stress jobs.
>
> The v5 discussion is at:
>
> https://lore.kernel.org/git/cover.1785047139.git.tnyman@openai.com/

Is everybody happy with this new iteration?

The design of the re-download feature itself, as far as I
understand, was favourably accepted from the earliest iteration, and
now the CI breakages were corrected with the latest iteration of the
tests, so we should be in pretty good shape, I presume.

Thanks.



      parent reply	other threads:[~2026-07-29 21:41 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 22:37 [PATCH 0/2] packfile URIs: support concurrent downloads Ted Nyman
2026-07-13 22:34 ` [PATCH 1/2] http: use unique tempfiles for packfile URI downloads Ted Nyman
2026-07-14  1:00   ` Junio C Hamano
2026-07-14  1:58     ` Ted Nyman
2026-07-14  4:07       ` Taylor Blau
2026-07-14  5:28       ` Jeff King
2026-07-14 18:10         ` Junio C Hamano
2026-07-14 18:31           ` Ted Nyman
2026-07-14  4:06   ` Taylor Blau
2026-07-14  5:44     ` Jeff King
2026-07-14  6:46   ` Jeff King
2026-07-13 22:34 ` [PATCH 2/2] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-14  7:12   ` Jeff King
2026-07-14  7:13     ` Jeff King
2026-07-14 18:38     ` Ted Nyman
2026-07-14 21:47       ` Jeff King
2026-07-14  4:13 ` [PATCH 0/2] packfile URIs: support concurrent downloads Taylor Blau
2026-07-20 22:33 ` [PATCH v2 " Ted Nyman
2026-07-20 22:33   ` [PATCH v2 1/2] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-21 19:56     ` Junio C Hamano
2026-07-20 22:34   ` [PATCH v2 2/2] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-21 23:29 ` [PATCH v3 0/3] packfile URIs: support concurrent downloads Ted Nyman
2026-07-21 23:29   ` [PATCH v3 1/3] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-21 23:29   ` [PATCH v3 2/3] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-21 23:29   ` [PATCH v3 3/3] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-24  4:43   ` [PATCH v3 0/3] packfile URIs: support concurrent downloads Junio C Hamano
2026-07-25  9:09     ` Jeff King
2026-07-25  9:21       ` Jeff King
2026-07-25 10:02         ` Jeff King
2026-07-25 10:10           ` Jeff King
2026-07-25 16:20           ` Junio C Hamano
2026-07-24  8:14   ` [PATCH v4 " Ted Nyman
2026-07-24  8:14     ` [PATCH v4 1/3] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-24 21:38       ` Taylor Blau
2026-07-24  8:14     ` [PATCH v4 2/3] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-24  8:14     ` [PATCH v4 3/3] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-24 21:46       ` Taylor Blau
2026-07-26  6:44     ` [PATCH v5 0/3] packfile URIs: support concurrent downloads Ted Nyman
2026-07-26  6:44       ` [PATCH v5 1/3] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-26  6:44       ` [PATCH v5 2/3] http: avoid concurrent appends to partial packs Ted Nyman
2026-07-26  9:20         ` Jeff King
2026-07-26 10:04           ` Ted Nyman
2026-07-26 10:27             ` Jeff King
2026-07-26  6:44       ` [PATCH v5 3/3] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-26  9:21       ` [PATCH v5 0/3] packfile URIs: support concurrent downloads Jeff King
2026-07-27  0:28       ` [PATCH v6 0/6] " Ted Nyman
2026-07-27  0:28         ` [PATCH v6 1/6] http-fetch: correct --index-pack-arg documentation Ted Nyman
2026-07-27  0:28         ` [PATCH v6 2/6] http: avoid closing index-pack input twice Ted Nyman
2026-07-27  0:28         ` [PATCH v6 3/6] http: accept HTTP 416 for complete partial packs Ted Nyman
2026-07-27  0:28         ` [PATCH v6 4/6] http: avoid concurrent appends to " Ted Nyman
2026-07-27  0:28         ` [PATCH v6 5/6] http: permit unlinking partial packs on Windows Ted Nyman
2026-07-27  0:28         ` [PATCH v6 6/6] fetch-pack: accept "pack" output for packfile URIs Ted Nyman
2026-07-29 21:41         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcxw5o4m8.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    --cc=tnyman@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox