From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Kristofer Karlsson <krka@spotify.com>,
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Justin Tobler <jltobler@gmail.com>
Subject: Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine
Date: Thu, 05 Nov 2026 11:56:49 -0800 [thread overview]
Message-ID: <xmqqwlqrrr0e.fsf@gitster.g> (raw)
In-Reply-To: <20261105185632.GA2898829@coredump.intra.peff.net> (Jeff King's message of "Thu, 5 Nov 2026 13:56:32 -0500")
Jeff King <peff@peff.net> writes:
> On Wed, Nov 04, 2026 at 11:25:38AM +0100, Kristofer Karlsson wrote:
>
>> No, I think you are right. The quarantine parent only matters when
>> the object directory is not under the commondir, which is rare. Your
>> version is essentially my v1 without the "this is a hack" framing
>> (and also cleaner).
>
> What we really want is "where are we reading our local refs from" (to
> avoid reading them again). So even if you have an object directory not
> under the commondir, we would not find our repo again by looking at the
> parent of that directory.
>
> But I also won't be surprised if there is some arcane working tree setup
> that I'm missing.
With those historic environment variables like GIT_DIR and
GIT_WORK_TREE, and GIT_OBJECT_DIRECTORY, any random arrangement is
possible, I am afraid. I do not know if it is worth worrying about,
though. We've seen people use out-of-tree GIT_DIR by using the
former two environment variables, and I can see why people find it
attractive, but I do not recall people using creative uses of
GIT_OBJECT_DIRECTORY to tear /objects directory out of GIT_DIR, and
what the perceived advantage of doing so are..
> Anyway, what's in your v3 looks good to me. Thanks for fixing this!
Thanks, both. Let me mark the topic as ready for 'next'.
next prev parent reply other threads:[~2026-11-05 19:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 15:18 [PATCH] odb: do not list our own refs as alternate refs in the quarantine Kristofer Karlsson via GitGitGadget
2026-10-29 16:57 ` Justin Tobler
2026-10-30 11:29 ` Kristofer Karlsson
2026-10-29 17:24 ` Junio C Hamano
2026-10-30 11:51 ` Kristofer Karlsson
2026-10-30 16:05 ` Junio C Hamano
2026-10-30 18:17 ` Jeff King
2026-11-02 11:45 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-11-03 0:37 ` Junio C Hamano
2026-11-03 1:12 ` Junio C Hamano
2026-11-03 10:19 ` Kristofer Karlsson
2026-11-03 11:00 ` Patrick Steinhardt
2026-11-03 12:05 ` Kristofer Karlsson
2026-11-03 12:26 ` Patrick Steinhardt
2026-11-03 21:53 ` Justin Tobler
2026-11-04 10:32 ` Kristofer Karlsson
2026-11-04 16:58 ` Justin Tobler
2026-11-04 2:48 ` Jeff King
2026-11-04 10:25 ` Kristofer Karlsson
2026-11-04 18:05 ` Junio C Hamano
2026-11-05 18:56 ` Jeff King
2026-11-05 19:56 ` Junio C Hamano [this message]
2026-11-05 7:43 ` [PATCH v3] odb: do not list our own refs as alternate refs Kristofer Karlsson via GitGitGadget
2026-11-05 19:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwlqrrr0e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jltobler@gmail.com \
--cc=krka@spotify.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox