public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again
@ 2019-06-04  8:46 Petri Latvala
  2019-06-04  8:51 ` Tvrtko Ursulin
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Petri Latvala @ 2019-06-04  8:46 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Tvrtko Ursulin

In commit 32e421f6f74a ("test: perf_pmu: use the gem_engine_topology
library") perf_pmu was converted to use gem_context_has_engine()
instead of gem_require_engine, but missing the crucial part of
igt_require().

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Andi Shyti <andi.shyti@intel.com>
---
 tests/perf_pmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c
index 72b9166a..fdaf96da 100644
--- a/tests/perf_pmu.c
+++ b/tests/perf_pmu.c
@@ -1714,7 +1714,7 @@ igt_main
 
 		igt_subtest_group {
 			igt_fixture {
-				gem_context_has_engine(fd, 0, e->flags);
+				igt_require(gem_context_has_engine(fd, 0, e->flags));
 			}
 
 			/**
@@ -1903,8 +1903,8 @@ igt_main
 		__for_each_physical_engine(render_fd, e) {
 			igt_subtest_group {
 				igt_fixture {
-					gem_context_has_engine(render_fd,
-							   0, e->flags);
+					igt_require(gem_context_has_engine(render_fd,
+									   0, e->flags));
 				}
 
 				igt_subtest_f("render-node-busy-%s", e->name)
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-06-05 12:32 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-04  8:46 [igt-dev] [PATCH i-g-t] perf_pmu: Actually require engines again Petri Latvala
2019-06-04  8:51 ` Tvrtko Ursulin
2019-06-05  9:08   ` Petri Latvala
2019-06-05  9:49     ` Tvrtko Ursulin
2019-06-05 11:27       ` Andi Shyti
2019-06-05 12:03         ` Petri Latvala
2019-06-05 12:32           ` Petri Latvala
2019-06-05 12:06         ` Tvrtko Ursulin
2019-06-04 10:28 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-04 17:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox