* [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list
@ 2018-12-19 17:10 Talha Nassar
2018-12-19 17:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Talha Nassar @ 2018-12-19 17:10 UTC (permalink / raw)
To: igt-dev; +Cc: Mika Kuoppala, intel-gfx
From: talha nassar <talha.nassar@intel.com>
HW team confirmed that this register is write-only.
References: https://bugs.freedesktop.org/show_bug.cgi?id=107338
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: talha nassar <talha.nassar@intel.com>
---
tests/i915/gem_workarounds.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
index 78478ad..b7d7d9c 100644
--- a/tests/i915/gem_workarounds.c
+++ b/tests/i915/gem_workarounds.c
@@ -51,7 +51,8 @@ static struct write_only_list {
unsigned int gen;
uint32_t addr;
} wo_list[] = {
- { 10, 0xE5F0 } /* WaForceContextSaveRestoreNonCoherent:cnl */
+ { 10, 0xE5F0 }, /* WaForceContextSaveRestoreNonCoherent:cnl */
+ { 11, 0xE420 } /* WaEnableFloatBlendOptimization:icl */
/*
* FIXME: If you are contemplating adding stuff here
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_workarounds: adding 0xe420 register to WO list
2018-12-19 17:10 [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list Talha Nassar
@ 2018-12-19 17:57 ` Patchwork
2018-12-19 19:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-20 10:54 ` [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-12-19 17:57 UTC (permalink / raw)
To: Talha Nassar; +Cc: igt-dev
== Series Details ==
Series: i915/gem_workarounds: adding 0xe420 register to WO list
URL : https://patchwork.freedesktop.org/series/54301/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5333 -> IGTPW_2172
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54301/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2172 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#108622]
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* {igt@runner@aborted}:
- fi-apl-guc: NOTRUN -> FAIL [fdo#108622]
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: DMESG-FAIL [fdo#108735] -> PASS
- fi-apl-guc: DMESG-FAIL -> PASS
- fi-kbl-7560u: INCOMPLETE [fdo#108044] -> PASS
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6700hq: DMESG-WARN [fdo#105998] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
#### Warnings ####
* igt@i915_selftest@live_contexts:
- fi-icl-u2: INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
Participating hosts (49 -> 44)
------------------------------
Additional (1): fi-pnv-d510
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4750 -> IGTPW_2172
CI_DRM_5333: c758693b615deff56e5e2098379b587486cfff8a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2172: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2172/
IGT_4750: f05c8c2739dce89185349703062784a7745cab14 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2172/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_workarounds: adding 0xe420 register to WO list
2018-12-19 17:10 [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list Talha Nassar
2018-12-19 17:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-12-19 19:13 ` Patchwork
2018-12-20 10:54 ` [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-12-19 19:13 UTC (permalink / raw)
To: Talha Nassar; +Cc: igt-dev
== Series Details ==
Series: i915/gem_workarounds: adding 0xe420 register to WO list
URL : https://patchwork.freedesktop.org/series/54301/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5333_full -> IGTPW_2172_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2172_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2172_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54301/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2172_full:
### IGT changes ###
#### Warnings ####
* igt@kms_cursor_crc@cursor-128x42-offscreen:
- shard-apl: SKIP -> PASS +92
* igt@perf_pmu@rc6:
- shard-kbl: SKIP -> PASS
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2172_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
- shard-snb: NOTRUN -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-apl: SKIP -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-hang-newfb-render-c:
- shard-glk: PASS -> DMESG-WARN [fdo#107956]
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-apl: SKIP -> DMESG-WARN [fdo#103558] / [fdo#105602] / [fdo#107956]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-b-ctm-blue-to-red:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +6
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-glk: PASS -> FAIL [fdo#103232]
- shard-apl: SKIP -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_legacy@all-pipes-torture-bo:
- shard-kbl: PASS -> DMESG-WARN [fdo#107122]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- shard-apl: SKIP -> DMESG-WARN [fdo#103558] / [fdo#105602]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +4
- shard-apl: SKIP -> FAIL [fdo#103167]
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +1
- shard-glk: PASS -> FAIL [fdo#103166] +1
- shard-kbl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: SKIP -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +1
- shard-kbl: PASS -> FAIL [fdo#108145]
- shard-apl: PASS -> FAIL [fdo#108145]
* igt@pm_rps@reset:
- shard-snb: PASS -> INCOMPLETE [fdo#105411]
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: DMESG-WARN [fdo#103558] -> PASS
* igt@gem_exec_fence@basic-await-default:
- shard-hsw: FAIL [fdo#108888] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: FAIL [fdo#105454] / [fdo#106509] -> PASS
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS +6
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
* igt@perf_pmu@rc6-runtime-pm:
- shard-glk: FAIL [fdo#105010] -> PASS
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108888]: https://bugs.freedesktop.org/show_bug.cgi?id=108888
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4750 -> IGTPW_2172
* Piglit: piglit_4509 -> None
CI_DRM_5333: c758693b615deff56e5e2098379b587486cfff8a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2172: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2172/
IGT_4750: f05c8c2739dce89185349703062784a7745cab14 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2172/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list
2018-12-19 17:10 [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list Talha Nassar
2018-12-19 17:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-19 19:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-12-20 10:54 ` Mika Kuoppala
2018-12-20 11:01 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Mika Kuoppala @ 2018-12-20 10:54 UTC (permalink / raw)
To: Talha Nassar, igt-dev; +Cc: intel-gfx
Talha Nassar <talha.nassar@intel.com> writes:
> From: talha nassar <talha.nassar@intel.com>
>
> HW team confirmed that this register is write-only.
It could be that it is that bit only. We don't need
to care about that now,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=107338
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: talha nassar <talha.nassar@intel.com>
> ---
> tests/i915/gem_workarounds.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
> index 78478ad..b7d7d9c 100644
> --- a/tests/i915/gem_workarounds.c
> +++ b/tests/i915/gem_workarounds.c
> @@ -51,7 +51,8 @@ static struct write_only_list {
> unsigned int gen;
> uint32_t addr;
> } wo_list[] = {
> - { 10, 0xE5F0 } /* WaForceContextSaveRestoreNonCoherent:cnl */
> + { 10, 0xE5F0 }, /* WaForceContextSaveRestoreNonCoherent:cnl */
> + { 11, 0xE420 } /* WaEnableFloatBlendOptimization:icl */
>
> /*
> * FIXME: If you are contemplating adding stuff here
> --
> 2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list
2018-12-20 10:54 ` [igt-dev] [PATCH i-g-t] " Mika Kuoppala
@ 2018-12-20 11:01 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2018-12-20 11:01 UTC (permalink / raw)
To: Mika Kuoppala, Talha Nassar, igt-dev; +Cc: intel-gfx
Quoting Mika Kuoppala (2018-12-20 10:54:33)
> Talha Nassar <talha.nassar@intel.com> writes:
>
> > From: talha nassar <talha.nassar@intel.com>
> >
> > HW team confirmed that this register is write-only.
>
> It could be that it is that bit only. We don't need
> to care about that now,
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Please follow my suggestion to put this information into the w/a itself
so that it also works in selftests/
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-20 11:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 17:10 [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list Talha Nassar
2018-12-19 17:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-19 19:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-20 10:54 ` [igt-dev] [PATCH i-g-t] " Mika Kuoppala
2018-12-20 11:01 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox