public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
@ 2019-01-29 14:08 swati2.sharma
  2019-01-29 15:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Change in commit style (rev4) Patchwork
  2019-02-13 15:15 ` [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style Maarten Lankhorst via igt-dev
  0 siblings, 2 replies; 5+ messages in thread
From: swati2.sharma @ 2019-01-29 14:08 UTC (permalink / raw)
  To: igt-dev

From: Swati Sharma <swati2.sharma@intel.com>

Existing kms_color i-g-t, commit style by default is legacy for
all the ctm/gamma/degamma subtests.

In this patch, provision for both legacy and atomic commit is
provided. Patch is floated as RFC to gather feedback on the idea
and infrastructure proposed.

Other approach could be getting the value of is_atomic as done in
kms_available_modes_crc like
data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY
However with this approach we won't be able to test both the paths.

v1: As per Daniel's comments switching over to atomic.
v2: Rebase

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_color.c | 44 +++++++++++++++++++++++---------------------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..aa000e5 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -61,9 +61,9 @@ typedef struct {
 	uint32_t color_depth;
 	uint64_t degamma_lut_size;
 	uint64_t gamma_lut_size;
+	enum igt_commit_style commit;
 } data_t;
 
-
 static void paint_gradient_rectangles(data_t *data,
 				      drmModeModeInfo *mode,
 				      color_t *colors,
@@ -311,12 +311,12 @@ static void test_pipe_degamma(data_t *data,
 		disable_ctm(primary->pipe);
 		disable_degamma(primary->pipe);
 		set_gamma(data, primary->pipe, gamma_linear);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		/* Draw solid colors with no degamma transformation. */
 		paint_rectangles(data, mode, red_green_blue, &fb);
 		igt_plane_set_fb(primary, &fb);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_fullcolors);
 
@@ -326,7 +326,7 @@ static void test_pipe_degamma(data_t *data,
 		paint_gradient_rectangles(data, mode, red_green_blue, &fb);
 		igt_plane_set_fb(primary, &fb);
 		set_degamma(data, primary->pipe, degamma_full);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_fullgamma);
 
@@ -391,12 +391,12 @@ static void test_pipe_gamma(data_t *data,
 		disable_ctm(primary->pipe);
 		disable_degamma(primary->pipe);
 		set_gamma(data, primary->pipe, gamma_full);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		/* Draw solid colors with no gamma transformation. */
 		paint_rectangles(data, mode, red_green_blue, &fb);
 		igt_plane_set_fb(primary, &fb);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_fullcolors);
 
@@ -405,7 +405,7 @@ static void test_pipe_gamma(data_t *data,
 		 */
 		paint_gradient_rectangles(data, mode, red_green_blue, &fb);
 		igt_plane_set_fb(primary, &fb);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_fullgamma);
 
@@ -477,12 +477,12 @@ static void test_pipe_legacy_gamma(data_t *data,
 		disable_degamma(primary->pipe);
 		disable_gamma(primary->pipe);
 		disable_ctm(primary->pipe);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		/* Draw solid colors with no gamma transformation. */
 		paint_rectangles(data, mode, red_green_blue, &fb);
 		igt_plane_set_fb(primary, &fb);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_fullcolors);
 
@@ -497,7 +497,7 @@ static void test_pipe_legacy_gamma(data_t *data,
 			red_lut[i] = green_lut[i] = blue_lut[i] = 0xffff;
 		igt_assert_eq(drmModeCrtcSetGamma(data->drm_fd, primary->pipe->crtc_id,
 						  legacy_lut_size, red_lut, green_lut, blue_lut), 0);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_fullgamma);
 
@@ -512,7 +512,7 @@ static void test_pipe_legacy_gamma(data_t *data,
 
 		igt_assert_eq(drmModeCrtcSetGamma(data->drm_fd, primary->pipe->crtc_id,
 						  legacy_lut_size, red_lut, green_lut, blue_lut), 0);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		igt_plane_set_fb(primary, NULL);
 		igt_output_set_pipe(output, PIPE_NONE);
@@ -566,7 +566,7 @@ static void test_pipe_legacy_gamma_reset(data_t *data,
 		disable_degamma(primary->pipe);
 		disable_ctm(primary->pipe);
 		disable_gamma(primary->pipe);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		/* Set a degama & gamma LUT and a CTM using the
 		 * properties and verify the content of the
@@ -574,7 +574,7 @@ static void test_pipe_legacy_gamma_reset(data_t *data,
 		set_degamma(data, primary->pipe, degamma_linear);
 		set_ctm(primary->pipe, ctm_identity);
 		set_gamma(data, primary->pipe, gamma_zero);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		blob = get_blob(data, primary->pipe, IGT_CRTC_DEGAMMA_LUT);
 		igt_assert(blob &&
@@ -617,7 +617,7 @@ static void test_pipe_legacy_gamma_reset(data_t *data,
 						  legacy_lut_size,
 						  red_lut, green_lut, blue_lut),
 			      0);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		igt_assert(get_blob(data, primary->pipe,
 				    IGT_CRTC_DEGAMMA_LUT) == NULL);
@@ -699,12 +699,12 @@ static bool test_pipe_ctm(data_t *data,
 		set_degamma(data, primary->pipe, degamma_linear);
 		set_gamma(data, primary->pipe, gamma_linear);
 		disable_ctm(primary->pipe);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		paint_rectangles(data, mode, after, &fb);
 		igt_plane_set_fb(primary, &fb);
 		set_ctm(primary->pipe, ctm_identity);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_software);
 
@@ -712,7 +712,7 @@ static bool test_pipe_ctm(data_t *data,
 		paint_rectangles(data, mode, before, &fb);
 		igt_plane_set_fb(primary, &fb);
 		set_ctm(primary->pipe, ctm_matrix);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_hardware);
 
@@ -807,7 +807,7 @@ static void test_pipe_limited_range_ctm(data_t *data,
 		igt_output_set_prop_value(output, IGT_CONNECTOR_BROADCAST_RGB, BROADCAST_RGB_FULL);
 		paint_rectangles(data, mode, red_green_blue_limited, &fb);
 		igt_plane_set_fb(primary, &fb);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_full);
 
@@ -815,7 +815,7 @@ static void test_pipe_limited_range_ctm(data_t *data,
 		igt_output_set_prop_value(output, IGT_CONNECTOR_BROADCAST_RGB, BROADCAST_RGB_16_235);
 		paint_rectangles(data, mode, red_green_blue_full, &fb);
 		igt_plane_set_fb(primary, &fb);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 		igt_wait_for_vblank(data->drm_fd, primary->pipe->pipe);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &crc_limited);
 
@@ -1043,7 +1043,7 @@ run_tests_for_pipe(data_t *data, enum pipe p)
 		disable_degamma(primary->pipe);
 		disable_gamma(primary->pipe);
 		disable_ctm(primary->pipe);
-		igt_display_commit(&data->display);
+		igt_display_commit2(&data->display, data->commit);
 
 		igt_pipe_crc_free(data->pipe_crc);
 		data->pipe_crc = NULL;
@@ -1085,7 +1085,7 @@ invalid_lut_sizes(data_t *data)
 	struct _drm_color_lut *degamma_lut = malloc(data->degamma_lut_size * sizeof(struct _drm_color_lut) * 2);
 	struct _drm_color_lut *gamma_lut = malloc(data->gamma_lut_size * sizeof(struct _drm_color_lut) * 2);
 
-	igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+	igt_display_commit2(display, data->commit);
 
 	if (igt_pipe_obj_has_prop(pipe, IGT_CRTC_DEGAMMA_LUT)) {
 		igt_assert_eq(pipe_set_property_blob(pipe, IGT_CRTC_DEGAMMA_LUT,
@@ -1174,6 +1174,8 @@ igt_main
 
 		igt_display_require(&data.display, data.drm_fd);
 	}
+	
+	data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY;
 
 	for_each_pipe_static(pipe)
 		igt_subtest_group
-- 
1.9.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Change in commit style (rev4)
  2019-01-29 14:08 [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style swati2.sharma
@ 2019-01-29 15:05 ` Patchwork
  2019-02-13 15:15 ` [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style Maarten Lankhorst via igt-dev
  1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-01-29 15:05 UTC (permalink / raw)
  To: swati2.sharma; +Cc: igt-dev

== Series Details ==

Series: tests/kms_color: Change in commit style (rev4)
URL   : https://patchwork.freedesktop.org/series/50539/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5500 -> IGTPW_2315
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2315 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2315, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50539/revisions/4/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2315:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-kbl-7567u:       PASS -> FAIL +2

  
Known issues
------------

  Here are the changes found in IGTPW_2315 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@read_all_entries:
    - fi-kbl-7567u:       PASS -> DMESG-WARN [fdo#103558] / [fdo#105602]

  * igt@gem_basic@create-fd-close:
    - fi-kbl-7560u:       PASS -> INCOMPLETE [fdo#103665]

  * igt@gem_exec_suspend@basic-s3:
    - fi-kbl-7567u:       PASS -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602]

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-kbl-7567u:       PASS -> DMESG-WARN [fdo#105602] / [fdo#108529] +1

  * igt@i915_selftest@live_hangcheck:
    - fi-skl-6260u:       PASS -> INCOMPLETE [fdo#108744]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]

  * igt@kms_pipe_crc_basic@read-crc-pipe-a:
    - fi-byt-clapper:     PASS -> FAIL [fdo#107362]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-kbl-7567u:       PASS -> DMESG-FAIL [fdo#105079]

  * igt@pm_rpm@module-reload:
    - fi-kbl-7567u:       PASS -> DMESG-WARN [fdo#108529]

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] -> PASS

  * igt@prime_vgem@basic-fence-flip:
    - fi-gdg-551:         FAIL [fdo#103182] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108529]: https://bugs.freedesktop.org/show_bug.cgi?id=108529
  [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
  [fdo#108866]: https://bugs.freedesktop.org/show_bug.cgi?id=108866
  [fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (46 -> 40)
------------------------------

  Additional (1): fi-icl-y 
  Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-glk-j4005 


Build changes
-------------

    * IGT: IGT_4798 -> IGTPW_2315

  CI_DRM_5500: a76602bc7e9c1661ac1328103ef67dbc342a7655 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2315: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2315/
  IGT_4798: 998e0a4aedf10fb5f7c271018cd80d874668bf55 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2315/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
  2019-01-29 14:08 [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style swati2.sharma
  2019-01-29 15:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Change in commit style (rev4) Patchwork
@ 2019-02-13 15:15 ` Maarten Lankhorst via igt-dev
  2019-02-28 14:07   ` Sharma, Swati2
  1 sibling, 1 reply; 5+ messages in thread
From: Maarten Lankhorst via igt-dev @ 2019-02-13 15:15 UTC (permalink / raw)
  To: swati2.sharma, igt-dev

Hey,

Op 29-01-2019 om 15:08 schreef swati2.sharma@intel.com:
> From: Swati Sharma <swati2.sharma@intel.com>
>
> Existing kms_color i-g-t, commit style by default is legacy for
> all the ctm/gamma/degamma subtests.
>
> In this patch, provision for both legacy and atomic commit is
> provided. Patch is floated as RFC to gather feedback on the idea
> and infrastructure proposed.
>
> Other approach could be getting the value of is_atomic as done in
> kms_available_modes_crc like
> data.commit = data.display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY
> However with this approach we won't be able to test both the paths.
>
> v1: As per Daniel's comments switching over to atomic.
> v2: Rebase
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>


Just do COMMIT_ATOMIC, and add igt_require(display.is_atomic), drivers should support it for this test. :)

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
  2019-02-13 15:15 ` [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style Maarten Lankhorst via igt-dev
@ 2019-02-28 14:07   ` Sharma, Swati2
  2019-02-28 16:09     ` Maarten Lankhorst
  0 siblings, 1 reply; 5+ messages in thread
From: Sharma, Swati2 @ 2019-02-28 14:07 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: igt-dev@lists.freedesktop.org

Hi Maarten,

Thank you for the review :) When I made changes as you said, tests are getting skipped because of test reqt data.display.is_atomic not getting met.

./build/tests/kms_color --run-subtest pipe-A-ctm-red-to-blue
IGT-Version: 1.23-g3f2aaed (x86_64) (Linux: 5.0.0-rc8+ x86_64)
Test requirement not met in function __real_main1161, file ../tests/kms_color.c:1174:
Test requirement: data.display.is_atomic
Subtest pipe-A-ctm-red-to-blue: SKIP

Thanks and Regards,
Swati

-----Original Message-----
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> 
Sent: Wednesday, February 13, 2019 8:45 PM
To: Sharma, Swati2 <swati2.sharma@intel.com>; igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style

Hey,

Op 29-01-2019 om 15:08 schreef swati2.sharma@intel.com:
> From: Swati Sharma <swati2.sharma@intel.com>
>
> Existing kms_color i-g-t, commit style by default is legacy for all 
> the ctm/gamma/degamma subtests.
>
> In this patch, provision for both legacy and atomic commit is 
> provided. Patch is floated as RFC to gather feedback on the idea and 
> infrastructure proposed.
>
> Other approach could be getting the value of is_atomic as done in 
> kms_available_modes_crc like data.commit = data.display.is_atomic ? 
> COMMIT_ATOMIC : COMMIT_LEGACY However with this approach we won't be 
> able to test both the paths.
>
> v1: As per Daniel's comments switching over to atomic.
> v2: Rebase
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>


Just do COMMIT_ATOMIC, and add igt_require(display.is_atomic), drivers should support it for this test. :)

~Maarten

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
  2019-02-28 14:07   ` Sharma, Swati2
@ 2019-02-28 16:09     ` Maarten Lankhorst
  0 siblings, 0 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2019-02-28 16:09 UTC (permalink / raw)
  To: Sharma, Swati2; +Cc: igt-dev@lists.freedesktop.org

Op 28-02-2019 om 15:07 schreef Sharma, Swati2:
> Hi Maarten,
>
> Thank you for the review :) When I made changes as you said, tests are getting skipped because of test reqt data.display.is_atomic not getting met.
>
> ./build/tests/kms_color --run-subtest pipe-A-ctm-red-to-blue
> IGT-Version: 1.23-g3f2aaed (x86_64) (Linux: 5.0.0-rc8+ x86_64)
> Test requirement not met in function __real_main1161, file ../tests/kms_color.c:1174:
> Test requirement: data.display.is_atomic
> Subtest pipe-A-ctm-red-to-blue: SKIP

What system?


If it's pre gen5, probably no big issue.

> Thanks and Regards,
> Swati
>
> -----Original Message-----
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> 
> Sent: Wednesday, February 13, 2019 8:45 PM
> To: Sharma, Swati2 <swati2.sharma@intel.com>; igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style
>
> Hey,
>
> Op 29-01-2019 om 15:08 schreef swati2.sharma@intel.com:
>> From: Swati Sharma <swati2.sharma@intel.com>
>>
>> Existing kms_color i-g-t, commit style by default is legacy for all 
>> the ctm/gamma/degamma subtests.
>>
>> In this patch, provision for both legacy and atomic commit is 
>> provided. Patch is floated as RFC to gather feedback on the idea and 
>> infrastructure proposed.
>>
>> Other approach could be getting the value of is_atomic as done in 
>> kms_available_modes_crc like data.commit = data.display.is_atomic ? 
>> COMMIT_ATOMIC : COMMIT_LEGACY However with this approach we won't be 
>> able to test both the paths.
>>
>> v1: As per Daniel's comments switching over to atomic.
>> v2: Rebase
>>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>
> Just do COMMIT_ATOMIC, and add igt_require(display.is_atomic), drivers should support it for this test. :)
>
> ~Maarten
>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-28 16:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 14:08 [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style swati2.sharma
2019-01-29 15:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_color: Change in commit style (rev4) Patchwork
2019-02-13 15:15 ` [igt-dev] [i-g-t,v2] tests/kms_color: Change in commit style Maarten Lankhorst via igt-dev
2019-02-28 14:07   ` Sharma, Swati2
2019-02-28 16:09     ` Maarten Lankhorst

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox