public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
@ 2018-12-13  9:52 Maarten Lankhorst
  2018-12-13 10:00 ` Daniel Vetter
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2018-12-13  9:52 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

Typically PSR enables in around 136 ms, but on some tests the we have
to explicitly make sure that the gpu is idle before rendering.

Otherwise, sometimes we wait for the background flusher to finish,
which will take at least a second longer, and causes the wait for
PSR to timeout.

On kms_frontbuffer_tracking:
Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 350ms
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 1598ms

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_frontbuffer_tracking.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 276ef83ce386..7924bb902a2a 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1642,6 +1642,9 @@ static void __do_assertions(const struct test_mode *t, int flags,
 {
 	flags = adjust_assertion_flags(t, flags);
 
+	/* Make sure any submitted rendering is now idle. */
+	gem_quiescent_gpu(drm.fd);
+
 	igt_debug("checking asserts in line %i\n", line);
 
 	wait_user(2, "Paused before assertions.");
-- 
2.19.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-12-14  9:31 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-13  9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
2018-12-13 10:00 ` Daniel Vetter
2018-12-13 10:05   ` Chris Wilson
2018-12-14  0:18   ` Dhinakaran Pandiyan
2018-12-14  0:22     ` Dhinakaran Pandiyan
2018-12-14  9:31       ` Maarten Lankhorst
2018-12-13 10:20 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-13 11:44 ` Patchwork
2018-12-13 11:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-12-13 12:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-13 12:49   ` Chris Wilson
2018-12-13 13:39     ` Maarten Lankhorst

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox