[igt-dev] [PATCH i-g-t v5 0/5] DC states igt tests patch series

[igt-dev] [PATCH i-g-t v5 0/5] DC states igt tests patch series

[Anshuman Gupta via igt-dev]

Thiss patch series adds new tests to validate Display C states.
DC states like DC5 and DC6 are validated during PSR entry/exit and 
during DPMS on/off cycle.
Sending new revision of patch series after addressing review comments.


Jyoti Yadav (5):
  lib/igt_pm: Moves Dmc_loaded() function into library
  tests/pm_dc: Added new test to verify Display C States
  tests/pm_dc: Added test for DC6 during PSR
  tests/pm_dc: Added test for DC5 during DPMS
  tests/pm_dc: Added test for DC6 during DPMS

 lib/igt_pm.c           |  28 ++++++
 lib/igt_pm.h           |   1 +
 tests/Makefile.sources |   1 +
 tests/meson.build      |   1 +
 tests/pm_dc.c          | 249 +++++++++++++++++++++++++++++++++++++++++++++++++
 tests/pm_rpm.c         |  17 +---
 6 files changed, 281 insertions(+), 16 deletions(-)
 create mode 100644 tests/pm_dc.c

-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v5 1/5] lib/igt_pm: Moves Dmc_loaded() function into library

[Anshuman Gupta via igt-dev]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

It will be used by new test pm_dc.c which will validate Display C States.
So moving the same to igt_pm library.

v2: Simplify the comment section.
v3: Remove . from the subject line.
v4: Rebased, resolve conflicts in pm_rpm.c
    Included patch set version change log.
v5: Listing actual change in patch set changelog to make review easier.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 lib/igt_pm.c   | 28 ++++++++++++++++++++++++++++
 lib/igt_pm.h   |  1 +
 tests/pm_rpm.c | 17 +----------------
 3 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 4902723..8b87c58 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -38,6 +38,7 @@
 #include "drmtest.h"
 #include "igt_pm.h"
 #include "igt_aux.h"
+#include "igt_sysfs.h"
 
 /**
  * SECTION:igt_pm
@@ -620,3 +621,30 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
 {
 	return igt_wait(igt_get_runtime_pm_status() == status, 10000, 100);
 }
+
+/**
+ * dmc_loaded:
+ * @debugfs: fd to the debugfs dir.
+
+ * Check whether DMC FW is loaded or not. DMC FW is require for few Display C
+ * states like DC5 and DC6. FW does the Context Save and Restore during Display
+ * C States entry and exit.
+ *
+ * Returns:
+ * True if DMC FW is loaded otherwise false.
+ */
+bool igt_pm_dmc_loaded(int debugfs)
+{
+	igt_require(debugfs != -1);
+	char buf[15];
+	int len;
+
+	len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
+	if (len < 0)
+		return true; /* no CSR support, no DMC requirement */
+
+	buf[len] = '\0';
+
+	igt_info("DMC: %s\n", buf);
+	return strstr(buf, "fw loaded: yes");
+}
diff --git a/lib/igt_pm.h b/lib/igt_pm.h
index 10cc679..70d2380 100644
--- a/lib/igt_pm.h
+++ b/lib/igt_pm.h
@@ -50,5 +50,6 @@ bool igt_setup_runtime_pm(void);
 void igt_restore_runtime_pm(void);
 enum igt_runtime_pm_status igt_get_runtime_pm_status(void);
 bool igt_wait_for_pm_status(enum igt_runtime_pm_status status);
+bool igt_pm_dmc_loaded(int debugfs);
 
 #endif /* IGT_PM_H */
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index be296f5..2d7cb5e 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -710,21 +710,6 @@ static void setup_pc8(void)
 	has_pc8 = true;
 }
 
-static bool dmc_loaded(void)
-{
-	char buf[15];
-	int len;
-
-	len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
-	if (len < 0)
-	    return true; /* no CSR support, no DMC requirement */
-
-	buf[len] = '\0';
-
-	igt_info("DMC: %s\n", buf);
-	return strstr(buf, "fw loaded: yes");
-}
-
 static void dump_file(int dir, const char *filename)
 {
 	char *contents;
@@ -761,7 +746,7 @@ static bool setup_environment(void)
 	igt_info("Runtime PM support: %d\n", has_runtime_pm);
 	igt_info("PC8 residency support: %d\n", has_pc8);
 	igt_require(has_runtime_pm);
-	igt_require(dmc_loaded());
+	igt_require(igt_pm_dmc_loaded(debugfs));
 
 out:
 	disable_all_screens(&ms_data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v5 2/5] tests/pm_dc: Added new test to verify Display C States

[Anshuman Gupta via igt-dev]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Currently this test validates DC5 upon PSR entry for supported platforms.
Added new file for compilation inside Makefile and Meson.

v2: Used the debugfs entry for DC counters instead of Registers.
    Used shorter names for variables.
    Introduced timeout to read DC counters.
v3: one second timeout is introduced to read DC counters.
    Skip the subtest if counters are not available for that platform.
v4: Rebased, to fix compilation error in psr_enable(), psr_wait_entry()
    and replaced igt_display_init() by igt_display_require() in pm_rpm.c.
    Addressed the review comment by removing unused function display_init,
    removing redundant igt commit suggested by Imre.
    Fixed typo in read_dc_counter().
v5: Addressed the review comment by removing redundant read_dc_counter(),
    clubbed cleanup() function in test_dc_state_psr() suggested by Imre.
    Rearranged  preprocessor directives at one place.
    Fixed compilation warning by adding function prototype for
    dc_state_wait_entry() and check_dc_counter().
    Listing actual change in patch set changelog to make review easier.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/Makefile.sources |   1 +
 tests/meson.build      |   1 +
 tests/pm_dc.c          | 209 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 211 insertions(+)
 create mode 100644 tests/pm_dc.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 34b7e44..07b9787 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -80,6 +80,7 @@ TESTS_progs = \
 	pm_lpsp \
 	pm_rc6_residency \
 	pm_rpm \
+	pm_dc \
 	pm_rps \
 	pm_sseu \
 	prime_busy \
diff --git a/tests/meson.build b/tests/meson.build
index 25b4614..3070a3e 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -66,6 +66,7 @@ test_progs = [
 	'pm_lpsp',
 	'pm_rc6_residency',
 	'pm_rpm',
+	'pm_dc',
 	'pm_rps',
 	'pm_sseu',
 	'prime_busy',
diff --git a/tests/pm_dc.c b/tests/pm_dc.c
new file mode 100644
index 0000000..56b0428
--- /dev/null
+++ b/tests/pm_dc.c
@@ -0,0 +1,209 @@
+/*
+ * Copyright © 2018 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "igt.h"
+#include "igt_sysfs.h"
+#include "igt_psr.h"
+#include <errno.h>
+#include <stdbool.h>
+#include <stdio.h>
+#include <string.h>
+#include "intel_bufmgr.h"
+#include "intel_io.h"
+#include "limits.h"
+
+/* DC State Flags */
+#define CHECK_DC5	1
+#define CHECK_DC6	2
+
+typedef struct {
+	int drm_fd;
+	int debugfs_fd;
+	uint32_t devid;
+	igt_display_t display;
+	struct igt_fb fb_white;
+	enum psr_mode op_psr_mode;
+	drmModeModeInfo *mode;
+	igt_output_t *output;
+} data_t;
+
+bool dc_state_wait_entry(int, int, int);
+void check_dc_counter(int, int, uint32_t);
+
+static void setup_output(data_t *data)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {
+		drmModeConnectorPtr c = output->config.connector;
+
+		if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
+			continue;
+
+		igt_output_set_pipe(output, pipe);
+		data->output = output;
+		data->mode = igt_output_get_mode(output);
+
+		return;
+	}
+}
+
+static void display_fini(data_t *data)
+{
+	igt_display_fini(&data->display);
+}
+
+static bool edp_psr_sink_support(data_t *data)
+{
+	char buf[512];
+
+	igt_debugfs_simple_read(data->debugfs_fd, "i915_edp_psr_status",
+			 buf, sizeof(buf));
+
+	return strstr(buf, "Sink_Support: yes\n");
+}
+
+static void cleanup(data_t *data)
+{
+	igt_plane_t *primary;
+
+	primary = igt_output_get_plane_type(data->output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_display_commit(&data->display);
+	igt_remove_fb(data->drm_fd, &data->fb_white);
+}
+
+static void setup_primary(data_t *data)
+{
+	igt_plane_t *primary;
+
+	primary = igt_output_get_plane_type(data->output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_create_color_fb(data->drm_fd,
+			    data->mode->hdisplay, data->mode->vdisplay,
+			    DRM_FORMAT_XRGB8888,
+			    LOCAL_I915_FORMAT_MOD_X_TILED,
+			    1.0, 1.0, 1.0,
+			    &data->fb_white);
+	igt_plane_set_fb(primary, &data->fb_white);
+	igt_display_commit(&data->display);
+}
+
+static uint32_t get_dc_counter(char *dc_data)
+{
+	char *e;
+	long ret;
+	char *s = strchr(dc_data, ':');
+
+	assert(s);
+	s++;
+	ret = strtol(s, &e, 10);
+	assert(((ret != LONG_MIN && ret != LONG_MAX) || errno != ERANGE) &&
+	       e > s && *e == '\n' && ret >= 0);
+	return ret;
+}
+
+static uint32_t read_dc_counter(uint32_t drm_fd, int dc_flag)
+{
+	char buf[4096];
+	char *str;
+
+	igt_debugfs_read(drm_fd, "i915_dmc_info", buf);
+
+	if (dc_flag & CHECK_DC5)
+		str = strstr(buf, "DC3 -> DC5 count");
+
+	else if (dc_flag & CHECK_DC6)
+		str = strstr(buf, "DC5 -> DC6 count");
+
+	/* Check DC5/DC6 counter is available for the platform.
+	 * Skip the test if counter is not available.
+	 */
+	igt_skip_on_f(str == NULL, "DC%d counter is not available\n",
+		      dc_flag & CHECK_DC5 ? 5 : 6);
+	return get_dc_counter(str);
+}
+
+bool dc_state_wait_entry(int drm_fd, int dc_flag, int prev_dc_count)
+{
+	return igt_wait(read_dc_counter(drm_fd, dc_flag) > prev_dc_count, 1000, 100);
+}
+
+void check_dc_counter(int drm_fd, int dc_flag, uint32_t prev_dc_count)
+{
+	igt_assert_f(dc_state_wait_entry(drm_fd, dc_flag, prev_dc_count),
+		     "DC%d state is not achieved\n",
+		     dc_flag & CHECK_DC5 ? 5 : 6);
+}
+
+static void test_dc_state_psr(data_t *data, int dc_flag)
+{
+	uint32_t dc_counter_before_psr;
+
+	dc_counter_before_psr = read_dc_counter(data->drm_fd, dc_flag);
+	setup_output(data);
+	setup_primary(data);
+	igt_assert(psr_wait_entry(data->debugfs_fd, data->op_psr_mode));
+	check_dc_counter(data->drm_fd, dc_flag, dc_counter_before_psr);
+	cleanup(&data);
+}
+
+int main(int argc, char *argv[])
+{
+	bool has_runtime_pm;
+	data_t data = {};
+
+	igt_skip_on_simulation();
+	igt_subtest_init(argc, argv);
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
+		igt_require(data.debugfs_fd != -1);
+		kmstest_set_vt_graphics_mode();
+		data.devid = intel_get_drm_devid(data.drm_fd);
+		has_runtime_pm = igt_setup_runtime_pm();
+		igt_info("Runtime PM support: %d\n", has_runtime_pm);
+		igt_require(has_runtime_pm);
+		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
+		igt_display_require(&data.display, data.drm_fd);
+	}
+
+	igt_subtest("dc5-psr") {
+		data.op_psr_mode = PSR_MODE_1;
+		psr_enable(data.debugfs_fd, data.op_psr_mode);
+		igt_require_f(edp_psr_sink_support(&data),
+			      "Sink does not support PSR\n");
+		test_dc_state_psr(&data, CHECK_DC5);
+	}
+	igt_fixture {
+		close(data.debugfs_fd);
+		display_fini(&data);
+	}
+
+	igt_exit();
+}
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v6 2/5] tests/pm_dc: Added new test to verify Display C States

[Anshuman Gupta]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Currently this test validates DC5 upon PSR entry for supported platforms.
Added new file for compilation inside Makefile and Meson.

v2: Used the debugfs entry for DC counters instead of Registers.
    Used shorter names for variables.
    Introduced timeout to read DC counters.
v3: one second timeout is introduced to read DC counters.
    Skip the subtest if counters are not available for that platform.
v4: Rebased, to fix compilation error in psr_enable(), psr_wait_entry()
    and replaced igt_display_init() by igt_display_require() in pm_rpm.c.
    Addressed the review comment by removing unused function display_init,
    removing redundant igt commit suggested by Imre.
    Fixed typo in read_dc_counter().
v5: Addressed the review comment by removing redundant read_dc_counter(),
    clubbed cleanup() function in test_dc_state_psr() suggested by Imre.
    Rearranged  preprocessor directives at one place.
    Fixed compilation warning by adding function prototype for
    dc_state_wait_entry() and check_dc_counter().
    Listing actual change in patch set changelog to make review easier.
v6: Fixed "i915_edp_psr_status" string to "Sink support: yes".

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/Makefile.sources |   1 +
 tests/meson.build      |   1 +
 tests/pm_dc.c          | 209 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 211 insertions(+)
 create mode 100644 tests/pm_dc.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 34b7e44..07b9787 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -80,6 +80,7 @@ TESTS_progs = \
 	pm_lpsp \
 	pm_rc6_residency \
 	pm_rpm \
+	pm_dc \
 	pm_rps \
 	pm_sseu \
 	prime_busy \
diff --git a/tests/meson.build b/tests/meson.build
index 25b4614..3070a3e 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -66,6 +66,7 @@ test_progs = [
 	'pm_lpsp',
 	'pm_rc6_residency',
 	'pm_rpm',
+	'pm_dc',
 	'pm_rps',
 	'pm_sseu',
 	'prime_busy',
diff --git a/tests/pm_dc.c b/tests/pm_dc.c
new file mode 100644
index 0000000..7e16721
--- /dev/null
+++ b/tests/pm_dc.c
@@ -0,0 +1,209 @@
+/*
+ * Copyright © 2018 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include "igt.h"
+#include "igt_sysfs.h"
+#include "igt_psr.h"
+#include <errno.h>
+#include <stdbool.h>
+#include <stdio.h>
+#include <string.h>
+#include "intel_bufmgr.h"
+#include "intel_io.h"
+#include "limits.h"
+
+/* DC State Flags */
+#define CHECK_DC5	1
+#define CHECK_DC6	2
+
+typedef struct {
+	int drm_fd;
+	int debugfs_fd;
+	uint32_t devid;
+	igt_display_t display;
+	struct igt_fb fb_white;
+	enum psr_mode op_psr_mode;
+	drmModeModeInfo *mode;
+	igt_output_t *output;
+} data_t;
+
+bool dc_state_wait_entry(int, int, int);
+void check_dc_counter(int, int, uint32_t);
+
+static void setup_output(data_t *data)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {
+		drmModeConnectorPtr c = output->config.connector;
+
+		if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
+			continue;
+
+		igt_output_set_pipe(output, pipe);
+		data->output = output;
+		data->mode = igt_output_get_mode(output);
+
+		return;
+	}
+}
+
+static void display_fini(data_t *data)
+{
+	igt_display_fini(&data->display);
+}
+
+static bool edp_psr_sink_support(data_t *data)
+{
+	char buf[512];
+
+	igt_debugfs_simple_read(data->debugfs_fd, "i915_edp_psr_status",
+			 buf, sizeof(buf));
+
+	return strstr(buf, "Sink support: yes");
+}
+
+static void cleanup(data_t *data)
+{
+	igt_plane_t *primary;
+
+	primary = igt_output_get_plane_type(data->output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_display_commit(&data->display);
+	igt_remove_fb(data->drm_fd, &data->fb_white);
+}
+
+static void setup_primary(data_t *data)
+{
+	igt_plane_t *primary;
+
+	primary = igt_output_get_plane_type(data->output,
+					    DRM_PLANE_TYPE_PRIMARY);
+	igt_plane_set_fb(primary, NULL);
+	igt_create_color_fb(data->drm_fd,
+			    data->mode->hdisplay, data->mode->vdisplay,
+			    DRM_FORMAT_XRGB8888,
+			    LOCAL_I915_FORMAT_MOD_X_TILED,
+			    1.0, 1.0, 1.0,
+			    &data->fb_white);
+	igt_plane_set_fb(primary, &data->fb_white);
+	igt_display_commit(&data->display);
+}
+
+static uint32_t get_dc_counter(char *dc_data)
+{
+	char *e;
+	long ret;
+	char *s = strchr(dc_data, ':');
+
+	assert(s);
+	s++;
+	ret = strtol(s, &e, 10);
+	assert(((ret != LONG_MIN && ret != LONG_MAX) || errno != ERANGE) &&
+	       e > s && *e == '\n' && ret >= 0);
+	return ret;
+}
+
+static uint32_t read_dc_counter(uint32_t drm_fd, int dc_flag)
+{
+	char buf[4096];
+	char *str;
+
+	igt_debugfs_read(drm_fd, "i915_dmc_info", buf);
+
+	if (dc_flag & CHECK_DC5)
+		str = strstr(buf, "DC3 -> DC5 count");
+
+	else if (dc_flag & CHECK_DC6)
+		str = strstr(buf, "DC5 -> DC6 count");
+
+	/* Check DC5/DC6 counter is available for the platform.
+	 * Skip the test if counter is not available.
+	 */
+	igt_skip_on_f(str == NULL, "DC%d counter is not available\n",
+		      dc_flag & CHECK_DC5 ? 5 : 6);
+	return get_dc_counter(str);
+}
+
+bool dc_state_wait_entry(int drm_fd, int dc_flag, int prev_dc_count)
+{
+	return igt_wait(read_dc_counter(drm_fd, dc_flag) > prev_dc_count, 1000, 100);
+}
+
+void check_dc_counter(int drm_fd, int dc_flag, uint32_t prev_dc_count)
+{
+	igt_assert_f(dc_state_wait_entry(drm_fd, dc_flag, prev_dc_count),
+		     "DC%d state is not achieved\n",
+		     dc_flag & CHECK_DC5 ? 5 : 6);
+}
+
+static void test_dc_state_psr(data_t *data, int dc_flag)
+{
+	uint32_t dc_counter_before_psr;
+
+	dc_counter_before_psr = read_dc_counter(data->drm_fd, dc_flag);
+	setup_output(data);
+	setup_primary(data);
+	igt_assert(psr_wait_entry(data->debugfs_fd, data->op_psr_mode));
+	check_dc_counter(data->drm_fd, dc_flag, dc_counter_before_psr);
+	cleanup(data);
+}
+
+int main(int argc, char *argv[])
+{
+	bool has_runtime_pm;
+	data_t data = {};
+
+	igt_skip_on_simulation();
+	igt_subtest_init(argc, argv);
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
+		igt_require(data.debugfs_fd != -1);
+		kmstest_set_vt_graphics_mode();
+		data.devid = intel_get_drm_devid(data.drm_fd);
+		has_runtime_pm = igt_setup_runtime_pm();
+		igt_info("Runtime PM support: %d\n", has_runtime_pm);
+		igt_require(has_runtime_pm);
+		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
+		igt_display_require(&data.display, data.drm_fd);
+	}
+
+	igt_subtest("dc5-psr") {
+		data.op_psr_mode = PSR_MODE_1;
+		psr_enable(data.debugfs_fd, data.op_psr_mode);
+		igt_require_f(edp_psr_sink_support(&data),
+			      "Sink does not support PSR\n");
+		test_dc_state_psr(&data, CHECK_DC5);
+	}
+	igt_fixture {
+		close(data.debugfs_fd);
+		display_fini(&data);
+	}
+
+	igt_exit();
+}
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v6 2/5] tests/pm_dc: Added new test to verify Display C States

[Dhinakaran Pandiyan]

On Wed, 2019-02-20 at 22:22 +0530, Anshuman Gupta wrote:
> From: Jyoti Yadav <jyoti.r.yadav@intel.com>
> 
> Currently this test validates DC5 upon PSR entry for supported
> platforms.
> Added new file for compilation inside Makefile and Meson.
> 
> v2: Used the debugfs entry for DC counters instead of Registers.
>     Used shorter names for variables.
>     Introduced timeout to read DC counters.
> v3: one second timeout is introduced to read DC counters.
>     Skip the subtest if counters are not available for that platform.
> v4: Rebased, to fix compilation error in psr_enable(),
> psr_wait_entry()
>     and replaced igt_display_init() by igt_display_require() in
> pm_rpm.c.
>     Addressed the review comment by removing unused function
> display_init,
>     removing redundant igt commit suggested by Imre.
>     Fixed typo in read_dc_counter().
> v5: Addressed the review comment by removing redundant
> read_dc_counter(),
>     clubbed cleanup() function in test_dc_state_psr() suggested by
> Imre.
>     Rearranged  preprocessor directives at one place.
>     Fixed compilation warning by adding function prototype for
>     dc_state_wait_entry() and check_dc_counter().
>     Listing actual change in patch set changelog to make review
> easier.
> v6: Fixed "i915_edp_psr_status" string to "Sink support: yes".

Cc'ing Imre and José


> 
> Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/Makefile.sources |   1 +
>  tests/meson.build      |   1 +
>  tests/pm_dc.c          | 209
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 211 insertions(+)
>  create mode 100644 tests/pm_dc.c
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 34b7e44..07b9787 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -80,6 +80,7 @@ TESTS_progs = \
>  	pm_lpsp \
>  	pm_rc6_residency \
>  	pm_rpm \
> +	pm_dc \
>  	pm_rps \
>  	pm_sseu \
>  	prime_busy \
> diff --git a/tests/meson.build b/tests/meson.build
> index 25b4614..3070a3e 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -66,6 +66,7 @@ test_progs = [
>  	'pm_lpsp',
>  	'pm_rc6_residency',
>  	'pm_rpm',
> +	'pm_dc',
>  	'pm_rps',
>  	'pm_sseu',
>  	'prime_busy',
> diff --git a/tests/pm_dc.c b/tests/pm_dc.c
> new file mode 100644
> index 0000000..7e16721
> --- /dev/null
> +++ b/tests/pm_dc.c
> @@ -0,0 +1,209 @@
> +/*
> + * Copyright © 2018 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person
> obtaining a
> + * copy of this software and associated documentation files (the
> "Software"),
> + * to deal in the Software without restriction, including without
> limitation
> + * the rights to use, copy, modify, merge, publish, distribute,
> sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom
> the
> + * Software is furnished to do so, subject to the following
> conditions:
> + *
> + * The above copyright notice and this permission notice (including
> the next
> + * paragraph) shall be included in all copies or substantial
> portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO
> EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
> OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + */
> +
> +#include "igt.h"
> +#include "igt_sysfs.h"
> +#include "igt_psr.h"
> +#include <errno.h>
> +#include <stdbool.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include "intel_bufmgr.h"
> +#include "intel_io.h"
> +#include "limits.h"
> +
> +/* DC State Flags */
> +#define CHECK_DC5	1
> +#define CHECK_DC6	2
> +
> +typedef struct {
> +	int drm_fd;
> +	int debugfs_fd;
> +	uint32_t devid;
> +	igt_display_t display;
> +	struct igt_fb fb_white;
> +	enum psr_mode op_psr_mode;
> +	drmModeModeInfo *mode;
> +	igt_output_t *output;
> +} data_t;
> +
> +bool dc_state_wait_entry(int, int, int);
> +void check_dc_counter(int, int, uint32_t);
> +
> +static void setup_output(data_t *data)
> +{
> +	igt_display_t *display = &data->display;
> +	igt_output_t *output;
> +	enum pipe pipe;
> +
> +	for_each_pipe_with_valid_output(display, pipe, output) {
> +		drmModeConnectorPtr c = output->config.connector;
> +
> +		if (c->connector_type != DRM_MODE_CONNECTOR_eDP)
> +			continue;
> +
> +		igt_output_set_pipe(output, pipe);
> +		data->output = output;
> +		data->mode = igt_output_get_mode(output);
> +
> +		return;
> +	}
> +}
> +
> +static void display_fini(data_t *data)
> +{
> +	igt_display_fini(&data->display);
> +}
> +
> +static bool edp_psr_sink_support(data_t *data)

lib/psr.c already has a function to do this, please use that. Not using
the library function results in rebase changes like the one done in
this version.

> +{
> +	char buf[512];
> +
> +	igt_debugfs_simple_read(data->debugfs_fd,
> "i915_edp_psr_status",
> +			 buf, sizeof(buf));
> +
> +	return strstr(buf, "Sink support: yes");
> +}
> +
> +static void cleanup(data_t *data)
> +{
> +	igt_plane_t *primary;
> +
> +	primary = igt_output_get_plane_type(data->output,
> +					    DRM_PLANE_TYPE_PRIMARY);
> +	igt_plane_set_fb(primary, NULL);
> +	igt_display_commit(&data->display);
> +	igt_remove_fb(data->drm_fd, &data->fb_white);
> +}
> +
> +static void setup_primary(data_t *data)
> +{
> +	igt_plane_t *primary;
> +
> +	primary = igt_output_get_plane_type(data->output,
> +					    DRM_PLANE_TYPE_PRIMARY);
> +	igt_plane_set_fb(primary, NULL);
> +	igt_create_color_fb(data->drm_fd,
> +			    data->mode->hdisplay, data->mode->vdisplay,
> +			    DRM_FORMAT_XRGB8888,
> +			    LOCAL_I915_FORMAT_MOD_X_TILED,
> +			    1.0, 1.0, 1.0,
> +			    &data->fb_white);
> +	igt_plane_set_fb(primary, &data->fb_white);
> +	igt_display_commit(&data->display);
> +}
> +
> +static uint32_t get_dc_counter(char *dc_data)
> +{
> +	char *e;
> +	long ret;
> +	char *s = strchr(dc_data, ':');
> +
> +	assert(s);
> +	s++;
> +	ret = strtol(s, &e, 10);
> +	assert(((ret != LONG_MIN && ret != LONG_MAX) || errno !=
> ERANGE) &&
> +	       e > s && *e == '\n' && ret >= 0);
> +	return ret;
> +}
> +
> +static uint32_t read_dc_counter(uint32_t drm_fd, int dc_flag)
> +{
> +	char buf[4096];
> +	char *str;
> +
> +	igt_debugfs_read(drm_fd, "i915_dmc_info", buf);
> +
> +	if (dc_flag & CHECK_DC5)
> +		str = strstr(buf, "DC3 -> DC5 count");
> +
> +	else if (dc_flag & CHECK_DC6)
> +		str = strstr(buf, "DC5 -> DC6 count");
> +
> +	/* Check DC5/DC6 counter is available for the platform.
> +	 * Skip the test if counter is not available.
> +	 */
> +	igt_skip_on_f(str == NULL, "DC%d counter is not available\n",
> +		      dc_flag & CHECK_DC5 ? 5 : 6);

Shouldn't this be a failure since you already verified DMC is loaded?
IOW, what are the conditions where DMC is loaded but debugfs does not
contain DC5 and DC6 strings?

> +	return get_dc_counter(str);
> +}
> +
> +bool dc_state_wait_entry(int drm_fd, int dc_flag, int prev_dc_count)
> +{
> +	return igt_wait(read_dc_counter(drm_fd, dc_flag) >
> prev_dc_count, 1000, 100);
> +}
> +
> +void check_dc_counter(int drm_fd, int dc_flag, uint32_t
> prev_dc_count)
> +{
> +	igt_assert_f(dc_state_wait_entry(drm_fd, dc_flag,
> prev_dc_count),
> +		     "DC%d state is not achieved\n",
> +		     dc_flag & CHECK_DC5 ? 5 : 6);
Please consider debug logging the previous and current values read. 
> +}
> +
> +static void test_dc_state_psr(data_t *data, int dc_flag)
> +{
> +	uint32_t dc_counter_before_psr;
> +
> +	dc_counter_before_psr = read_dc_counter(data->drm_fd, dc_flag);
> +	setup_output(data);
> +	setup_primary(data);
> +	igt_assert(psr_wait_entry(data->debugfs_fd, data-
> >op_psr_mode));
> +	check_dc_counter(data->drm_fd, dc_flag, dc_counter_before_psr);
> +	cleanup(data);
> +}
> +
> +int main(int argc, char *argv[])
> +{
> +	bool has_runtime_pm;
> +	data_t data = {};
> +
> +	igt_skip_on_simulation();
> +	igt_subtest_init(argc, argv);
> +	igt_fixture {
> +		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
> +		data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
> +		igt_require(data.debugfs_fd != -1);
> +		kmstest_set_vt_graphics_mode();
> +		data.devid = intel_get_drm_devid(data.drm_fd);
> +		has_runtime_pm = igt_setup_runtime_pm();
> +		igt_info("Runtime PM support: %d\n", has_runtime_pm);
> +		igt_require(has_runtime_pm);
> +		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
> +		igt_display_require(&data.display, data.drm_fd);
> +	}
> +
> +	igt_subtest("dc5-psr") {
> +		data.op_psr_mode = PSR_MODE_1;
> +		psr_enable(data.debugfs_fd, data.op_psr_mode);
> +		igt_require_f(edp_psr_sink_support(&data),
> +			      "Sink does not support PSR\n");

Check for feature support before enabling PSR.

> +		test_dc_state_psr(&data, CHECK_DC5);
> +	}
> +	igt_fixture {
> +		close(data.debugfs_fd);
> +		display_fini(&data);
> +	}
> +
> +	igt_exit();
> +}

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v5 3/5] tests/pm_dc: Added test for DC6 during PSR

[Anshuman Gupta via igt-dev]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

This patch add subtest to check DC6 entry on PSR for the supported
platforms.

v2: Rename the subtest with more meaningful name.
v3: Rebased.
v4: Rebased, to fix compilation error in psr_enable().
    Addressed review comment by fixing typo in comment description
    of DC6 PSR subtest.
v5: Addressed the review comment by removing redundant read_dc_counter(),
    clubbed cleanup() function in test_dc_state_psr() suggested by Imre.
    Listing actual change in patch set changelog to make review easier.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/pm_dc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/pm_dc.c b/tests/pm_dc.c
index 56b0428..b26f3d8 100644
--- a/tests/pm_dc.c
+++ b/tests/pm_dc.c
@@ -200,6 +200,14 @@ int main(int argc, char *argv[])
 			      "Sink does not support PSR\n");
 		test_dc_state_psr(&data, CHECK_DC5);
 	}
+
+	igt_subtest("dc6-psr") {
+		data.op_psr_mode = PSR_MODE_1;
+		psr_enable(data.debugfs_fd, data.op_psr_mode);
+		igt_require_f(edp_psr_sink_support(&data),
+			      "Sink does not support PSR\n");
+		test_dc_state_psr(&data, CHECK_DC6);
+	}
 	igt_fixture {
 		close(data.debugfs_fd);
 		display_fini(&data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v5 4/5] tests/pm_dc: Added test for DC5 during DPMS

[Anshuman Gupta via igt-dev]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Added new subtest for DC5 entry during DPMS on/off cycle.
During DPMS on/off cycle DC5 counter is incremented.

v2: Rename the subtest with meaningful name.
v3: Rebased.
v4: Addressed review comments by removing leftover code
    cleanup().
v5: Addressed the review comment by removing redundant
    read_dc_counter() suggested by Imre.
    Listing actual change in patch set changelog to make review easier.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/pm_dc.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/tests/pm_dc.c b/tests/pm_dc.c
index b26f3d8..8bc684e 100644
--- a/tests/pm_dc.c
+++ b/tests/pm_dc.c
@@ -173,6 +173,29 @@ static void test_dc_state_psr(data_t *data, int dc_flag)
 	cleanup(&data);
 }
 
+static void dpms_off_on(data_t *data)
+{
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+					   DRM_MODE_DPMS_OFF);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+				   DRM_MODE_DPMS_ON);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
+}
+
+static void test_dc_state_dpms(data_t *data, int dc_flag)
+{
+	uint32_t dc_counter;
+
+	dc_counter = read_dc_counter(data->drm_fd, dc_flag);
+	dpms_off_on(data);
+	check_dc_counter(data->drm_fd, dc_flag, dc_counter);
+}
+
 int main(int argc, char *argv[])
 {
 	bool has_runtime_pm;
@@ -208,6 +231,11 @@ int main(int argc, char *argv[])
 			      "Sink does not support PSR\n");
 		test_dc_state_psr(&data, CHECK_DC6);
 	}
+
+	igt_subtest("dc5-dpms") {
+		test_dc_state_dpms(&data, CHECK_DC5);
+	}
+
 	igt_fixture {
 		close(data.debugfs_fd);
 		display_fini(&data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v6 4/5] tests/pm_dc: Added test for DC5 during DPMS

[Anshuman Gupta]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Added new subtest for DC5 entry during DPMS on/off cycle.
During DPMS on/off cycle DC5 counter is incremented.

v2: Rename the subtest with meaningful name.
v3: Rebased.
v4: Addressed review comments by removing leftover code
    cleanup().
v5: Addressed the review comment by removing redundant
    read_dc_counter() suggested by Imre.
    Listing actual change in patch set changelog to make review easier.
v6: Three way patch applied, no functional change.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/pm_dc.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/tests/pm_dc.c b/tests/pm_dc.c
index 4e65698..fbd4d33 100644
--- a/tests/pm_dc.c
+++ b/tests/pm_dc.c
@@ -173,6 +173,29 @@ static void test_dc_state_psr(data_t *data, int dc_flag)
 	cleanup(data);
 }
 
+static void dpms_off_on(data_t *data)
+{
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+					   DRM_MODE_DPMS_OFF);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+				   DRM_MODE_DPMS_ON);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
+}
+
+static void test_dc_state_dpms(data_t *data, int dc_flag)
+{
+	uint32_t dc_counter;
+
+	dc_counter = read_dc_counter(data->drm_fd, dc_flag);
+	dpms_off_on(data);
+	check_dc_counter(data->drm_fd, dc_flag, dc_counter);
+}
+
 int main(int argc, char *argv[])
 {
 	bool has_runtime_pm;
@@ -208,6 +231,11 @@ int main(int argc, char *argv[])
 			      "Sink does not support PSR\n");
 		test_dc_state_psr(&data, CHECK_DC6);
 	}
+
+	igt_subtest("dc5-dpms") {
+		test_dc_state_dpms(&data, CHECK_DC5);
+	}
+
 	igt_fixture {
 		close(data.debugfs_fd);
 		display_fini(&data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v5 5/5] tests/pm_dc: Added test for DC6 during DPMS

[Anshuman Gupta via igt-dev]

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Added new subtest for DC6 entry during DPMS on/off cycle.
During DPMS on/off cycle DC6 counter is incremented.

v2: Renamed the subtest name.
v3: Rebased.
v4: Addressed review comment by replacing igt_display_init() to
    igt_display_require(), changes got done in patch set 2.
v5: Addressed the review comment by removing redundant read_dc_counter()
    suggested by Imre.
    Listing actual change in patch set changelog to make review easier.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/pm_dc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/pm_dc.c b/tests/pm_dc.c
index 8bc684e..a6f821a 100644
--- a/tests/pm_dc.c
+++ b/tests/pm_dc.c
@@ -236,6 +236,10 @@ int main(int argc, char *argv[])
 		test_dc_state_dpms(&data, CHECK_DC5);
 	}
 
+	igt_subtest("dc6-dpms") {
+		test_dc_state_dpms(&data, CHECK_DC6);
+	}
+
 	igt_fixture {
 		close(data.debugfs_fd);
 		display_fini(&data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series

[Patchwork]

== Series Details ==

Series: DC states igt tests patch series
URL   : https://patchwork.freedesktop.org/series/56713/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5615 -> IGTPW_2432
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2432 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]

  * igt@pm_rpm@module-reload:
    - fi-skl-6770hq:      PASS -> FAIL [fdo#108511]

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  * igt@kms_pipe_crc_basic@read-crc-pipe-a:
    - fi-byt-clapper:     FAIL [fdo#107362] -> PASS

  * igt@pm_rpm@module-reload:
    - {fi-icl-y}:         INCOMPLETE [fdo#108840] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315


Participating hosts (43 -> 39)
------------------------------

  Missing    (4): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-skl-gvtdvm 


Build changes
-------------

    * IGT: IGT_4833 -> IGTPW_2432

  CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
  IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@pm_dc@dc5-dpms
+igt@pm_dc@dc5-psr
+igt@pm_dc@dc6-dpms
+igt@pm_dc@dc6-psr

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series

[Patchwork]

== Series Details ==

Series: DC states igt tests patch series
URL   : https://patchwork.freedesktop.org/series/56713/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5615_full -> IGTPW_2432_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_2432_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2432_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2432_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
    - shard-apl:          PASS -> FAIL

  * {igt@pm_dc@dc5-dpms} (NEW):
    - shard-glk:          NOTRUN -> FAIL
    - shard-apl:          NOTRUN -> FAIL

  
New tests
---------

  New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:

### New IGT tests (4) ###

  * igt@pm_dc@dc5-dpms:
    - Statuses : 2 fail(s) 2 skip(s)
    - Exec time: [0.0, 1.65] s

  * igt@pm_dc@dc5-psr:
    - Statuses : 4 skip(s)
    - Exec time: [0.0] s

  * igt@pm_dc@dc6-dpms:
    - Statuses : 4 skip(s)
    - Exec time: [0.0, 0.00] s

  * igt@pm_dc@dc6-psr:
    - Statuses : 4 skip(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_2432_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_atomic_transition@plane-all-modeset-transition:
    - shard-apl:          PASS -> INCOMPLETE [fdo#103927]

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
    - shard-snb:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
    - shard-glk:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
    - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_cursor_crc@cursor-64x21-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +1

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          PASS -> FAIL [fdo#105363] +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-apl:          PASS -> FAIL [fdo#103167] +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-glk:          NOTRUN -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          PASS -> FAIL [fdo#103167] +9

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
    - shard-glk:          PASS -> FAIL [fdo#103166] +4
    - shard-apl:          PASS -> FAIL [fdo#103166] +1

  * igt@kms_setmode@basic:
    - shard-apl:          PASS -> FAIL [fdo#99912]
    - shard-hsw:          PASS -> FAIL [fdo#99912]

  * {igt@pm_dc@dc5-dpms} (NEW):
    - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3

  * {igt@pm_dc@dc5-psr} (NEW):
    - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2

  * {igt@pm_dc@dc6-psr} (NEW):
    - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
    - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2

  
#### Possible fixes ####

  * igt@gem_eio@unwedge-stress:
    - shard-snb:          FAIL -> PASS

  * igt@gem_linear_blits@normal:
    - shard-snb:          INCOMPLETE [fdo#105411] -> PASS

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
    - shard-apl:          FAIL -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS +6

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
    - shard-glk:          FAIL [fdo#103167] -> PASS +1

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
    - shard-apl:          FAIL [fdo#103167] -> PASS +4

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
    - shard-apl:          FAIL [fdo#108145] -> PASS

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
    - shard-glk:          FAIL [fdo#103166] -> PASS

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-apl:          FAIL [fdo#103166] -> PASS +4

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-snb:          {SKIP} [fdo#109271] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (7 -> 4)
------------------------------

  Missing    (3): shard-skl shard-kbl shard-iclb 


Build changes
-------------

    * IGT: IGT_4833 -> IGTPW_2432
    * Piglit: piglit_4509 -> None

  CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
  IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series

[Imre Deak]

Hi Jyoti, Anshuman,

On Sat, Feb 16, 2019 at 09:40:44PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: DC states igt tests patch series
> URL   : https://patchwork.freedesktop.org/series/56713/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_5615_full -> IGTPW_2432_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with IGTPW_2432_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_2432_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/1/mbox/
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in IGTPW_2432_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
>     - shard-apl:          PASS -> FAIL
> 
>   * {igt@pm_dc@dc5-dpms} (NEW):
>     - shard-glk:          NOTRUN -> FAIL

The problem here is that the device gets runtime suspended, after which
the DMC FW will get reprogrammed during runtime resume. This means the
FW's DC counters will get reset too.

I think it makes sense to test DC5 independent of runtime s/r (where
we'd go to DC9). That could be done by running the DC5/6 DPMS tests with
runtime suspend disabled on platforms that support DC9.

Could you please add that?

>     - shard-apl:          NOTRUN -> FAIL
> 
>   
> New tests
> ---------
> 
>   New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:
> 
> ### New IGT tests (4) ###
> 
>   * igt@pm_dc@dc5-dpms:
>     - Statuses : 2 fail(s) 2 skip(s)
>     - Exec time: [0.0, 1.65] s
> 
>   * igt@pm_dc@dc5-psr:
>     - Statuses : 4 skip(s)
>     - Exec time: [0.0] s
> 
>   * igt@pm_dc@dc6-dpms:
>     - Statuses : 4 skip(s)
>     - Exec time: [0.0, 0.00] s
> 
>   * igt@pm_dc@dc6-psr:
>     - Statuses : 4 skip(s)
>     - Exec time: [0.0] s
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in IGTPW_2432_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@kms_atomic_transition@plane-all-modeset-transition:
>     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
>     - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
>     - shard-glk:          PASS -> DMESG-WARN [fdo#107956]
> 
>   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
>     - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]
> 
>   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
>     - shard-glk:          PASS -> FAIL [fdo#108145]
> 
>   * igt@kms_cursor_crc@cursor-64x21-random:
>     - shard-apl:          PASS -> FAIL [fdo#103232] +1
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-glk:          PASS -> FAIL [fdo#105363] +1
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
>     - shard-apl:          PASS -> FAIL [fdo#103167] +1
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
>     - shard-glk:          NOTRUN -> FAIL [fdo#103167]
> 
>   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
>     - shard-glk:          PASS -> FAIL [fdo#103167] +9
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> 
>   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
>     - shard-glk:          PASS -> FAIL [fdo#103166] +4
>     - shard-apl:          PASS -> FAIL [fdo#103166] +1
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          PASS -> FAIL [fdo#99912]
>     - shard-hsw:          PASS -> FAIL [fdo#99912]
> 
>   * {igt@pm_dc@dc5-dpms} (NEW):
>     - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3
> 
>   * {igt@pm_dc@dc5-psr} (NEW):
>     - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2
> 
>   * {igt@pm_dc@dc6-psr} (NEW):
>     - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
>     - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_eio@unwedge-stress:
>     - shard-snb:          FAIL -> PASS
> 
>   * igt@gem_linear_blits@normal:
>     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> 
>   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
>     - shard-apl:          FAIL -> PASS
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
>     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> 
>   * igt@kms_cursor_crc@cursor-128x128-random:
>     - shard-apl:          FAIL [fdo#103232] -> PASS +6
> 
>   * igt@kms_cursor_crc@cursor-64x64-suspend:
>     - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
>     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
>     - shard-apl:          FAIL [fdo#103167] -> PASS +4
> 
>   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
>     - shard-apl:          FAIL [fdo#108145] -> PASS
> 
>   * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
>     - shard-glk:          FAIL [fdo#103166] -> PASS
> 
>   * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
>     - shard-apl:          FAIL [fdo#103166] -> PASS +4
> 
>   * igt@pm_rc6_residency@rc6-accuracy:
>     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
>   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> 
> 
> Participating hosts (7 -> 4)
> ------------------------------
> 
>   Missing    (3): shard-skl shard-kbl shard-iclb 
> 
> 
> Build changes
> -------------
> 
>     * IGT: IGT_4833 -> IGTPW_2432
>     * Piglit: piglit_4509 -> None
> 
>   CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
>   IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series

[Anshuman Gupta]

On Thu, Feb 21, 2019 at 05:31:32PM +0200, Imre Deak wrote:
> Hi Jyoti, Anshuman,
> 
> On Sat, Feb 16, 2019 at 09:40:44PM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: DC states igt tests patch series
> > URL   : https://patchwork.freedesktop.org/series/56713/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_5615_full -> IGTPW_2432_full
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with IGTPW_2432_full absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in IGTPW_2432_full, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://patchwork.freedesktop.org/api/1.0/series/56713/revisions/1/mbox/
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in IGTPW_2432_full:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> >     - shard-apl:          PASS -> FAIL
> > 
> >   * {igt@pm_dc@dc5-dpms} (NEW):
> >     - shard-glk:          NOTRUN -> FAIL
> 
> The problem here is that the device gets runtime suspended, after which
> the DMC FW will get reprogrammed during runtime resume. This means the
> FW's DC counters will get reset too.
> 
> I think it makes sense to test DC5 independent of runtime s/r (where
> we'd go to DC9). That could be done by running the DC5/6 DPMS tests with
> runtime suspend disabled on platforms that support DC9.
> 
> Could you please add that?
I did not get it how to achieve DC9 with i915 runtime suspend disabled.
AFAIK DC9 is enabled by suspend callback intel_runtime_suspend, i915_drm_suspend_late.
Please let me know if it can be enabled by some other code flow.

> 
> >     - shard-apl:          NOTRUN -> FAIL
> > 
> >   
> > New tests
> > ---------
> > 
> >   New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:
> > 
> > ### New IGT tests (4) ###
> > 
> >   * igt@pm_dc@dc5-dpms:
> >     - Statuses : 2 fail(s) 2 skip(s)
> >     - Exec time: [0.0, 1.65] s
> > 
> >   * igt@pm_dc@dc5-psr:
> >     - Statuses : 4 skip(s)
> >     - Exec time: [0.0] s
> > 
> >   * igt@pm_dc@dc6-dpms:
> >     - Statuses : 4 skip(s)
> >     - Exec time: [0.0, 0.00] s
> > 
> >   * igt@pm_dc@dc6-psr:
> >     - Statuses : 4 skip(s)
> >     - Exec time: [0.0] s
> > 
> >   
> > 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in IGTPW_2432_full that come from known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@kms_atomic_transition@plane-all-modeset-transition:
> >     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> > 
> >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> >     - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
> > 
> >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> >     - shard-glk:          PASS -> DMESG-WARN [fdo#107956]
> > 
> >   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> >     - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]
> > 
> >   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
> >     - shard-glk:          PASS -> FAIL [fdo#108145]
> > 
> >   * igt@kms_cursor_crc@cursor-64x21-random:
> >     - shard-apl:          PASS -> FAIL [fdo#103232] +1
> > 
> >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> >     - shard-glk:          PASS -> FAIL [fdo#105363] +1
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> >     - shard-apl:          PASS -> FAIL [fdo#103167] +1
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> >     - shard-glk:          NOTRUN -> FAIL [fdo#103167]
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> >     - shard-glk:          PASS -> FAIL [fdo#103167] +9
> > 
> >   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> >     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> > 
> >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
> >     - shard-glk:          PASS -> FAIL [fdo#103166] +4
> >     - shard-apl:          PASS -> FAIL [fdo#103166] +1
> > 
> >   * igt@kms_setmode@basic:
> >     - shard-apl:          PASS -> FAIL [fdo#99912]
> >     - shard-hsw:          PASS -> FAIL [fdo#99912]
> > 
> >   * {igt@pm_dc@dc5-dpms} (NEW):
> >     - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3
> > 
> >   * {igt@pm_dc@dc5-psr} (NEW):
> >     - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2
> > 
> >   * {igt@pm_dc@dc6-psr} (NEW):
> >     - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
> >     - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@gem_eio@unwedge-stress:
> >     - shard-snb:          FAIL -> PASS
> > 
> >   * igt@gem_linear_blits@normal:
> >     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> > 
> >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
> >     - shard-apl:          FAIL -> PASS
> > 
> >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> >     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> > 
> >   * igt@kms_cursor_crc@cursor-128x128-random:
> >     - shard-apl:          FAIL [fdo#103232] -> PASS +6
> > 
> >   * igt@kms_cursor_crc@cursor-64x64-suspend:
> >     - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
> >     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> > 
> >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> >     - shard-apl:          FAIL [fdo#103167] -> PASS +4
> > 
> >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> >     - shard-apl:          FAIL [fdo#108145] -> PASS
> > 
> >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> >     - shard-glk:          FAIL [fdo#103166] -> PASS
> > 
> >   * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> >     - shard-apl:          FAIL [fdo#103166] -> PASS +4
> > 
> >   * igt@pm_rc6_residency@rc6-accuracy:
> >     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> > 
> >   
> >   {name}: This element is suppressed. This means it is ignored when computing
> >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > 
> >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> >   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
> >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> >   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> >   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> >   [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
> >   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> >   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> > 
> > 
> > Participating hosts (7 -> 4)
> > ------------------------------
> > 
> >   Missing    (3): shard-skl shard-kbl shard-iclb 
> > 
> > 
> > Build changes
> > -------------
> > 
> >     * IGT: IGT_4833 -> IGTPW_2432
> >     * Piglit: piglit_4509 -> None
> > 
> >   CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
> >   IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> >   IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> > 
> > == Logs ==
> > 
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
Thanks ,
Anshuman Gupta.
-- 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series

[Imre Deak]

On Fri, Feb 22, 2019 at 08:31:54PM +0530, Anshuman Gupta wrote:
> > > [...]
> > > #### Possible regressions ####
> > > 
> > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> > >     - shard-apl:          PASS -> FAIL
> > > 
> > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > >     - shard-glk:          NOTRUN -> FAIL
> > 
> > The problem here is that the device gets runtime suspended, after which
> > the DMC FW will get reprogrammed during runtime resume. This means the
> > FW's DC counters will get reset too.
> > 
> > I think it makes sense to test DC5 independent of runtime s/r (where
> > we'd go to DC9). That could be done by running the DC5/6 DPMS tests with
> > runtime suspend disabled on platforms that support DC9.
> > 
> > Could you please add that?
>
> I did not get it how to achieve DC9 with i915 runtime suspend
> disabled.  AFAIK DC9 is enabled by suspend callback
> intel_runtime_suspend, i915_drm_suspend_late.  Please let me know if
> it can be enabled by some other code flow.

We want to prevent DC9, because that clears the DC5/6 counters in the
firmware, leading to the above test failure.

--Imre

> 
> > 
> > >     - shard-apl:          NOTRUN -> FAIL
> > > 
> > >   
> > > New tests
> > > ---------
> > > 
> > >   New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:
> > > 
> > > ### New IGT tests (4) ###
> > > 
> > >   * igt@pm_dc@dc5-dpms:
> > >     - Statuses : 2 fail(s) 2 skip(s)
> > >     - Exec time: [0.0, 1.65] s
> > > 
> > >   * igt@pm_dc@dc5-psr:
> > >     - Statuses : 4 skip(s)
> > >     - Exec time: [0.0] s
> > > 
> > >   * igt@pm_dc@dc6-dpms:
> > >     - Statuses : 4 skip(s)
> > >     - Exec time: [0.0, 0.00] s
> > > 
> > >   * igt@pm_dc@dc6-psr:
> > >     - Statuses : 4 skip(s)
> > >     - Exec time: [0.0] s
> > > 
> > >   
> > > 
> > > Known issues
> > > ------------
> > > 
> > >   Here are the changes found in IGTPW_2432_full that come from known issues:
> > > 
> > > ### IGT changes ###
> > > 
> > > #### Issues hit ####
> > > 
> > >   * igt@kms_atomic_transition@plane-all-modeset-transition:
> > >     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> > > 
> > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> > >     - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
> > > 
> > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > >     - shard-glk:          PASS -> DMESG-WARN [fdo#107956]
> > > 
> > >   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> > >     - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]
> > > 
> > >   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
> > >     - shard-glk:          PASS -> FAIL [fdo#108145]
> > > 
> > >   * igt@kms_cursor_crc@cursor-64x21-random:
> > >     - shard-apl:          PASS -> FAIL [fdo#103232] +1
> > > 
> > >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> > >     - shard-glk:          PASS -> FAIL [fdo#105363] +1
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > >     - shard-apl:          PASS -> FAIL [fdo#103167] +1
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> > >     - shard-glk:          NOTRUN -> FAIL [fdo#103167]
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> > >     - shard-glk:          PASS -> FAIL [fdo#103167] +9
> > > 
> > >   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> > >     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> > > 
> > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
> > >     - shard-glk:          PASS -> FAIL [fdo#103166] +4
> > >     - shard-apl:          PASS -> FAIL [fdo#103166] +1
> > > 
> > >   * igt@kms_setmode@basic:
> > >     - shard-apl:          PASS -> FAIL [fdo#99912]
> > >     - shard-hsw:          PASS -> FAIL [fdo#99912]
> > > 
> > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > >     - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3
> > > 
> > >   * {igt@pm_dc@dc5-psr} (NEW):
> > >     - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > 
> > >   * {igt@pm_dc@dc6-psr} (NEW):
> > >     - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
> > >     - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > 
> > >   
> > > #### Possible fixes ####
> > > 
> > >   * igt@gem_eio@unwedge-stress:
> > >     - shard-snb:          FAIL -> PASS
> > > 
> > >   * igt@gem_linear_blits@normal:
> > >     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> > > 
> > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
> > >     - shard-apl:          FAIL -> PASS
> > > 
> > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > >     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> > > 
> > >   * igt@kms_cursor_crc@cursor-128x128-random:
> > >     - shard-apl:          FAIL [fdo#103232] -> PASS +6
> > > 
> > >   * igt@kms_cursor_crc@cursor-64x64-suspend:
> > >     - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
> > >     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> > > 
> > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> > >     - shard-apl:          FAIL [fdo#103167] -> PASS +4
> > > 
> > >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> > >     - shard-apl:          FAIL [fdo#108145] -> PASS
> > > 
> > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> > >     - shard-glk:          FAIL [fdo#103166] -> PASS
> > > 
> > >   * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> > >     - shard-apl:          FAIL [fdo#103166] -> PASS +4
> > > 
> > >   * igt@pm_rc6_residency@rc6-accuracy:
> > >     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> > > 
> > >   
> > >   {name}: This element is suppressed. This means it is ignored when computing
> > >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > > 
> > >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > >   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
> > >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > >   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> > >   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> > >   [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
> > >   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> > >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> > >   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> > > 
> > > 
> > > Participating hosts (7 -> 4)
> > > ------------------------------
> > > 
> > >   Missing    (3): shard-skl shard-kbl shard-iclb 
> > > 
> > > 
> > > Build changes
> > > -------------
> > > 
> > >     * IGT: IGT_4833 -> IGTPW_2432
> > >     * Piglit: piglit_4509 -> None
> > > 
> > >   CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
> > >   IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > >   IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> > > 
> > > == Logs ==
> > > 
> > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> Thanks ,
> Anshuman Gupta.
> -- 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series

[Anshuman Gupta]

On Mon, Feb 25, 2019 at 12:42:35PM +0200, Imre Deak wrote:
> On Fri, Feb 22, 2019 at 08:31:54PM +0530, Anshuman Gupta wrote:
> > > > [...]
> > > > #### Possible regressions ####
> > > > 
> > > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> > > >     - shard-apl:          PASS -> FAIL
> > > > 
> > > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > > >     - shard-glk:          NOTRUN -> FAIL
> > > 
> > > The problem here is that the device gets runtime suspended, after which
> > > the DMC FW will get reprogrammed during runtime resume. This means the
> > > FW's DC counters will get reset too.
> > > 
> > > I think it makes sense to test DC5 independent of runtime s/r (where
> > > we'd go to DC9). That could be done by running the DC5/6 DPMS tests with
> > > runtime suspend disabled on platforms that support DC9.
> > > 
> > > Could you please add that?
> >
> > I did not get it how to achieve DC9 with i915 runtime suspend
> > disabled.  AFAIK DC9 is enabled by suspend callback
> > intel_runtime_suspend, i915_drm_suspend_late.  Please let me know if
> > it can be enabled by some other code flow.
> 
> We want to prevent DC9, because that clears the DC5/6 counters in the
> firmware, leading to the above test failure.
Thanks for clarification, in order to do that we need to expose allowed_dc_mask
to i915_dmc_info from i915 driver and in igt lib we would need a new function to 
disable runtime suspend. Please correct if there can be other way to do that.

Thanks,
Anshuman.  
> 
> --Imre
> 
> > 
> > > 
> > > >     - shard-apl:          NOTRUN -> FAIL
> > > > 
> > > >   
> > > > New tests
> > > > ---------
> > > > 
> > > >   New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:
> > > > 
> > > > ### New IGT tests (4) ###
> > > > 
> > > >   * igt@pm_dc@dc5-dpms:
> > > >     - Statuses : 2 fail(s) 2 skip(s)
> > > >     - Exec time: [0.0, 1.65] s
> > > > 
> > > >   * igt@pm_dc@dc5-psr:
> > > >     - Statuses : 4 skip(s)
> > > >     - Exec time: [0.0] s
> > > > 
> > > >   * igt@pm_dc@dc6-dpms:
> > > >     - Statuses : 4 skip(s)
> > > >     - Exec time: [0.0, 0.00] s
> > > > 
> > > >   * igt@pm_dc@dc6-psr:
> > > >     - Statuses : 4 skip(s)
> > > >     - Exec time: [0.0] s
> > > > 
> > > >   
> > > > 
> > > > Known issues
> > > > ------------
> > > > 
> > > >   Here are the changes found in IGTPW_2432_full that come from known issues:
> > > > 
> > > > ### IGT changes ###
> > > > 
> > > > #### Issues hit ####
> > > > 
> > > >   * igt@kms_atomic_transition@plane-all-modeset-transition:
> > > >     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> > > > 
> > > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> > > >     - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
> > > > 
> > > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > > >     - shard-glk:          PASS -> DMESG-WARN [fdo#107956]
> > > > 
> > > >   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> > > >     - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]
> > > > 
> > > >   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
> > > >     - shard-glk:          PASS -> FAIL [fdo#108145]
> > > > 
> > > >   * igt@kms_cursor_crc@cursor-64x21-random:
> > > >     - shard-apl:          PASS -> FAIL [fdo#103232] +1
> > > > 
> > > >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> > > >     - shard-glk:          PASS -> FAIL [fdo#105363] +1
> > > > 
> > > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > > >     - shard-apl:          PASS -> FAIL [fdo#103167] +1
> > > > 
> > > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> > > >     - shard-glk:          NOTRUN -> FAIL [fdo#103167]
> > > > 
> > > >   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> > > >     - shard-glk:          PASS -> FAIL [fdo#103167] +9
> > > > 
> > > >   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> > > >     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> > > > 
> > > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
> > > >     - shard-glk:          PASS -> FAIL [fdo#103166] +4
> > > >     - shard-apl:          PASS -> FAIL [fdo#103166] +1
> > > > 
> > > >   * igt@kms_setmode@basic:
> > > >     - shard-apl:          PASS -> FAIL [fdo#99912]
> > > >     - shard-hsw:          PASS -> FAIL [fdo#99912]
> > > > 
> > > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > > >     - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3
> > > > 
> > > >   * {igt@pm_dc@dc5-psr} (NEW):
> > > >     - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > > 
> > > >   * {igt@pm_dc@dc6-psr} (NEW):
> > > >     - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
> > > >     - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > > 
> > > >   
> > > > #### Possible fixes ####
> > > > 
> > > >   * igt@gem_eio@unwedge-stress:
> > > >     - shard-snb:          FAIL -> PASS
> > > > 
> > > >   * igt@gem_linear_blits@normal:
> > > >     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> > > > 
> > > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
> > > >     - shard-apl:          FAIL -> PASS
> > > > 
> > > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > > >     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> > > > 
> > > >   * igt@kms_cursor_crc@cursor-128x128-random:
> > > >     - shard-apl:          FAIL [fdo#103232] -> PASS +6
> > > > 
> > > >   * igt@kms_cursor_crc@cursor-64x64-suspend:
> > > >     - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
> > > > 
> > > >   * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
> > > >     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> > > > 
> > > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> > > >     - shard-apl:          FAIL [fdo#103167] -> PASS +4
> > > > 
> > > >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> > > >     - shard-apl:          FAIL [fdo#108145] -> PASS
> > > > 
> > > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> > > >     - shard-glk:          FAIL [fdo#103166] -> PASS
> > > > 
> > > >   * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> > > >     - shard-apl:          FAIL [fdo#103166] -> PASS +4
> > > > 
> > > >   * igt@pm_rc6_residency@rc6-accuracy:
> > > >     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> > > > 
> > > >   
> > > >   {name}: This element is suppressed. This means it is ignored when computing
> > > >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > > > 
> > > >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > > >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > > >   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
> > > >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > > >   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> > > >   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > > >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > > >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> > > >   [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
> > > >   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> > > >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > > >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > > >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > > >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> > > >   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> > > > 
> > > > 
> > > > Participating hosts (7 -> 4)
> > > > ------------------------------
> > > > 
> > > >   Missing    (3): shard-skl shard-kbl shard-iclb 
> > > > 
> > > > 
> > > > Build changes
> > > > -------------
> > > > 
> > > >     * IGT: IGT_4833 -> IGTPW_2432
> > > >     * Piglit: piglit_4509 -> None
> > > > 
> > > >   CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
> > > >   IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > > >   IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > > >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> > > > 
> > > > == Logs ==
> > > > 
> > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > > > _______________________________________________
> > > > igt-dev mailing list
> > > > igt-dev@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> > Thanks ,
> > Anshuman Gupta.
> > -- 

-- 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for DC states igt tests patch series

[Imre Deak]

On Tue, Feb 26, 2019 at 11:37:09AM +0530, Anshuman Gupta wrote:
> On Mon, Feb 25, 2019 at 12:42:35PM +0200, Imre Deak wrote:
> > On Fri, Feb 22, 2019 at 08:31:54PM +0530, Anshuman Gupta wrote:
> > > > > [...]
> > > > > #### Possible regressions ####
> > > > > 
> > > > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> > > > >     - shard-apl:          PASS -> FAIL
> > > > > 
> > > > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > > > >     - shard-glk:          NOTRUN -> FAIL
> > > > 
> > > > The problem here is that the device gets runtime suspended, after which
> > > > the DMC FW will get reprogrammed during runtime resume. This means the
> > > > FW's DC counters will get reset too.
> > > > 
> > > > I think it makes sense to test DC5 independent of runtime s/r (where
> > > > we'd go to DC9). That could be done by running the DC5/6 DPMS tests with
> > > > runtime suspend disabled on platforms that support DC9.
> > > > 
> > > > Could you please add that?
> > >
> > > I did not get it how to achieve DC9 with i915 runtime suspend
> > > disabled.  AFAIK DC9 is enabled by suspend callback
> > > intel_runtime_suspend, i915_drm_suspend_late.  Please let me know if
> > > it can be enabled by some other code flow.
> > 
> > We want to prevent DC9, because that clears the DC5/6 counters in the
> > firmware, leading to the above test failure.
> Thanks for clarification, in order to do that we need to expose allowed_dc_mask
> to i915_dmc_info from i915 driver and in igt lib we would need a new function to 
> disable runtime suspend. Please correct if there can be other way to do that.

For now, I'd just check for IS_BROXTON() || IS_GEMINILAKE() || GEN>=11.

> 
> Thanks,
> Anshuman.  
> > 
> > --Imre
> > 
> > > 
> > > > 
> > > > >     - shard-apl:          NOTRUN -> FAIL
> > > > > 
> > > > >   
> > > > > New tests
> > > > > ---------
> > > > > 
> > > > >   New tests have been introduced between CI_DRM_5615_full and IGTPW_2432_full:
> > > > > 
> > > > > ### New IGT tests (4) ###
> > > > > 
> > > > >   * igt@pm_dc@dc5-dpms:
> > > > >     - Statuses : 2 fail(s) 2 skip(s)
> > > > >     - Exec time: [0.0, 1.65] s
> > > > > 
> > > > >   * igt@pm_dc@dc5-psr:
> > > > >     - Statuses : 4 skip(s)
> > > > >     - Exec time: [0.0] s
> > > > > 
> > > > >   * igt@pm_dc@dc6-dpms:
> > > > >     - Statuses : 4 skip(s)
> > > > >     - Exec time: [0.0, 0.00] s
> > > > > 
> > > > >   * igt@pm_dc@dc6-psr:
> > > > >     - Statuses : 4 skip(s)
> > > > >     - Exec time: [0.0] s
> > > > > 
> > > > >   
> > > > > 
> > > > > Known issues
> > > > > ------------
> > > > > 
> > > > >   Here are the changes found in IGTPW_2432_full that come from known issues:
> > > > > 
> > > > > ### IGT changes ###
> > > > > 
> > > > > #### Issues hit ####
> > > > > 
> > > > >   * igt@kms_atomic_transition@plane-all-modeset-transition:
> > > > >     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> > > > > 
> > > > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> > > > >     - shard-snb:          PASS -> DMESG-WARN [fdo#107956]
> > > > > 
> > > > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > > > >     - shard-glk:          PASS -> DMESG-WARN [fdo#107956]
> > > > > 
> > > > >   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
> > > > >     - shard-apl:          PASS -> FAIL [fdo#106510] / [fdo#108145]
> > > > > 
> > > > >   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
> > > > >     - shard-glk:          PASS -> FAIL [fdo#108145]
> > > > > 
> > > > >   * igt@kms_cursor_crc@cursor-64x21-random:
> > > > >     - shard-apl:          PASS -> FAIL [fdo#103232] +1
> > > > > 
> > > > >   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
> > > > >     - shard-glk:          PASS -> FAIL [fdo#105363] +1
> > > > > 
> > > > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
> > > > >     - shard-apl:          PASS -> FAIL [fdo#103167] +1
> > > > > 
> > > > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
> > > > >     - shard-glk:          NOTRUN -> FAIL [fdo#103167]
> > > > > 
> > > > >   * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
> > > > >     - shard-glk:          PASS -> FAIL [fdo#103167] +9
> > > > > 
> > > > >   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
> > > > >     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> > > > > 
> > > > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
> > > > >     - shard-glk:          PASS -> FAIL [fdo#103166] +4
> > > > >     - shard-apl:          PASS -> FAIL [fdo#103166] +1
> > > > > 
> > > > >   * igt@kms_setmode@basic:
> > > > >     - shard-apl:          PASS -> FAIL [fdo#99912]
> > > > >     - shard-hsw:          PASS -> FAIL [fdo#99912]
> > > > > 
> > > > >   * {igt@pm_dc@dc5-dpms} (NEW):
> > > > >     - shard-hsw:          NOTRUN -> {SKIP} [fdo#109271] +3
> > > > > 
> > > > >   * {igt@pm_dc@dc5-psr} (NEW):
> > > > >     - shard-glk:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > > > 
> > > > >   * {igt@pm_dc@dc6-psr} (NEW):
> > > > >     - shard-snb:          NOTRUN -> {SKIP} [fdo#109271] +3
> > > > >     - shard-apl:          NOTRUN -> {SKIP} [fdo#109271] +2
> > > > > 
> > > > >   
> > > > > #### Possible fixes ####
> > > > > 
> > > > >   * igt@gem_eio@unwedge-stress:
> > > > >     - shard-snb:          FAIL -> PASS
> > > > > 
> > > > >   * igt@gem_linear_blits@normal:
> > > > >     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS
> > > > > 
> > > > >   * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
> > > > >     - shard-apl:          FAIL -> PASS
> > > > > 
> > > > >   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
> > > > >     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> > > > > 
> > > > >   * igt@kms_cursor_crc@cursor-128x128-random:
> > > > >     - shard-apl:          FAIL [fdo#103232] -> PASS +6
> > > > > 
> > > > >   * igt@kms_cursor_crc@cursor-64x64-suspend:
> > > > >     - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
> > > > > 
> > > > >   * igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
> > > > >     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> > > > > 
> > > > >   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
> > > > >     - shard-apl:          FAIL [fdo#103167] -> PASS +4
> > > > > 
> > > > >   * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
> > > > >     - shard-apl:          FAIL [fdo#108145] -> PASS
> > > > > 
> > > > >   * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
> > > > >     - shard-glk:          FAIL [fdo#103166] -> PASS
> > > > > 
> > > > >   * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
> > > > >     - shard-apl:          FAIL [fdo#103166] -> PASS +4
> > > > > 
> > > > >   * igt@pm_rc6_residency@rc6-accuracy:
> > > > >     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> > > > > 
> > > > >   
> > > > >   {name}: This element is suppressed. This means it is ignored when computing
> > > > >           the status of the difference (SUCCESS, WARNING, or FAILURE).
> > > > > 
> > > > >   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > > > >   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > > > >   [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
> > > > >   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > > > >   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> > > > >   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > > > >   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > > > >   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> > > > >   [fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
> > > > >   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
> > > > >   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > > > >   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > > > >   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
> > > > >   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> > > > >   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> > > > > 
> > > > > 
> > > > > Participating hosts (7 -> 4)
> > > > > ------------------------------
> > > > > 
> > > > >   Missing    (3): shard-skl shard-kbl shard-iclb 
> > > > > 
> > > > > 
> > > > > Build changes
> > > > > -------------
> > > > > 
> > > > >     * IGT: IGT_4833 -> IGTPW_2432
> > > > >     * Piglit: piglit_4509 -> None
> > > > > 
> > > > >   CI_DRM_5615: a6e4cbf00557faf0c2d68fdff81b1afb9242aa4d @ git://anongit.freedesktop.org/gfx-ci/linux
> > > > >   IGTPW_2432: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > > > >   IGT_4833: 7802324e86ddf947cba847e910f75b1a8affe8d7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > > > >   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> > > > > 
> > > > > == Logs ==
> > > > > 
> > > > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2432/
> > > > > _______________________________________________
> > > > > igt-dev mailing list
> > > > > igt-dev@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> > > Thanks ,
> > > Anshuman Gupta.
> > > -- 
> 
> -- 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev