From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t
Date: Mon, 11 Mar 2019 15:31:49 +0200 [thread overview]
Message-ID: <20190311133150.9868-1-arkadiusz.hiler@intel.com> (raw)
It's set up for capture and then freed but never used.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/kms_plane_scaling.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 1015c80c..d408a203 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -33,7 +33,6 @@ typedef struct {
int drm_fd;
igt_display_t display;
igt_crc_t ref_crc;
- igt_pipe_crc_t *pipe_crc;
int image_w;
int image_h;
@@ -72,8 +71,6 @@ static void cleanup_fbs(data_t *data)
static void cleanup_crtc(data_t *data)
{
igt_display_reset(&data->display);
- igt_pipe_crc_free(data->pipe_crc);
- data->pipe_crc = NULL;
cleanup_fbs(data);
}
@@ -89,9 +86,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
igt_output_set_pipe(output, pipe);
- /* create the pipe_crc object for this pipe */
- data->pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
-
igt_skip_on(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888,
tiling));
@@ -566,7 +560,6 @@ igt_main
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_AMDGPU);
- igt_require_pipe_crc(data.drm_fd);
igt_display_require(&data.display, data.drm_fd);
data.devid = is_i915_device(data.drm_fd) ?
intel_get_drm_devid(data.drm_fd) : 0;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-03-11 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 13:31 Arkadiusz Hiler [this message]
2019-03-11 13:31 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Do not iterate over output twice Arkadiusz Hiler
2019-03-11 14:05 ` Martin Peres
2019-03-11 14:59 ` Maarten Lankhorst
2019-03-11 14:06 ` Daniel Vetter
2019-03-11 14:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t Patchwork
2019-03-11 14:12 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
2019-03-11 15:54 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
2019-03-12 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t (rev2) Patchwork
2019-03-12 12:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311133150.9868-1-arkadiusz.hiler@intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox