Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Mar 11, 2019 at 03:31:49PM +0200, Arkadiusz Hiler wrote:
> It's set up for capture and then freed but never used.
> 
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Hm, sounds a bit like a test gap, we should at least make sure no garbage
from outside of the of the visible area leaks in, even when scaling?
Testing scaling itself is a bit harder, since we have no standards for how
the hw is supposed to interpolate transitions. And with uniform color
across the entire plane all you can do is check for leaks.

Hm maybe we can at least to some basic checks, like make sure that the
uniform areas are at the right spots (but with quite a few pixels of
safety distance from the nearest transitions, for higher-order filters).

Maybe ask Jani Saarinen to add that to the list of JIRAs ...

Patch itself looks good. Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  tests/kms_plane_scaling.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 1015c80c..d408a203 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -33,7 +33,6 @@ typedef struct {
>  	int drm_fd;
>  	igt_display_t display;
>  	igt_crc_t ref_crc;
> -	igt_pipe_crc_t *pipe_crc;
>  
>  	int image_w;
>  	int image_h;
> @@ -72,8 +71,6 @@ static void cleanup_fbs(data_t *data)
>  static void cleanup_crtc(data_t *data)
>  {
>  	igt_display_reset(&data->display);
> -	igt_pipe_crc_free(data->pipe_crc);
> -	data->pipe_crc = NULL;
>  
>  	cleanup_fbs(data);
>  }
> @@ -89,9 +86,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
>  
>  	igt_output_set_pipe(output, pipe);
>  
> -	/* create the pipe_crc object for this pipe */
> -	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
> -
>  	igt_skip_on(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888,
>  						tiling));
>  
> @@ -566,7 +560,6 @@ igt_main
>  
>  	igt_fixture {
>  		data.drm_fd = drm_open_driver_master(DRIVER_INTEL | DRIVER_AMDGPU);
> -		igt_require_pipe_crc(data.drm_fd);
>  		igt_display_require(&data.display, data.drm_fd);
>  		data.devid = is_i915_device(data.drm_fd) ?
>  			intel_get_drm_devid(data.drm_fd) : 0;
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev