From: Daniel Vetter <daniel@ffwll.ch>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Do not iterate over output twice
Date: Mon, 11 Mar 2019 15:06:13 +0100 [thread overview]
Message-ID: <20190311140613.GJ2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190311133150.9868-2-arkadiusz.hiler@intel.com>
On Mon, Mar 11, 2019 at 03:31:50PM +0200, Arkadiusz Hiler wrote:
> test_plane_position already iterates over outputs using
> for_each_valid_output_on_pipe so there is no need to do that twice,
> especially with unused *output.
>
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> tests/kms_plane_multiple.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index 617054d9..7d8bc325 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -341,19 +341,15 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
> }
>
> igt_subtest_f("atomic-pipe-%s-tiling-x", kmstest_pipe_name(pipe))
> - for_each_valid_output_on_pipe(&data->display, pipe, output)
> test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_X_TILED);
>
> igt_subtest_f("atomic-pipe-%s-tiling-y", kmstest_pipe_name(pipe))
> - for_each_valid_output_on_pipe(&data->display, pipe, output)
> test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_Y_TILED);
>
> igt_subtest_f("atomic-pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
> - for_each_valid_output_on_pipe(&data->display, pipe, output)
> test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_Yf_TILED);
>
> igt_subtest_f("atomic-pipe-%s-tiling-none", kmstest_pipe_name(pipe))
> - for_each_valid_output_on_pipe(&data->display, pipe, output)
> test_plane_position(data, pipe, LOCAL_DRM_FORMAT_MOD_NONE);
> }
>
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-11 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 13:31 [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t Arkadiusz Hiler
2019-03-11 13:31 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Do not iterate over output twice Arkadiusz Hiler
2019-03-11 14:05 ` Martin Peres
2019-03-11 14:59 ` Maarten Lankhorst
2019-03-11 14:06 ` Daniel Vetter [this message]
2019-03-11 14:11 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t Patchwork
2019-03-11 14:12 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
2019-03-11 15:54 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
2019-03-12 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Rip out unused igt_pipe_crc_t (rev2) Patchwork
2019-03-12 12:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311140613.GJ2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox