Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Do not iterate over output twice

[Martin Peres <martin.peres@linux.intel.com>]

On 11/03/2019 15:31, Arkadiusz Hiler wrote:
> test_plane_position already iterates over outputs using
> for_each_valid_output_on_pipe so there is no need to do that twice,
> especially with unused *output.
> 
> Cc: Mika Kahola <mika.kahola@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>

Reviewed-by: Martin Peres <martin.peres@linux.intel.com>

> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> ---
>  tests/kms_plane_multiple.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index 617054d9..7d8bc325 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -341,19 +341,15 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
>  	}
>  
>  	igt_subtest_f("atomic-pipe-%s-tiling-x", kmstest_pipe_name(pipe))
> -		for_each_valid_output_on_pipe(&data->display, pipe, output)

test_plane_position is still using for_each_valid_output_on_pipe instead
of for_each_pipe_with_single_output, unless we really expect the
connectors to matter here?

If not (which I assume is true), it would be good to drop the usage of
for_each_valid_output_on_pipe for crc-testing and replace all occurences
with for_each_pipe_with_single_output. This should speed up KMS testing
on the machines with 2+ screens attached.

Martin

>  			test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_X_TILED);
>  
>  	igt_subtest_f("atomic-pipe-%s-tiling-y", kmstest_pipe_name(pipe))
> -		for_each_valid_output_on_pipe(&data->display, pipe, output)
>  			test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_Y_TILED);
>  
>  	igt_subtest_f("atomic-pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
> -		for_each_valid_output_on_pipe(&data->display, pipe, output)
>  			test_plane_position(data, pipe, LOCAL_I915_FORMAT_MOD_Yf_TILED);
>  
>  	igt_subtest_f("atomic-pipe-%s-tiling-none", kmstest_pipe_name(pipe))
> -		for_each_valid_output_on_pipe(&data->display, pipe, output)
>  			test_plane_position(data, pipe, LOCAL_DRM_FORMAT_MOD_NONE);
>  }
>  
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev