public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] kms_ccs: Add the missing '\n' for igt_require_f
@ 2019-08-06 21:02 Chris Wilson
  2019-08-06 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-08-06 21:02 UTC (permalink / raw)
  To: igt-dev; +Cc: petri.latvala

Currently the runner sees

Starting subtest: pipe-C-bad-aux-stride
Test requirement not met in function test_output, file ../tests/kms_ccs.c:324:
Test requirement: valid_tests > 0
CCS not supported, skippingSubtest pipe-C-bad-aux-stride: SKIP (0.330s)

and manages to explode.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_ccs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index 6cd30aad8..1ce66cdec 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -321,7 +321,7 @@ static int __test_output(data_t *data)
 static void test_output(data_t *data)
 {
 	int valid_tests = __test_output(data);
-	igt_require_f(valid_tests > 0, "CCS not supported, skipping");
+	igt_require_f(valid_tests > 0, "CCS not supported, skipping\n");
 }
 
 static data_t data;
@@ -373,7 +373,8 @@ igt_main
 				valid_tests += __test_output(&data);
 			}
 
-			igt_require_f(valid_tests > 0, "CCS not supported, skipping");
+			igt_require_f(valid_tests > 0,
+				      "CCS not supported, skipping\n");
 		}
 
 		data.plane = NULL;
-- 
2.23.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-13  8:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 21:02 [igt-dev] [PATCH i-g-t] kms_ccs: Add the missing '\n' for igt_require_f Chris Wilson
2019-08-06 21:51 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-08-07  8:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-08-13  8:00 ` [igt-dev] [PATCH i-g-t] " Ser, Simon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox