public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] test longer than 32k strides.
@ 2019-09-23 10:40 Juha-Pekka Heikkila
  2019-09-23 10:40 ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add over 32k HW stride tests Juha-Pekka Heikkila
                   ` (7 more replies)
  0 siblings, 8 replies; 15+ messages in thread
From: Juha-Pekka Heikkila @ 2019-09-23 10:40 UTC (permalink / raw)
  To: igt-dev

This test goes along with this kernel patch:
https://patchwork.freedesktop.org/series/67077/

Juha-Pekka Heikkila (1):
  tests/kms_big_fb: Add over 32k HW stride tests

 tests/kms_big_fb.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 103 insertions(+)

-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add max HW stride length tests
@ 2020-03-19 18:03 Juha-Pekka Heikkila
  0 siblings, 0 replies; 15+ messages in thread
From: Juha-Pekka Heikkila @ 2020-03-19 18:03 UTC (permalink / raw)
  To: igt-dev

Test maximum HW stride lenghts. On Intel HW from gen5 up to
Gen10 maximum HW stride lenght is 32K. On Gen11 when using
64bpp formats strides can reach up to 64k. These test try
exact maximum HW strides so gtt remapping will not come in
play.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_big_fb.c | 86 ++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 83 insertions(+), 3 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index eb144da9..cf858a60 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -48,6 +48,9 @@ typedef struct {
 	igt_render_copyfunc_t render_copy;
 	drm_intel_bufmgr *bufmgr;
 	struct intel_batchbuffer *batch;
+	bool max_hw_stride_test;
+	int hw_stride;
+	int max_hw_fb_width;
 } data_t;
 
 static void init_buf(data_t *data,
@@ -163,9 +166,6 @@ static void max_fb_size(data_t *data, int *width, int *height,
 	uint64_t size;
 	int i = 0;
 
-	*width = data->max_fb_width;
-	*height = data->max_fb_height;
-
 	/* max fence stride is only 8k bytes on gen3 */
 	if (intel_gen(data->devid) < 4 &&
 	    format == DRM_FORMAT_XRGB8888)
@@ -419,6 +419,14 @@ static bool test_pipe(data_t *data)
 
 static void test_scanout(data_t *data)
 {
+	if (data->max_hw_stride_test) {
+		data->big_fb_width = data->max_hw_fb_width;
+		data->big_fb_height = data->max_hw_fb_width;
+	} else {
+		data->big_fb_width = data->max_fb_width;
+		data->big_fb_height = data->max_fb_height;
+	}
+
 	max_fb_size(data, &data->big_fb_width, &data->big_fb_height,
 		    data->format, data->modifier);
 
@@ -570,6 +578,28 @@ test_addfb(data_t *data)
 	gem_close(data->drm_fd, bo);
 }
 
+/*
+ * TODO: adapt i9xx_plane_max_stride(..) here from intel_display.c
+ * in kernel sources to support older gen for max hw stride length
+ * testing.
+ */
+static void
+set_max_hw_stride(data_t *data)
+{
+	if (intel_gen(data->devid) < 11) {
+		data->hw_stride = 32768;
+	} else {
+		switch (data->modifier) {
+		case DRM_FORMAT_MOD_LINEAR:
+			data->hw_stride = 65536-64;
+			break;
+		default:
+			data->hw_stride = 65536;
+			break;
+		}
+	}
+}
+
 static data_t data;
 
 static const struct {
@@ -649,6 +679,8 @@ igt_main
 
 		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
 		data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
+
+		data.max_hw_stride_test = false;
 	}
 
 	/*
@@ -704,6 +736,54 @@ igt_main
 		}
 	}
 
+	data.max_hw_stride_test = true;
+	/*
+	 * Run max hw stride length tests on gen5 and later.
+	 */
+	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
+		data.modifier = modifiers[i].modifier;
+
+		set_max_hw_stride(&data);
+
+		for (int j = 0; j < ARRAY_SIZE(formats); j++) {
+			/*
+			 * try only those formats which can show full lenght. 8K is
+			 * the magic maximum pixels in Intel HW. Here 32K is used
+			 * to have CI test results consistent for all platforms,
+			 * 32K is smallest number possbily coming to hw_stride
+			 * from above if{}else{}..
+			 */
+			if (32768 / (formats[j].bpp >> 3) > 8192)
+				continue;
+
+			data.format = formats[j].format;
+
+			for (int k = 0; k < ARRAY_SIZE(rotations); k++) {
+				data.rotation = rotations[k].rotation;
+				/*
+				 * Seems any format currently coming here will not support
+				 * 90/270 rotations so skip those rotations.
+				 */
+				if (data.rotation&(IGT_ROTATION_90|IGT_ROTATION_270))
+					continue;
+
+				igt_subtest_f("%s-max-hw-stride-%dbpp-rotate-%d", modifiers[i].name,
+					      formats[j].bpp, rotations[k].angle) {
+					igt_require(intel_gen(intel_get_drm_devid(data.drm_fd)) >=5);
+					data.max_hw_fb_width = data.hw_stride / (formats[j].bpp >> 3);
+					igt_require(data.format == DRM_FORMAT_C8 ||
+						    igt_fb_supported_format(data.format));
+					igt_require(igt_display_has_format_mod(&data.display, data.format, data.modifier));
+					test_scanout(&data);
+				}
+			}
+
+			igt_fixture
+				cleanup_fb(&data);
+		}
+	}
+	data.max_hw_stride_test = false;
+
 	igt_fixture {
 		igt_display_fini(&data.display);
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add max HW stride length tests
@ 2020-03-19 19:36 Juha-Pekka Heikkila
  0 siblings, 0 replies; 15+ messages in thread
From: Juha-Pekka Heikkila @ 2020-03-19 19:36 UTC (permalink / raw)
  To: igt-dev

Test maximum HW stride lenghts. On Intel HW from gen5 up to
Gen10 maximum HW stride lenght is 32K. On Gen11 when using
64bpp formats strides can reach up to 64k. These test try
exact maximum HW strides so gtt remapping will not come in
play.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_big_fb.c | 87 ++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 84 insertions(+), 3 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index eb144da9..b825362e 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -48,6 +48,9 @@ typedef struct {
 	igt_render_copyfunc_t render_copy;
 	drm_intel_bufmgr *bufmgr;
 	struct intel_batchbuffer *batch;
+	bool max_hw_stride_test;
+	int hw_stride;
+	int max_hw_fb_width;
 } data_t;
 
 static void init_buf(data_t *data,
@@ -163,9 +166,6 @@ static void max_fb_size(data_t *data, int *width, int *height,
 	uint64_t size;
 	int i = 0;
 
-	*width = data->max_fb_width;
-	*height = data->max_fb_height;
-
 	/* max fence stride is only 8k bytes on gen3 */
 	if (intel_gen(data->devid) < 4 &&
 	    format == DRM_FORMAT_XRGB8888)
@@ -419,6 +419,14 @@ static bool test_pipe(data_t *data)
 
 static void test_scanout(data_t *data)
 {
+	if (data->max_hw_stride_test) {
+		data->big_fb_width = data->max_hw_fb_width;
+		data->big_fb_height = data->max_hw_fb_width;
+	} else {
+		data->big_fb_width = data->max_fb_width;
+		data->big_fb_height = data->max_fb_height;
+	}
+
 	max_fb_size(data, &data->big_fb_width, &data->big_fb_height,
 		    data->format, data->modifier);
 
@@ -570,6 +578,28 @@ test_addfb(data_t *data)
 	gem_close(data->drm_fd, bo);
 }
 
+/*
+ * TODO: adapt i9xx_plane_max_stride(..) here from intel_display.c
+ * in kernel sources to support older gen for max hw stride length
+ * testing.
+ */
+static void
+set_max_hw_stride(data_t *data)
+{
+	if (intel_gen(data->devid) < 11) {
+		data->hw_stride = 32768;
+	} else {
+		switch (data->modifier) {
+		case DRM_FORMAT_MOD_LINEAR:
+			data->hw_stride = 65536-64;
+			break;
+		default:
+			data->hw_stride = 65536;
+			break;
+		}
+	}
+}
+
 static data_t data;
 
 static const struct {
@@ -649,6 +679,8 @@ igt_main
 
 		data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
 		data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
+
+		data.max_hw_stride_test = false;
 	}
 
 	/*
@@ -704,6 +736,55 @@ igt_main
 		}
 	}
 
+	data.max_hw_stride_test = true;
+	/*
+	 * Run max hw stride length tests on gen5 and later.
+	 */
+	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
+		data.modifier = modifiers[i].modifier;
+
+		set_max_hw_stride(&data);
+
+		for (int j = 0; j < ARRAY_SIZE(formats); j++) {
+			/*
+			 * try only those formats which can show full lenght. 8K is
+			 * the magic maximum pixels in Intel HW. Here 32K is used
+			 * to have CI test results consistent for all platforms,
+			 * 32K is smallest number possbily coming to hw_stride
+			 * from above if{}else{}..
+			 */
+			if (32768 / (formats[j].bpp >> 3) > 8192)
+				continue;
+
+			data.format = formats[j].format;
+
+			for (int k = 0; k < ARRAY_SIZE(rotations); k++) {
+				data.rotation = rotations[k].rotation;
+				/*
+				 * Seems any format currently coming here will not support
+				 * 90/270 rotations so skip those rotations.
+				 */
+				if (data.rotation&(IGT_ROTATION_90|IGT_ROTATION_270))
+					continue;
+
+				igt_subtest_f("%s-max-hw-stride-%dbpp-rotate-%d", modifiers[i].name,
+					      formats[j].bpp, rotations[k].angle) {
+					igt_describe("test maximum hardware supported stride length for given bpp and modifiers.");
+					igt_require(intel_gen(intel_get_drm_devid(data.drm_fd)) >=5);
+					data.max_hw_fb_width = data.hw_stride / (formats[j].bpp >> 3);
+					igt_require(data.format == DRM_FORMAT_C8 ||
+						    igt_fb_supported_format(data.format));
+					igt_require(igt_display_has_format_mod(&data.display, data.format, data.modifier));
+					test_scanout(&data);
+				}
+			}
+
+			igt_fixture
+				cleanup_fb(&data);
+		}
+	}
+	data.max_hw_stride_test = false;
+
 	igt_fixture {
 		igt_display_fini(&data.display);
 
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-03-19 19:37 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-23 10:40 [igt-dev] [PATCH i-g-t] test longer than 32k strides Juha-Pekka Heikkila
2019-09-23 10:40 ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add over 32k HW stride tests Juha-Pekka Heikkila
2019-09-23 12:43   ` Ville Syrjälä
2019-09-27 13:43     ` Juha-Pekka Heikkila
2019-09-27 13:50       ` Ville Syrjälä
     [not found]   ` <1571904804-2248-1-git-send-email-juhapekka.heikkila@gmail.com>
2019-10-24 13:55     ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add max HW stride length tests Ville Syrjälä
2019-09-23 11:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Add over 32k HW stride tests Patchwork
2019-09-23 11:45 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-09-23 13:01 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Add over 32k HW stride tests (rev2) Patchwork
2019-09-23 17:18 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_big_fb: Add over 32k HW stride tests Patchwork
2019-10-24  9:19 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Add over 32k HW stride tests (rev3) Patchwork
2019-10-24  9:35 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-10-25 10:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-03-19 18:03 [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Add max HW stride length tests Juha-Pekka Heikkila
2020-03-19 19:36 Juha-Pekka Heikkila

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox