* [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc @ 2020-02-16 17:51 Anshuman Gupta 2020-02-16 17:51 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures Anshuman Gupta 0 siblings, 1 reply; 5+ messages in thread From: Anshuman Gupta @ 2020-02-16 17:51 UTC (permalink / raw) To: igt-dev Anshuman Gupta (2): tests/i915_pm_dc: Dump power_domain_info on DC test failures tests/i915_pm_dc: psr required only for dc*-psr tests tests/i915/i915_pm_dc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures 2020-02-16 17:51 [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc Anshuman Gupta @ 2020-02-16 17:51 ` Anshuman Gupta 0 siblings, 0 replies; 5+ messages in thread From: Anshuman Gupta @ 2020-02-16 17:51 UTC (permalink / raw) To: igt-dev Dump i915_power_domain_info debugfs attribute on DC state test failures, it will help to identify culprit, which causes non zero refcount for "DC off" power well. Cc: Animesh Manna <animesh.manna@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- tests/i915/i915_pm_dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index afcc10bc..4bca8559 100644 --- a/tests/i915/i915_pm_dc.c +++ b/tests/i915/i915_pm_dc.c @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, int dc_flag, int prev_dc_count) static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t prev_dc_count) { char tmp[64]; + char file[64] = "i915_power_domain_info"; snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? "DC3CO" : (dc_flag & CHECK_DC5 ? "DC5" : "DC6")); igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, prev_dc_count), - "%s state is not achieved\n", tmp); + "%s state is not achieved\n%s:\n%s\n", + tmp, file, igt_sysfs_get(debugfs_fd, file)); } static void setup_videoplayback(data_t *data) -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc @ 2020-02-16 18:00 Anshuman Gupta 2020-02-16 18:00 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures Anshuman Gupta 0 siblings, 1 reply; 5+ messages in thread From: Anshuman Gupta @ 2020-02-16 18:00 UTC (permalink / raw) To: igt-dev *** BLURB HERE *** Anshuman Gupta (2): tests/i915_pm_dc: Dump power_domain_info on DC test failures tests/i915_pm_dc: psr required only for dc*-psr tests tests/i915/i915_pm_dc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures 2020-02-16 18:00 [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc Anshuman Gupta @ 2020-02-16 18:00 ` Anshuman Gupta 2020-02-18 19:03 ` Souza, Jose 0 siblings, 1 reply; 5+ messages in thread From: Anshuman Gupta @ 2020-02-16 18:00 UTC (permalink / raw) To: igt-dev Dump i915_power_domain_info debugfs attribute on DC state test failures, it will help to identify culprit, which causes non zero refcount for "DC off" power well. Cc: Animesh Manna <animesh.manna@intel.com> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- tests/i915/i915_pm_dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index afcc10bc..4bca8559 100644 --- a/tests/i915/i915_pm_dc.c +++ b/tests/i915/i915_pm_dc.c @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, int dc_flag, int prev_dc_count) static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t prev_dc_count) { char tmp[64]; + char file[64] = "i915_power_domain_info"; snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? "DC3CO" : (dc_flag & CHECK_DC5 ? "DC5" : "DC6")); igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, prev_dc_count), - "%s state is not achieved\n", tmp); + "%s state is not achieved\n%s:\n%s\n", + tmp, file, igt_sysfs_get(debugfs_fd, file)); } static void setup_videoplayback(data_t *data) -- 2.24.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures 2020-02-16 18:00 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures Anshuman Gupta @ 2020-02-18 19:03 ` Souza, Jose 2020-02-19 3:38 ` Anshuman Gupta 0 siblings, 1 reply; 5+ messages in thread From: Souza, Jose @ 2020-02-18 19:03 UTC (permalink / raw) To: igt-dev@lists.freedesktop.org, Gupta, Anshuman On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote: > Dump i915_power_domain_info debugfs attribute on DC state > test failures, it will help to identify culprit, which > causes non zero refcount for "DC off" power well. > > Cc: Animesh Manna <animesh.manna@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > tests/i915/i915_pm_dc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c > index afcc10bc..4bca8559 100644 > --- a/tests/i915/i915_pm_dc.c > +++ b/tests/i915/i915_pm_dc.c > @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, > int dc_flag, int prev_dc_count) > static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t > prev_dc_count) > { > char tmp[64]; > + char file[64] = "i915_power_domain_info"; > > snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? > "DC3CO" : > (dc_flag & CHECK_DC5 ? "DC5" : "DC6")); > igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, > prev_dc_count), > - "%s state is not achieved\n", tmp); > + "%s state is not achieved\n%s:\n%s\n", > + tmp, file, igt_sysfs_get(debugfs_fd, file)); > } You are leaking the return of igt_sysfs_get() also why add the variable file? > > static void setup_videoplayback(data_t *data) _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures 2020-02-18 19:03 ` Souza, Jose @ 2020-02-19 3:38 ` Anshuman Gupta 0 siblings, 0 replies; 5+ messages in thread From: Anshuman Gupta @ 2020-02-19 3:38 UTC (permalink / raw) To: Souza, Jose; +Cc: igt-dev@lists.freedesktop.org On 2020-02-19 at 00:33:09 +0530, Souza, Jose wrote: > On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote: > > Dump i915_power_domain_info debugfs attribute on DC state > > test failures, it will help to identify culprit, which > > causes non zero refcount for "DC off" power well. > > > > Cc: Animesh Manna <animesh.manna@intel.com> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > --- > > tests/i915/i915_pm_dc.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c > > index afcc10bc..4bca8559 100644 > > --- a/tests/i915/i915_pm_dc.c > > +++ b/tests/i915/i915_pm_dc.c > > @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, > > int dc_flag, int prev_dc_count) > > static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t > > prev_dc_count) > > { > > char tmp[64]; > > + char file[64] = "i915_power_domain_info"; > > > > snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? > > "DC3CO" : > > (dc_flag & CHECK_DC5 ? "DC5" : "DC6")); > > igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, > > prev_dc_count), > > - "%s state is not achieved\n", tmp); > > + "%s state is not achieved\n%s:\n%s\n", > > + tmp, file, igt_sysfs_get(debugfs_fd, file)); > > } > > You are leaking the return of igt_sysfs_get() also why add the variable > file? Thanks for review, i will fix the leak and will take a macro instead of file. Thanks, Anshuman Gupta. > > > > > static void setup_videoplayback(data_t *data) _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-19 3:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-02-16 17:51 [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc Anshuman Gupta 2020-02-16 17:51 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures Anshuman Gupta -- strict thread matches above, loose matches on Subject: below -- 2020-02-16 18:00 [igt-dev] [PATCH i-g-t 0/2] DC states IGT misc Anshuman Gupta 2020-02-16 18:00 ` [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures Anshuman Gupta 2020-02-18 19:03 ` Souza, Jose 2020-02-19 3:38 ` Anshuman Gupta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox