[igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures

[igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures

[Anshuman Gupta]

Dump i915_power_domain_info debugfs attribute on DC state
test failures, it will help to identify culprit, which
causes non zero refcount for "DC off" power well.

Cc: Animesh Manna <animesh.manna@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_dc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index afcc10bc..4bca8559 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, int dc_flag, int prev_dc_count)
 static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t prev_dc_count)
 {
 	char tmp[64];
+	char file[64] = "i915_power_domain_info";
 
 	snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? "DC3CO" :
 		(dc_flag & CHECK_DC5 ? "DC5" : "DC6"));
 	igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, prev_dc_count),
-		     "%s state is not achieved\n", tmp);
+		     "%s state is not achieved\n%s:\n%s\n",
+		     tmp, file, igt_sysfs_get(debugfs_fd, file));
 }
 
 static void setup_videoplayback(data_t *data)
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 0/2] DC states IGT misc

[Anshuman Gupta]

*** BLURB HERE ***

Anshuman Gupta (2):
  tests/i915_pm_dc: Dump power_domain_info on DC test failures
  tests/i915_pm_dc: psr required only for dc*-psr tests

 tests/i915/i915_pm_dc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures

[Anshuman Gupta]

Dump i915_power_domain_info debugfs attribute on DC state
test failures, it will help to identify culprit, which
causes non zero refcount for "DC off" power well.

Cc: Animesh Manna <animesh.manna@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_dc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index afcc10bc..4bca8559 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd, int dc_flag, int prev_dc_count)
 static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t prev_dc_count)
 {
 	char tmp[64];
+	char file[64] = "i915_power_domain_info";
 
 	snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ? "DC3CO" :
 		(dc_flag & CHECK_DC5 ? "DC5" : "DC6"));
 	igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag, prev_dc_count),
-		     "%s state is not achieved\n", tmp);
+		     "%s state is not achieved\n%s:\n%s\n",
+		     tmp, file, igt_sysfs_get(debugfs_fd, file));
 }
 
 static void setup_videoplayback(data_t *data)
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: psr required only for dc*-psr tests

[Anshuman Gupta]

DPMS igt tests were skipping for non-psr panels due to
psr_sink_support sink check added to igt_fixture() at
commit <6cbe6af372a01be63121056679d540436ffd0b64>.
DPMS dc state igt test don't require psr_sink_support, as it
validates DC states with all display being DPMS off.
Removing the psr sink check from igt_fixture and adding
it only for dc*- psr tests.

Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_dc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index 4bca8559..4c34ff9d 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -395,7 +395,6 @@ int main(int argc, char *argv[])
 		igt_require(igt_setup_runtime_pm(data.drm_fd));
 		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
 		igt_display_require(&data.display, data.drm_fd);
-		igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
 		/* Make sure our Kernel supports MSR and the module is loaded */
 		igt_require(igt_kmod_load("msr", NULL) == 0);
 
@@ -415,6 +414,7 @@ int main(int argc, char *argv[])
 	igt_subtest("dc5-psr") {
 		data.op_psr_mode = PSR_MODE_1;
 		psr_enable(data.debugfs_fd, data.op_psr_mode);
+		igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
 		test_dc_state_psr(&data, CHECK_DC5);
 	}
 
@@ -423,6 +423,7 @@ int main(int argc, char *argv[])
 	igt_subtest("dc6-psr") {
 		data.op_psr_mode = PSR_MODE_1;
 		psr_enable(data.debugfs_fd, data.op_psr_mode);
+		igt_require(psr_sink_support(data.debugfs_fd, PSR_MODE_1));
 		igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
 			      "PC8+ residencies not supported\n");
 		test_dc_state_psr(&data, CHECK_DC6);
-- 
2.24.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for DC states IGT misc (rev2)

[Patchwork]

== Series Details ==

Series: DC states IGT misc (rev2)
URL   : https://patchwork.freedesktop.org/series/73509/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7951 -> IGTPW_4161
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/index.html

Known issues
------------

  Here are the changes found in IGTPW_4161 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-cml-s:           [DMESG-FAIL][1] ([i915#877]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/fi-cml-s/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@dp-crc-fast:
    - fi-cml-u2:          [FAIL][3] ([i915#262]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html

  * igt@kms_chamelium@dp-edid-read:
    - fi-cml-u2:          [FAIL][5] ([i915#217] / [i915#976]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html

  
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877
  [i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976


Participating hosts (41 -> 44)
------------------------------

  Additional (7): fi-kbl-soraka fi-byt-j1900 fi-hsw-peppy fi-glk-dsi fi-kbl-7500u fi-cfl-8109u fi-skl-lmem 
  Missing    (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5444 -> IGTPW_4161

  CI-20190529: 20190529
  CI_DRM_7951: 3e7954595748cb1671c02a97069f137a3f6b6d72 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4161: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/index.html
  IGT_5444: c46bae259d427f53fcfcd5f05de0181a9e82d6fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: psr required only for dc*-psr tests

[Souza, Jose]

On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote:
> DPMS igt tests were skipping for non-psr panels due to
> psr_sink_support sink check added to igt_fixture() at
> commit <6cbe6af372a01be63121056679d540436ffd0b64>.
> DPMS dc state igt test don't require psr_sink_support, as it
> validates DC states with all display being DPMS off.
> Removing the psr sink check from igt_fixture and adding
> it only for dc*- psr tests.

Makes sense, just missing the igt_require(psr) in dc3co-vpb-simulation.

> 
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_dc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> index 4bca8559..4c34ff9d 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -395,7 +395,6 @@ int main(int argc, char *argv[])
>  		igt_require(igt_setup_runtime_pm(data.drm_fd));
>  		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
>  		igt_display_require(&data.display, data.drm_fd);
> -		igt_require(psr_sink_support(data.debugfs_fd,
> PSR_MODE_1));
>  		/* Make sure our Kernel supports MSR and the module is
> loaded */
>  		igt_require(igt_kmod_load("msr", NULL) == 0);
>  
> @@ -415,6 +414,7 @@ int main(int argc, char *argv[])
>  	igt_subtest("dc5-psr") {
>  		data.op_psr_mode = PSR_MODE_1;
>  		psr_enable(data.debugfs_fd, data.op_psr_mode);
> +		igt_require(psr_sink_support(data.debugfs_fd,
> PSR_MODE_1));
>  		test_dc_state_psr(&data, CHECK_DC5);
>  	}
>  
> @@ -423,6 +423,7 @@ int main(int argc, char *argv[])
>  	igt_subtest("dc6-psr") {
>  		data.op_psr_mode = PSR_MODE_1;
>  		psr_enable(data.debugfs_fd, data.op_psr_mode);
> +		igt_require(psr_sink_support(data.debugfs_fd,
> PSR_MODE_1));
>  		igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.
> msr_fd),
>  			      "PC8+ residencies not supported\n");
>  		test_dc_state_psr(&data, CHECK_DC6);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures

[Souza, Jose]

On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote:
> Dump i915_power_domain_info debugfs attribute on DC state
> test failures, it will help to identify culprit, which
> causes non zero refcount for "DC off" power well.
> 
> Cc: Animesh Manna <animesh.manna@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_dc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> index afcc10bc..4bca8559 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd,
> int dc_flag, int prev_dc_count)
>  static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t
> prev_dc_count)
>  {
>  	char tmp[64];
> +	char file[64] = "i915_power_domain_info";
>  
>  	snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ?
> "DC3CO" :
>  		(dc_flag & CHECK_DC5 ? "DC5" : "DC6"));
>  	igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag,
> prev_dc_count),
> -		     "%s state is not achieved\n", tmp);
> +		     "%s state is not achieved\n%s:\n%s\n",
> +		     tmp, file, igt_sysfs_get(debugfs_fd, file));
>  }

You are leaking the return of igt_sysfs_get() also why add the variable
file? 

>  
>  static void setup_videoplayback(data_t *data)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for DC states IGT misc (rev2)

[Patchwork]

== Series Details ==

Series: DC states IGT misc (rev2)
URL   : https://patchwork.freedesktop.org/series/73509/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7951_full -> IGTPW_4161_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/index.html

Known issues
------------

  Here are the changes found in IGTPW_4161_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@bcs0-s3:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([i915#180]) +5 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl7/igt@gem_ctx_isolation@bcs0-s3.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl4/igt@gem_ctx_isolation@bcs0-s3.html

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#110841])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb6/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_exec_schedule@preempt-queue-chain-bsd:
    - shard-iclb:         [PASS][5] -> [SKIP][6] ([fdo#112146])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb8/igt@gem_exec_schedule@preempt-queue-chain-bsd.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb1/igt@gem_exec_schedule@preempt-queue-chain-bsd.html

  * igt@gen7_exec_parse@basic-offset:
    - shard-hsw:          [PASS][7] -> [FAIL][8] ([i915#694]) +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-hsw1/igt@gen7_exec_parse@basic-offset.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-hsw1/igt@gen7_exec_parse@basic-offset.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-iclb:         [PASS][9] -> [FAIL][10] ([i915#454])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html

  * igt@kms_color@pipe-c-ctm-max:
    - shard-kbl:          [PASS][11] -> [FAIL][12] ([i915#168])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl3/igt@kms_color@pipe-c-ctm-max.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl1/igt@kms_color@pipe-c-ctm-max.html
    - shard-apl:          [PASS][13] -> [FAIL][14] ([i915#168])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl7/igt@kms_color@pipe-c-ctm-max.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl7/igt@kms_color@pipe-c-ctm-max.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#79])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-glk5/igt@kms_flip@flip-vs-expired-vblank.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-hsw:          [PASS][17] -> [INCOMPLETE][18] ([i915#61])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-hsw7/igt@kms_flip@flip-vs-suspend.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-hsw5/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - shard-kbl:          [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +2 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [PASS][21] -> [SKIP][22] ([fdo#109441]) +2 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb3/igt@kms_psr@psr2_no_drrs.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][23] -> [FAIL][24] ([i915#31])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl7/igt@kms_setmode@basic.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl3/igt@kms_setmode@basic.html

  * igt@perf_pmu@busy-accuracy-98-vcs1:
    - shard-iclb:         [PASS][25] -> [SKIP][26] ([fdo#112080]) +11 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb4/igt@perf_pmu@busy-accuracy-98-vcs1.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb6/igt@perf_pmu@busy-accuracy-98-vcs1.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [PASS][27] -> [SKIP][28] ([fdo#109276]) +18 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb1/igt@prime_busy@hang-bsd2.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb6/igt@prime_busy@hang-bsd2.html

  
#### Possible fixes ####

  * {igt@gem_ctx_persistence@close-replace-race}:
    - shard-apl:          [FAIL][29] ([i915#1241]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl2/igt@gem_ctx_persistence@close-replace-race.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl2/igt@gem_ctx_persistence@close-replace-race.html

  * {igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd}:
    - shard-tglb:         [INCOMPLETE][31] -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-tglb1/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html

  * {igt@gem_ctx_persistence@legacy-engines-mixed-process@render}:
    - shard-tglb:         [FAIL][33] ([i915#679]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-tglb8/igt@gem_ctx_persistence@legacy-engines-mixed-process@render.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-tglb1/igt@gem_ctx_persistence@legacy-engines-mixed-process@render.html

  * igt@gem_exec_balancer@hang:
    - shard-iclb:         [FAIL][35] -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb4/igt@gem_exec_balancer@hang.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb5/igt@gem_exec_balancer@hang.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][37] ([fdo#112146]) -> [PASS][38] +5 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_partial_pwrite_pread@write-uncached:
    - shard-hsw:          [FAIL][39] ([i915#694]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-hsw2/igt@gem_partial_pwrite_pread@write-uncached.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-hsw1/igt@gem_partial_pwrite_pread@write-uncached.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-snb:          [DMESG-WARN][41] ([fdo#111870] / [i915#478]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-snb5/igt@gem_userptr_blits@sync-unmap.html

  * igt@i915_pm_dc@dc5-dpms:
    - shard-glk:          [SKIP][43] ([fdo#109271]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-glk4/igt@i915_pm_dc@dc5-dpms.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-glk8/igt@i915_pm_dc@dc5-dpms.html
    - shard-apl:          [SKIP][45] ([fdo#109271]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl3/igt@i915_pm_dc@dc5-dpms.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl8/igt@i915_pm_dc@dc5-dpms.html
    - shard-kbl:          [SKIP][47] ([fdo#109271]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl2/igt@i915_pm_dc@dc5-dpms.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl2/igt@i915_pm_dc@dc5-dpms.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
    - shard-apl:          [FAIL][49] ([i915#54]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
    - shard-kbl:          [FAIL][51] ([i915#54]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-128x128-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [INCOMPLETE][53] ([fdo#103665]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
    - shard-apl:          [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][57] ([i915#79]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-kbl:          [FAIL][59] ([i915#79]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
    - shard-glk:          [FAIL][61] ([i915#49]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-glk5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html

  * igt@kms_psr@psr2_sprite_mmap_gtt:
    - shard-iclb:         [SKIP][63] ([fdo#109441]) -> [PASS][64] +3 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_gtt.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [DMESG-WARN][65] ([i915#180]) -> [PASS][66] +7 similar issues
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf@gen12-mi-rpc:
    - shard-tglb:         [TIMEOUT][67] ([fdo#112271] / [i915#1085]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-tglb1/igt@perf@gen12-mi-rpc.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-tglb7/igt@perf@gen12-mi-rpc.html

  * igt@perf@short-reads:
    - shard-hsw:          [TIMEOUT][69] ([fdo#112271] / [i915#51]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-hsw5/igt@perf@short-reads.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-hsw4/igt@perf@short-reads.html

  * igt@perf_pmu@init-busy-vcs1:
    - shard-iclb:         [SKIP][71] ([fdo#112080]) -> [PASS][72] +13 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb3/igt@perf_pmu@init-busy-vcs1.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb2/igt@perf_pmu@init-busy-vcs1.html

  * igt@prime_mmap_coherency@read:
    - shard-hsw:          [FAIL][73] ([i915#914]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-hsw4/igt@prime_mmap_coherency@read.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-hsw7/igt@prime_mmap_coherency@read.html

  * igt@prime_vgem@fence-wait-bsd2:
    - shard-iclb:         [SKIP][75] ([fdo#109276]) -> [PASS][76] +17 similar issues
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [FAIL][77] ([IGT#28]) -> [SKIP][78] ([fdo#112080])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb3/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_ctx_isolation@vcs1-nonpriv-switch:
    - shard-iclb:         [SKIP][79] ([fdo#112080]) -> [FAIL][80] ([IGT#28])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-iclb2/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html

  * igt@gem_tiled_blits@normal:
    - shard-hsw:          [FAIL][81] ([i915#694]) -> [FAIL][82] ([i915#818])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-hsw8/igt@gem_tiled_blits@normal.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-hsw4/igt@gem_tiled_blits@normal.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-kbl:          [SKIP][83] ([fdo#109271]) -> [FAIL][84] ([i915#454])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-kbl2/igt@i915_pm_dc@dc6-dpms.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-kbl2/igt@i915_pm_dc@dc6-dpms.html
    - shard-tglb:         [SKIP][85] ([i915#468]) -> [FAIL][86] ([i915#454])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html

  * igt@i915_pm_rpm@universal-planes-dpms:
    - shard-snb:          [SKIP][87] ([fdo#109271]) -> [INCOMPLETE][88] ([i915#82])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7951/shard-snb1/igt@i915_pm_rpm@universal-planes-dpms.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/shard-snb2/igt@i915_pm_rpm@universal-planes-dpms.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
  [i915#1241]: https://gitlab.freedesktop.org/drm/intel/issues/1241
  [i915#168]: https://gitlab.freedesktop.org/drm/intel/issues/168
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
  [i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
  [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
  [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
  [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
  [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
  [i915#914]: https://gitlab.freedesktop.org/drm/intel/issues/914


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5444 -> IGTPW_4161
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_7951: 3e7954595748cb1671c02a97069f137a3f6b6d72 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4161: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/index.html
  IGT_5444: c46bae259d427f53fcfcd5f05de0181a9e82d6fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4161/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: psr required only for dc*-psr tests

[Anshuman Gupta]

On 2020-02-19 at 00:25:55 +0530, Souza, Jose wrote:
> On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote:
> > DPMS igt tests were skipping for non-psr panels due to
> > psr_sink_support sink check added to igt_fixture() at
> > commit <6cbe6af372a01be63121056679d540436ffd0b64>.
> > DPMS dc state igt test don't require psr_sink_support, as it
> > validates DC states with all display being DPMS off.
> > Removing the psr sink check from igt_fixture and adding
> > it only for dc*- psr tests.
> 
> Makes sense, just missing the igt_require(psr) in dc3co-vpb-simulation.
Thanks for review, dc3co-vpb-simulation already had igt_require_f
for psr_wait_entry, so do we require psr sink check over there ?
Please correct me if i am wrong here.
Thanks,
Anshuman Gupta. 
> 
> > 
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> >  tests/i915/i915_pm_dc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> > index 4bca8559..4c34ff9d 100644
> > --- a/tests/i915/i915_pm_dc.c
> > +++ b/tests/i915/i915_pm_dc.c
> > @@ -395,7 +395,6 @@ int main(int argc, char *argv[])
> >  		igt_require(igt_setup_runtime_pm(data.drm_fd));
> >  		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
> >  		igt_display_require(&data.display, data.drm_fd);
> > -		igt_require(psr_sink_support(data.debugfs_fd,
> > PSR_MODE_1));
> >  		/* Make sure our Kernel supports MSR and the module is
> > loaded */
> >  		igt_require(igt_kmod_load("msr", NULL) == 0);
> >  
> > @@ -415,6 +414,7 @@ int main(int argc, char *argv[])
> >  	igt_subtest("dc5-psr") {
> >  		data.op_psr_mode = PSR_MODE_1;
> >  		psr_enable(data.debugfs_fd, data.op_psr_mode);
> > +		igt_require(psr_sink_support(data.debugfs_fd,
> > PSR_MODE_1));
> >  		test_dc_state_psr(&data, CHECK_DC5);
> >  	}
> >  
> > @@ -423,6 +423,7 @@ int main(int argc, char *argv[])
> >  	igt_subtest("dc6-psr") {
> >  		data.op_psr_mode = PSR_MODE_1;
> >  		psr_enable(data.debugfs_fd, data.op_psr_mode);
> > +		igt_require(psr_sink_support(data.debugfs_fd,
> > PSR_MODE_1));
> >  		igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.
> > msr_fd),
> >  			      "PC8+ residencies not supported\n");
> >  		test_dc_state_psr(&data, CHECK_DC6);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915_pm_dc: Dump power_domain_info on DC test failures

[Anshuman Gupta]

On 2020-02-19 at 00:33:09 +0530, Souza, Jose wrote:
> On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote:
> > Dump i915_power_domain_info debugfs attribute on DC state
> > test failures, it will help to identify culprit, which
> > causes non zero refcount for "DC off" power well.
> > 
> > Cc: Animesh Manna <animesh.manna@intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> >  tests/i915/i915_pm_dc.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> > index afcc10bc..4bca8559 100644
> > --- a/tests/i915/i915_pm_dc.c
> > +++ b/tests/i915/i915_pm_dc.c
> > @@ -206,11 +206,13 @@ static bool dc_state_wait_entry(int debugfs_fd,
> > int dc_flag, int prev_dc_count)
> >  static void check_dc_counter(int debugfs_fd, int dc_flag, uint32_t
> > prev_dc_count)
> >  {
> >  	char tmp[64];
> > +	char file[64] = "i915_power_domain_info";
> >  
> >  	snprintf(tmp, sizeof(tmp), "%s", dc_flag & CHECK_DC3CO ?
> > "DC3CO" :
> >  		(dc_flag & CHECK_DC5 ? "DC5" : "DC6"));
> >  	igt_assert_f(dc_state_wait_entry(debugfs_fd, dc_flag,
> > prev_dc_count),
> > -		     "%s state is not achieved\n", tmp);
> > +		     "%s state is not achieved\n%s:\n%s\n",
> > +		     tmp, file, igt_sysfs_get(debugfs_fd, file));
> >  }
> 
> You are leaking the return of igt_sysfs_get() also why add the variable
> file? 
Thanks for review, i will fix the leak and will take a macro instead of file.
Thanks,
Anshuman Gupta. 
> 
> >  
> >  static void setup_videoplayback(data_t *data)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_dc: psr required only for dc*-psr tests

[Souza, Jose]

On Wed, 2020-02-19 at 09:04 +0530, Anshuman Gupta wrote:
> On 2020-02-19 at 00:25:55 +0530, Souza, Jose wrote:
> > On Sun, 2020-02-16 at 23:30 +0530, Anshuman Gupta wrote:
> > > DPMS igt tests were skipping for non-psr panels due to
> > > psr_sink_support sink check added to igt_fixture() at
> > > commit <6cbe6af372a01be63121056679d540436ffd0b64>.
> > > DPMS dc state igt test don't require psr_sink_support, as it
> > > validates DC states with all display being DPMS off.
> > > Removing the psr sink check from igt_fixture and adding
> > > it only for dc*- psr tests.
> > 
> > Makes sense, just missing the igt_require(psr) in dc3co-vpb-
> > simulation.
> Thanks for review, dc3co-vpb-simulation already had igt_require_f
> for psr_wait_entry, so do we require psr sink check over there ?
> Please correct me if i am wrong here.

It does a bunch of things before that igt_require, with CI queues 3 to
4 days behind every little second saved(in this case when there is no
PSR2 panel) might help.

> Thanks,
> Anshuman Gupta. 
> > > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> > > Cc: José Roberto de Souza <jose.souza@intel.com>
> > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > > ---
> > >  tests/i915/i915_pm_dc.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> > > index 4bca8559..4c34ff9d 100644
> > > --- a/tests/i915/i915_pm_dc.c
> > > +++ b/tests/i915/i915_pm_dc.c
> > > @@ -395,7 +395,6 @@ int main(int argc, char *argv[])
> > >  		igt_require(igt_setup_runtime_pm(data.drm_fd));
> > >  		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
> > >  		igt_display_require(&data.display, data.drm_fd);
> > > -		igt_require(psr_sink_support(data.debugfs_fd,
> > > PSR_MODE_1));
> > >  		/* Make sure our Kernel supports MSR and the module is
> > > loaded */
> > >  		igt_require(igt_kmod_load("msr", NULL) == 0);
> > >  
> > > @@ -415,6 +414,7 @@ int main(int argc, char *argv[])
> > >  	igt_subtest("dc5-psr") {
> > >  		data.op_psr_mode = PSR_MODE_1;
> > >  		psr_enable(data.debugfs_fd, data.op_psr_mode);
> > > +		igt_require(psr_sink_support(data.debugfs_fd,
> > > PSR_MODE_1));
> > >  		test_dc_state_psr(&data, CHECK_DC5);
> > >  	}
> > >  
> > > @@ -423,6 +423,7 @@ int main(int argc, char *argv[])
> > >  	igt_subtest("dc6-psr") {
> > >  		data.op_psr_mode = PSR_MODE_1;
> > >  		psr_enable(data.debugfs_fd, data.op_psr_mode);
> > > +		igt_require(psr_sink_support(data.debugfs_fd,
> > > PSR_MODE_1));
> > >  		igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.
> > > msr_fd),
> > >  			      "PC8+ residencies not supported\n");
> > >  		test_dc_state_psr(&data, CHECK_DC6);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev