* [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory()
@ 2023-04-04 12:00 Matthew Auld
2023-04-04 12:00 ` [igt-dev] [PATCH i-g-t 2/2] lib/xe_query: fix vram_if_possible() Matthew Auld
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Matthew Auld @ 2023-04-04 12:00 UTC (permalink / raw)
To: igt-dev
It looks like this is meant to return VRAM if supported. If we call this
on igpu it should return zero. There is at least one user relying on
this in xe_mmap@vram, where we want to skip if the mask here is zero.
Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
---
lib/xe/xe_query.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
index 24a258a5e..253164d6b 100644
--- a/lib/xe/xe_query.c
+++ b/lib/xe/xe_query.c
@@ -380,7 +380,7 @@ uint64_t vram_memory(int fd, int gt)
igt_assert(xe_dev);
igt_assert(gt >= 0 && gt < xe_dev->number_gt);
- return native_region_for_gt(xe_dev->gts, gt);
+ return native_region_for_gt(xe_dev->gts, gt) & (~0x1);
}
/**
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] lib/xe_query: fix vram_if_possible()
2023-04-04 12:00 [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() Matthew Auld
@ 2023-04-04 12:00 ` Matthew Auld
2023-04-04 13:10 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory() Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2023-04-04 12:00 UTC (permalink / raw)
To: igt-dev
It looks like this is meant to return the per-GT VRAM bit of the passed
in GT. Currently this just returns the mask for all GTs. i.e if we ask
for gt1 we still get back the region mask for all GTs.
Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
---
lib/xe/xe_query.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
index 253164d6b..5856255bf 100644
--- a/lib/xe/xe_query.c
+++ b/lib/xe/xe_query.c
@@ -393,11 +393,7 @@ uint64_t vram_memory(int fd, int gt)
*/
uint64_t vram_if_possible(int fd, int gt)
{
- uint64_t regions = all_memory_regions(fd);
- uint64_t system_memory = regions & 0x1;
- uint64_t vram = regions & (~0x1);
-
- return vram ? vram : system_memory;
+ return vram_memory(fd, gt) ?: 0x1;
}
/**
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory()
2023-04-04 12:00 [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() Matthew Auld
2023-04-04 12:00 ` [igt-dev] [PATCH i-g-t 2/2] lib/xe_query: fix vram_if_possible() Matthew Auld
@ 2023-04-04 13:10 ` Patchwork
2023-04-04 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-04 22:11 ` [igt-dev] [PATCH i-g-t 1/2] " Niranjana Vishwanathapura
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-04-04 13:10 UTC (permalink / raw)
To: Matthew Auld; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4047 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory()
URL : https://patchwork.freedesktop.org/series/116089/
State : success
== Summary ==
CI Bug Log - changes from IGT_7235 -> IGTPW_8751
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/index.html
Participating hosts (37 -> 36)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8751 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rps@basic-api:
- bat-dg2-11: [PASS][1] -> [FAIL][2] ([i915#8308])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/bat-dg2-11/igt@i915_pm_rps@basic-api.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/bat-dg2-11/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [PASS][3] -> [ABORT][4] ([i915#7911] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/fi-bsw-n3050/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][5] -> [DMESG-WARN][6] ([i915#7699])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/bat-dg2-11/igt@i915_selftest@live@migrate.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@kms_pipe_crc_basic@read-crc:
- bat-dg2-11: NOTRUN -> [SKIP][7] ([i915#5354])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/bat-dg2-11/igt@kms_pipe_crc_basic@read-crc.html
#### Possible fixes ####
* igt@i915_selftest@live@slpc:
- bat-rpls-1: [DMESG-FAIL][8] ([i915#6367] / [i915#7996]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/bat-rpls-1/igt@i915_selftest@live@slpc.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1:
- bat-dg2-8: [FAIL][10] ([i915#7932]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-d-dp-1.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][12] ([i915#6367] / [i915#7913]) -> [DMESG-FAIL][13] ([i915#6997] / [i915#7913])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/bat-rpls-2/igt@i915_selftest@live@slpc.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/bat-rpls-2/igt@i915_selftest@live@slpc.html
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7996]: https://gitlab.freedesktop.org/drm/intel/issues/7996
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7235 -> IGTPW_8751
CI-20190529: 20190529
CI_DRM_12964: 761960bbc648f09022c69052289c90bb55798a8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8751: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/index.html
IGT_7235: ff33276135a71fc86aa30505aa7cdb3cc678c82e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/index.html
[-- Attachment #2: Type: text/html, Size: 4999 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory()
2023-04-04 12:00 [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() Matthew Auld
2023-04-04 12:00 ` [igt-dev] [PATCH i-g-t 2/2] lib/xe_query: fix vram_if_possible() Matthew Auld
2023-04-04 13:10 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory() Patchwork
@ 2023-04-04 21:14 ` Patchwork
2023-04-04 22:11 ` [igt-dev] [PATCH i-g-t 1/2] " Niranjana Vishwanathapura
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-04-04 21:14 UTC (permalink / raw)
To: Matthew Auld; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 16001 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory()
URL : https://patchwork.freedesktop.org/series/116089/
State : success
== Summary ==
CI Bug Log - changes from IGT_7235_full -> IGTPW_8751_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/index.html
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8751_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-1:
- {shard-rkl}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-rkl-7/igt@kms_plane_scaling@i915-max-src-size@pipe-a-hdmi-a-1.html
Known issues
------------
Here are the changes found in IGTPW_8751_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_barrier_race@remote-request@rcs0:
- shard-apl: [PASS][2] -> [ABORT][3] ([i915#8211] / [i915#8234])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-apl4/igt@gem_barrier_race@remote-request@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl7/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-apl: [PASS][4] -> [ABORT][5] ([i915#180])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-apl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl2/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl4/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][9] -> [ABORT][10] ([i915#5566])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-glk3/igt@gen9_exec_parse@allowed-single.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-glk2/igt@gen9_exec_parse@allowed-single.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl2/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271]) +82 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl4/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#658])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@v3d/v3d_submit_csd@multi-and-single-sync:
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271]) +28 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-snb2/igt@v3d/v3d_submit_csd@multi-and-single-sync.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][15] ([i915#2846]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-glk7/igt@gem_exec_fair@basic-deadline.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][17] ([i915#5566]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-apl6/igt@gen9_exec_parse@allowed-single.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl6/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- {shard-rkl}: [SKIP][19] ([i915#1397]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-rkl-4/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][21] ([i915#7790]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-snb7/igt@i915_pm_rps@reset.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-snb2/igt@i915_pm_rps@reset.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][23] ([i915#2346]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@forked-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][25] ([i915#8011]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-dg1-14/igt@kms_cursor_legacy@forked-bo@pipe-b.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-dg1-17/igt@kms_cursor_legacy@forked-bo@pipe-b.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][27] ([i915#8011]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-rkl-7/igt@kms_cursor_legacy@single-bo@pipe-b.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-rkl-1/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-270:
- {shard-rkl}: [ABORT][29] -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-rkl-2/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-rkl-4/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- {shard-tglu}: [ABORT][31] ([i915#5122]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7235/shard-tglu-10/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/shard-tglu-8/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8150]: https://gitlab.freedesktop.org/drm/intel/issues/8150
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8308]: https://gitlab.freedesktop.org/drm/intel/issues/8308
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7235 -> IGTPW_8751
CI-20190529: 20190529
CI_DRM_12964: 761960bbc648f09022c69052289c90bb55798a8b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8751: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/index.html
IGT_7235: ff33276135a71fc86aa30505aa7cdb3cc678c82e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8751/index.html
[-- Attachment #2: Type: text/html, Size: 10216 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory()
2023-04-04 12:00 [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() Matthew Auld
` (2 preceding siblings ...)
2023-04-04 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-04-04 22:11 ` Niranjana Vishwanathapura
2023-04-05 13:26 ` Matthew Auld
3 siblings, 1 reply; 6+ messages in thread
From: Niranjana Vishwanathapura @ 2023-04-04 22:11 UTC (permalink / raw)
To: Matthew Auld; +Cc: igt-dev
On Tue, Apr 04, 2023 at 01:00:41PM +0100, Matthew Auld wrote:
>It looks like this is meant to return VRAM if supported. If we call this
>on igpu it should return zero. There is at least one user relying on
>this in xe_mmap@vram, where we want to skip if the mask here is zero.
>
Below patch was sent before, but never got merged.
https://patchwork.freedesktop.org/series/115409/
There are some minor differences. Can you pick those
changes?
Also, cover letter seems to be missing for this series.
Or, we can simple merge them into a single patch as they
are related?
Niranjana
>Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
>Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>Cc: Matthew Brost <matthew.brost@intel.com>
>---
> lib/xe/xe_query.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
>index 24a258a5e..253164d6b 100644
>--- a/lib/xe/xe_query.c
>+++ b/lib/xe/xe_query.c
>@@ -380,7 +380,7 @@ uint64_t vram_memory(int fd, int gt)
> igt_assert(xe_dev);
> igt_assert(gt >= 0 && gt < xe_dev->number_gt);
>
>- return native_region_for_gt(xe_dev->gts, gt);
>+ return native_region_for_gt(xe_dev->gts, gt) & (~0x1);
> }
>
> /**
>--
>2.39.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory()
2023-04-04 22:11 ` [igt-dev] [PATCH i-g-t 1/2] " Niranjana Vishwanathapura
@ 2023-04-05 13:26 ` Matthew Auld
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2023-04-05 13:26 UTC (permalink / raw)
To: Niranjana Vishwanathapura; +Cc: igt-dev
On 04/04/2023 23:11, Niranjana Vishwanathapura wrote:
> On Tue, Apr 04, 2023 at 01:00:41PM +0100, Matthew Auld wrote:
>> It looks like this is meant to return VRAM if supported. If we call this
>> on igpu it should return zero. There is at least one user relying on
>> this in xe_mmap@vram, where we want to skip if the mask here is zero.
>>
>
> Below patch was sent before, but never got merged.
> https://patchwork.freedesktop.org/series/115409/
>
> There are some minor differences. Can you pick those
> changes?
Ok, missed that... Let me check.
>
> Also, cover letter seems to be missing for this series.
> Or, we can simple merge them into a single patch as they
> are related?
Ok, will squash.
>
> Niranjana
>
>> Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
>> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
>> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
>> Cc: Matthew Brost <matthew.brost@intel.com>
>> ---
>> lib/xe/xe_query.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
>> index 24a258a5e..253164d6b 100644
>> --- a/lib/xe/xe_query.c
>> +++ b/lib/xe/xe_query.c
>> @@ -380,7 +380,7 @@ uint64_t vram_memory(int fd, int gt)
>> igt_assert(xe_dev);
>> igt_assert(gt >= 0 && gt < xe_dev->number_gt);
>>
>> - return native_region_for_gt(xe_dev->gts, gt);
>> + return native_region_for_gt(xe_dev->gts, gt) & (~0x1);
>> }
>>
>> /**
>> --
>> 2.39.2
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-05 13:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 12:00 [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() Matthew Auld
2023-04-04 12:00 ` [igt-dev] [PATCH i-g-t 2/2] lib/xe_query: fix vram_if_possible() Matthew Auld
2023-04-04 13:10 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/xe_query: fix vram_memory() Patchwork
2023-04-04 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-04-04 22:11 ` [igt-dev] [PATCH i-g-t 1/2] " Niranjana Vishwanathapura
2023-04-05 13:26 ` Matthew Auld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox