* [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include
@ 2023-08-22 20:18 Aurabindo Pillai
2023-08-22 20:47 ` Kamil Konieczny
2023-08-22 23:04 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Aurabindo Pillai @ 2023-08-22 20:18 UTC (permalink / raw)
To: igt-dev; +Cc: hersenxs.wu
Remove the external file include that causes build error
on certain systems configured in the CI.
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
tests/amdgpu/amd_odm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/amdgpu/amd_odm.c b/tests/amdgpu/amd_odm.c
index 2781ad1c2..839f2de3f 100644
--- a/tests/amdgpu/amd_odm.c
+++ b/tests/amdgpu/amd_odm.c
@@ -5,7 +5,6 @@
#include <fcntl.h>
#include <stdio.h>
-#include <xf86drmMode.h>
#include "igt.h"
#include "igt_amd.h"
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include
2023-08-22 20:18 [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include Aurabindo Pillai
@ 2023-08-22 20:47 ` Kamil Konieczny
2023-08-22 20:57 ` Aurabindo Pillai
2023-08-22 23:04 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Kamil Konieczny @ 2023-08-22 20:47 UTC (permalink / raw)
To: igt-dev; +Cc: hersenxs.wu
Hi Aurabindo,
On 2023-08-22 at 16:18:33 -0400, Aurabindo Pillai wrote:
> Remove the external file include that causes build error
> on certain systems configured in the CI.
>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
> tests/amdgpu/amd_odm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/amdgpu/amd_odm.c b/tests/amdgpu/amd_odm.c
> index 2781ad1c2..839f2de3f 100644
> --- a/tests/amdgpu/amd_odm.c
> +++ b/tests/amdgpu/amd_odm.c
> @@ -5,7 +5,6 @@
>
> #include <fcntl.h>
> #include <stdio.h>
> -#include <xf86drmMode.h>
Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Will this test work without xf86drmMode.h?
If it is kms test you may just include igt_kms.h but first
apply fix (or revert).
Regards,
Kamil
>
> #include "igt.h"
> #include "igt_amd.h"
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include
2023-08-22 20:47 ` Kamil Konieczny
@ 2023-08-22 20:57 ` Aurabindo Pillai
0 siblings, 0 replies; 4+ messages in thread
From: Aurabindo Pillai @ 2023-08-22 20:57 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, hersenxs.wu, Ashutosh Dixit,
Petri Latvala
On 2023-08-22 16:47, Kamil Konieczny wrote:
> Hi Aurabindo,
>
> On 2023-08-22 at 16:18:33 -0400, Aurabindo Pillai wrote:
>> Remove the external file include that causes build error
>> on certain systems configured in the CI.
>>
>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
>> ---
>> tests/amdgpu/amd_odm.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/amdgpu/amd_odm.c b/tests/amdgpu/amd_odm.c
>> index 2781ad1c2..839f2de3f 100644
>> --- a/tests/amdgpu/amd_odm.c
>> +++ b/tests/amdgpu/amd_odm.c
>> @@ -5,7 +5,6 @@
>>
>> #include <fcntl.h>
>> #include <stdio.h>
>> -#include <xf86drmMode.h>
>
> Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> Will this test work without xf86drmMode.h?
> If it is kms test you may just include igt_kms.h but first
> apply fix (or revert).
Yes, looks like IGT already includes all the necessary headers.
>
> Regards,
> Kamil
>
>>
>> #include "igt.h"
>> #include "igt_amd.h"
>> --
>> 2.41.0
>>
--
--
Thanks & Regards,
Jay
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/amdgpu: Fix build error due to external file include
2023-08-22 20:18 [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include Aurabindo Pillai
2023-08-22 20:47 ` Kamil Konieczny
@ 2023-08-22 23:04 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2023-08-22 23:04 UTC (permalink / raw)
To: Aurabindo Pillai; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 250 bytes --]
== Series Details ==
Series: tests/amdgpu: Fix build error due to external file include
URL : https://patchwork.freedesktop.org/series/122761/
State : failure
== Summary ==
Series 122761 revision 1 was fully merged or fully failed: no git log
[-- Attachment #2: Type: text/html, Size: 719 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-22 23:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-22 20:18 [igt-dev] [PATCH v4] tests/amdgpu: Fix build error due to external file include Aurabindo Pillai
2023-08-22 20:47 ` Kamil Konieczny
2023-08-22 20:57 ` Aurabindo Pillai
2023-08-22 23:04 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox