Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario
@ 2023-09-20  6:08 Jeevan B
  2023-09-20  7:05 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
  2023-09-20  7:10 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
  0 siblings, 2 replies; 6+ messages in thread
From: Jeevan B @ 2023-09-20  6:08 UTC (permalink / raw)
  To: igt-dev

Describe the valid scenario for 'basic-clone-single-crtc' and
'basic-clone-single-crtc' tests, as these tests are skipped if
a valid scenario is not found, which can cause confusion during
bug analysis.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_setmode.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 32a6fb690..752951b85 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -979,6 +979,11 @@ const char *help_str =
 	"  -t <test id>\tRun only the test with this id\n"
 	"  -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
 
+/* basic-clone-single-crtc allows using a single CRTC for two connectors, such
+ * as VGA and HDMI. Similarly, invalid-clone-exclusive-crtc deals with invalid
+ * configurations where each connector uses its own incompatible CRTC.
+ */
+
 igt_main_args("det:", NULL, help_str, opt_handler, NULL)
 {
 	const struct {
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario
@ 2023-09-20 10:31 Jeevan B
  0 siblings, 0 replies; 6+ messages in thread
From: Jeevan B @ 2023-09-20 10:31 UTC (permalink / raw)
  To: igt-dev

Describe the valid scenario for 'basic-clone-single-crtc' and
'basic-clone-single-crtc' tests, as these tests are skipped if
a valid scenario is not found, which can cause confusion during
bug analysis.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_setmode.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 32a6fb690..14bc91198 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -979,6 +979,13 @@ const char *help_str =
 	"  -t <test id>\tRun only the test with this id\n"
 	"  -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
 
+/*
+ * basic-clone-single-crtc allows the use of a single CRTC for two connectors, for instance,
+ * in the case of a VGA and an HDMI connector. Similarly, for invalid-clone-exclusive-crtc
+ * when each connector uses its own CRTC, for instance, when a connector uses a CRTC that is
+ * not compatible with the connector.
+ */
+
 igt_main_args("det:", NULL, help_str, opt_handler, NULL)
 {
 	const struct {
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario
@ 2023-09-22 15:19 Jeevan B
  2023-09-26  5:58 ` Sharma, Swati2
  0 siblings, 1 reply; 6+ messages in thread
From: Jeevan B @ 2023-09-22 15:19 UTC (permalink / raw)
  To: igt-dev

Describe the valid scenario for 'basic-clone-single-crtc' and
'basic-clone-single-crtc' tests, as these tests are skipped if
a valid scenario is not found, which can cause confusion during
bug analysis.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
cc: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_setmode.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 32a6fb690..a669cc1df 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -979,6 +979,14 @@ const char *help_str =
 	"  -t <test id>\tRun only the test with this id\n"
 	"  -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
 
+/*
+ * basic-clone-single-crtc allows the use of a single CRTC for two connectors, such as VGA/HDMI,
+ * VGA/DP, and HDMI/HDMI, which are the possible combinations. Similarly, for invalid-clone-exclusive-crtc,
+ * when a connector uses a CRTC that is not compatible with the connector, for instance, DP/HDMI
+ * can be used on certain pipes on old platforms.
+ */
+
+
 igt_main_args("det:", NULL, help_str, opt_handler, NULL)
 {
 	const struct {
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-26  5:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-20  6:08 [igt-dev] [PATCH] tests/kms_setmode: Add info as comment for valid scenario Jeevan B
2023-09-20  7:05 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-09-20  7:10 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-09-20 10:31 [igt-dev] [PATCH] " Jeevan B
2023-09-22 15:19 Jeevan B
2023-09-26  5:58 ` Sharma, Swati2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox