[igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Kunal Joshi]

Test to validate hotplug in simulation environment we
have scratch pad register 0x4f080 from which we can
trigger uevents such as HPD, VBLANK..etc, Idea is to
have port mapping placed in igtrcthrough which test
can write to 0x4f080 and check if we get hotplug

Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>

Kunal Joshi (2):
  tests/kms_simulation_hpd: New test for hotplug validation
  tests/meson: added test to meson.build

 tests/intel/kms_simulation_hpd.c | 534 +++++++++++++++++++++++++++++++
 tests/meson.build                |   1 +
 2 files changed, 535 insertions(+)
 create mode 100644 tests/intel/kms_simulation_hpd.c

-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/2] tests/kms_simulation_hpd: New test for hotplug validation

[Kunal Joshi]

Test to validate hotplug in simulation environment we
have scratch pad register 0x4f080 from which we can
trigger uevents such as HPD, VBLANK..etc, Idea is to
have port mapping placed in igtrcthrough which test
can write to 0x4f080 and check if we get hotplug

Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/intel/kms_simulation_hpd.c | 534 +++++++++++++++++++++++++++++++
 1 file changed, 534 insertions(+)
 create mode 100644 tests/intel/kms_simulation_hpd.c

diff --git a/tests/intel/kms_simulation_hpd.c b/tests/intel/kms_simulation_hpd.c
new file mode 100644
index 000000000..e48200e48
--- /dev/null
+++ b/tests/intel/kms_simulation_hpd.c
@@ -0,0 +1,534 @@
+/*
+ * Copyright © 2023 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ *
+ * Author : Kunal Joshi <kunal1.joshi@intel.com>
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "igt_edid.h"
+#include "igt.h"
+#include "igt_rc.h"
+
+#define HPD_REGISTER 0x4f080
+#define HOTPLUG_HOTUNPLUG_COUNT 2
+#define SIMULATION_HOTPLUG_TIMEOUT 20
+
+/*
+ * Cobalt uses scratch pad register 33 (0x4f080) for triggering events such as
+ * HPD, vblank etc.., with this test we are writing to register to generate
+ * hotplug event and check if we are getting hotplug
+ *
+ * 0x4f080 (32 bit register definiton)
+ *
+ * 3:0 Event to trigger
+ * #define IDLE 0
+ * #define IMAGE_DRAW 0x0001
+ * #define VBLANK_INTTERUP 0x0010
+ *
+ * 4:7 Pipe
+ * #define ALL_PIPES 0x0
+ * #define PIPE_A 0x0001
+ * #define PIPE_B 0x0010
+ * #define PIPE_C 0x0011
+ * #define PIPE_D 0x0100
+ *
+ * 11:8 DDI Port
+ * #define NONE 0x0
+ * #define DDIA 0x0001
+ * #define DDIB 0x0010
+ * #define DDITC1 0x0011
+ * #define DDITC2 0x0100
+ * #define DDITC3 0x0101
+ * #define DDITC4 0x0110
+ *
+ * 15:12 Port Type
+ * #define HDMI_DP 0x0
+ * #define TBT 0x0001
+ * #define TYPE_C_ALT 0x0010
+ *
+ * 19:16 Pulse Yype
+ * #define SHORT_PULSE 0x0
+ * #define LONG_PULSE 0x0001
+ * #define SHORT_AND_LONG 0x0010
+ *
+ * 24:20 Monitor ID (0-30), 1F(31) is unplug
+ *
+ * 30:25 Reserved
+ *
+ * 31
+ * #define READY 0
+ * #define BUSY 1
+ *
+ * Below is example for configuring
+ * port mapping in igtrc
+ *
+ * [PortMapping]
+ * PortId:[0-5]
+ * MonitorId:[0-30]
+ * PortType:[0-2]
+ *
+ */
+
+/**
+ * TEST: kms simulation hpd
+ * Category: Display
+ * Description: Validates hotplug on simulation
+ */
+
+typedef struct port_mapping {
+	int port_id;
+	int port_type;
+	int monitor_id;
+	int connector_id;
+} port_mappings;
+
+typedef struct data {
+	int fd;
+	int port_mapping_count;
+	struct intel_mmio_data mmio_data;
+	port_mappings *port_maps;
+} data_t;
+
+/*
+ * Check if configured port mapping which we got from igtrc
+ * is valid
+ * data: data_t struct
+ *
+ * Port id should be between 0 and 5
+ * Monitor id should be between 0 and 30
+ * Port type should be 0 (DP/HDMI),1(TBT),2 (ALT)
+ *
+ * returns void
+ */
+static void validate_port_mapping(data_t *data)
+{
+	int i;
+
+	for (i = 0; i < data->port_mapping_count; i++) {
+		igt_debug("Port Mapping %d\n", i+1);
+		igt_debug("Port ID: %d\n",
+			  data->port_maps[i].port_id);
+		igt_debug("Monitor ID: %d\n",
+			  data->port_maps[i].monitor_id);
+		igt_debug("Port Type: %d\n",
+			  data->port_maps[i].port_type);
+
+		if (data->port_maps[i].port_id < 0 || data->port_maps[i].port_id > 5)
+			igt_skip("Invalid port id\n");
+		if (data->port_maps[i].monitor_id < 0 || data->port_maps[i].monitor_id > 30)
+			igt_skip("Invalid monitor id\n");
+		if (data->port_maps[i].port_type < 0 || data->port_maps[i].port_type > 2)
+			igt_skip("Invalid port type\n");
+	}
+}
+
+/*
+ * Read mappings from igtrc file and port_map struct
+ * data: data_t struct
+ *
+ * returns void
+ */
+static void set_mappings(data_t *data)
+{
+	int i = 0, count;
+	GError *error = NULL;
+	char **group_list;
+	char *group;
+	port_mappings port_map;
+
+	if (!igt_key_file)
+		igt_skip("igtrc config file not found\n");
+	group_list = g_key_file_get_groups(igt_key_file, NULL);
+	for (count = 0; group_list[count] != NULL; count++);
+
+	data->port_mapping_count = count;
+	data->port_maps = (port_mappings *)malloc(data->port_mapping_count * sizeof(port_map));
+	for (i = 0; group_list[i] != NULL; i++) {
+		group = group_list[i];
+		data->port_maps[i].port_id = g_key_file_get_integer(igt_key_file,
+								    group, "PortId",
+								    &error);
+		data->port_maps[i].monitor_id = g_key_file_get_integer(igt_key_file,
+								       group, "Monitor",
+								       &error);
+		data->port_maps[i].port_type = g_key_file_get_integer(igt_key_file,
+								      group, "PortType",
+								      &error);
+	}
+}
+
+/*
+ * perform mmio read on HPD_REGISTER
+ * data: data_t struct
+ *
+ * returns value stored in HPD_REGISTER
+ */
+static int intel_reg_read(data_t *data)
+{
+	uint32_t val;
+
+	intel_register_access_init(&data->mmio_data,
+				   intel_get_pci_device(), 1, data->fd);
+	val = INREG(HPD_REGISTER);
+	intel_register_access_fini(&data->mmio_data);
+
+	return val;
+}
+
+/*
+ * performs mmio write on HPD_REGISTER
+ * data: data_t struct
+ * val: Value to write
+ *
+ * returns EXIT_SUCCESS if write successfull
+ */
+static int intel_reg_write(data_t *data, uint32_t val)
+{
+	intel_register_access_init(&data->mmio_data,
+				   intel_get_pci_device(),
+				   1, data->fd);
+	OUTREG(HPD_REGISTER, val);
+	intel_register_access_fini(&data->mmio_data);
+
+	return EXIT_SUCCESS;
+}
+
+/*
+ * Generates value for hotplugging particular port
+ * port_map: port_map struct
+ *
+ * returns value to plug particular port
+ */
+static int get_plug_value(port_mappings *port_map)
+{
+	int pulse = 1;
+	uint32_t val = 0;
+
+	val = (port_map->port_id << 8 | port_map->port_type << 12 | pulse << 16 | port_map->monitor_id << 20);
+
+	return val;
+}
+
+/*
+ * Generates value for hotplugging particular port
+ * with given monitor
+ * port_map: port_map struct
+ * monitor_id: Id of minitor to plug with
+ *
+ * returns value to hotplug particular port with given monitor
+ */
+static int get_plug_value_for_monitor(port_mappings *port_map,
+				      int monitor_id)
+{
+	int pulse = 1;
+	uint32_t val = 0;
+
+	val = (port_map->port_id << 8 | port_map->port_type << 12 | pulse << 16 | monitor_id << 20);
+
+	return val;
+}
+
+/*
+ * Generates value for hot unplugging particular port
+ * port_map: port_map struct
+ *
+ * returns value to hot unplug particular port
+ */
+static int get_unplug_value(port_mappings *port_map)
+{
+	int pulse = 1;
+	int unplug = 31;
+	uint32_t val = 0;
+
+	val = (port_map->port_id << 8 | port_map->port_type << 12 | pulse << 16 | unplug << 20);
+
+	return val;
+}
+
+/*
+ * Wait for hotplug and return on detction
+ *
+ * mon: udev monitor
+ * timeout: timeout in sec
+ *
+ * return true if hotplug detected
+ * else false
+ */
+static bool wait_for_hotplug(struct udev_monitor *mon, int *timeout)
+{
+	bool detected;
+
+	detected = igt_hotplug_detected(mon, *timeout);
+	return detected;
+}
+
+/*
+ * Check if after hotplug connector status is reflected
+ * as intended
+ * data: data_t struct
+ * port: index of port_maps
+ * mon: udev monitor
+ * status: drmModeConnection
+ *
+ * returns void
+ */
+static void
+wait_for_connector_after_hotplug_hotunplug(data_t *data, int port,
+				 struct udev_monitor *mon,
+				 drmModeConnection status)
+{
+	int timeout = SIMULATION_HOTPLUG_TIMEOUT;
+	int hotplug_count = 0;
+	drmModeConnector *connector;
+	drmModeConnection current_status;
+
+	connector = drmModeGetConnector(data->fd,
+					data->port_maps[port].connector_id);
+	igt_assert(connector);
+
+	igt_debug("Reprobing %s-%d...\n",
+		  kmstest_connector_type_str(connector->connector_type),
+		  connector->connector_type_id);
+
+	igt_debug("Waiting for %s-%d to get %s after a hotplug/hotunplug event...\n",
+		  kmstest_connector_type_str(connector->connector_type),
+		  connector->connector_type_id, kmstest_connector_status_str(status));
+
+	while (timeout > 0) {
+		if (!wait_for_hotplug(mon, &timeout))
+			break;
+
+		hotplug_count++;
+
+		current_status = connector->connection;
+		if (current_status == status)
+			return;
+	}
+
+	igt_assert_f(false,
+		     "Timed out waiting for %s-%d to get %s after a hotplug/hotunplug. Current state %s hotplug_count %d\n",
+		     kmstest_connector_type_str(connector->connector_type),
+		     connector->connector_type_id,
+		     kmstest_connector_status_str(status),
+		     kmstest_connector_status_str(current_status), hotplug_count);
+}
+
+/*
+ * Byte 12 to 16 is serial id in edid
+ * Function retrieves serial id from id
+ * drm_fd: drm file descriptor
+ * connector: drmModeConnector
+ *
+ * returns int serial id if valid
+ * else -1
+ */
+static int serial_id_from_edid(int drm_fd, drmModeConnector *connector)
+{
+	int serial_id = -1;
+	bool ok;
+	uint64_t edid_blob_id;
+	drmModePropertyBlobRes *edid_blob;
+	const struct edid *edid;
+
+	if (connector->connection != DRM_MODE_CONNECTED) {
+		igt_debug("Skipping for connector %s-%d: as connector status is not connected\n",
+			  kmstest_connector_type_str(connector->connector_type),
+			  connector->connector_type_id);
+		return -1;
+	}
+
+	ok = kmstest_get_property(drm_fd, connector->connector_id,
+				  DRM_MODE_OBJECT_CONNECTOR, "EDID",
+				  NULL, &edid_blob_id, NULL);
+
+	if (!ok || !edid_blob_id) {
+		igt_debug("Skipping for connector %s-%d: missing the EDID property\n",
+			  kmstest_connector_type_str(connector->connector_type),
+			  connector->connector_type_id);
+		return -1;
+	}
+
+	edid_blob = drmModeGetPropertyBlob(drm_fd, edid_blob_id);
+	igt_assert(edid_blob);
+
+	edid = (const struct edid *) edid_blob->data;
+
+	serial_id = edid->serial[3];
+
+	drmModeFreePropertyBlob(edid_blob);
+	return serial_id;
+}
+
+/*
+ * Map ports provided in igtrc to connector id
+ * so after hotplug we can check connector status
+ * data: data_t struct
+ *
+ * returns true if port to connector mapping successfull
+ * else false
+ */
+static bool port_connector_mapping(data_t *data)
+{
+	int i, j, conn_id, serial_id;
+	uint32_t val;
+	drmModeRes *res;
+	drmModeConnector *connector;
+
+	for (i = 0; i < data->port_mapping_count; i++) {
+		/*
+		 * In simulation environment display_edid_dpcd.xml file
+		 * consists of edid's with serial value from 1 to 6 and their
+		 * respective monitor_id is 25 to 30
+		 */
+		int monitor_id = 25 + i;
+
+		val = get_plug_value_for_monitor(&data->port_maps[i],
+						 monitor_id);
+		igt_debug("Plugging port %d with monitor %d and value %x\n",
+			  i, monitor_id, val);
+		intel_reg_write(data, val);
+
+		/* Reprobe connectors and build the mapping */
+		res = drmModeGetResources(data->fd);
+		if (!res)
+			return false;
+
+		for (j = 0; j < res->count_connectors; j++) {
+			conn_id = res->connectors[j];
+			/* Read the EDID and parse the Port ID we stored
+			 * there.
+			 */
+			connector = drmModeGetConnector(data->fd,
+							res->connectors[j]);
+			serial_id = serial_id_from_edid(data->fd,
+							connector);
+			igt_debug("Serial id is %d for conn id %d\n",
+				  serial_id, conn_id);
+			if (serial_id == -1)
+				continue;
+
+			if (serial_id == (i+1)) {
+				igt_debug("Mapped Port %d to %s-%d\n",
+					  i, kmstest_connector_type_str(connector->connector_type),
+					  connector->connector_type_id);
+				data->port_maps[i].connector_id = conn_id;
+				intel_reg_write(data,
+						get_plug_value(&data->port_maps[i]));
+				igt_debug("Plugging default edid to port %d\n", i);
+				break;
+			}
+		}
+		drmModeFreeConnector(connector);
+	}
+	drmModeFreeResources(res);
+
+	return true;
+}
+
+/**
+ * SUBTEST: sim-hpd-%s-%d
+ * Description: Check that we get uevents and updated connector status on
+ * 		hotplug and unplug
+ * Test category: functionality test
+ * Functionality: hotplug
+ * Mega feature: DP, HDMI
+ *
+ * Driver requirement: i915, xe
+ * arg[1]:
+ *
+ * @DP:           for DP connectors
+ * @HDMI:         for HDMI connectors
+ *
+ * arg[2]:
+ *
+ * @number:       connector id
+*/
+static void test_simulation_hotplug(data_t *data, int i)
+{
+	int j;
+	uint32_t val;
+	struct udev_monitor *mon;
+
+	mon = igt_watch_uevents();
+
+	for (j = 0; j < HOTPLUG_HOTUNPLUG_COUNT; j++) {
+		// Unplug
+		val = get_unplug_value(&data->port_maps[i]);
+		igt_debug("Unplug value for mapping %d %x\n", i, val);
+
+		if (intel_reg_write(data, val) != EXIT_SUCCESS || intel_reg_read(data) != val)
+			igt_skip("Unable to write to register\n");
+		wait_for_connector_after_hotplug_hotunplug(data, i, mon,
+						 DRM_MODE_DISCONNECTED);
+		igt_flush_uevents(mon);
+
+		// Plug
+		val = get_plug_value(&data->port_maps[i]);
+		igt_debug("Plug value for mapping %d %x\n", i, val);
+
+		if (intel_reg_write(data, val) != EXIT_SUCCESS || intel_reg_read(data) != val)
+			igt_skip("Unable to write to register\n");
+		wait_for_connector_after_hotplug_hotunplug(data, i, mon,
+						 DRM_MODE_CONNECTED);
+		igt_flush_uevents(mon);
+	}
+}
+
+IGT_TEST_DESCRIPTION("Test HPD on simulation");
+igt_main
+{
+	int i;
+	data_t data = {0};
+	drmModeConnector *connector;
+
+	igt_fixture {
+		data.fd = __drm_open_driver(DRIVER_INTEL | DRIVER_XE);
+		igt_require(igt_run_in_simulation());
+		/*
+		 * We get port mappings from igtrc file
+		 * If that's misconfigured or empty, port_count will be 0
+		 * and test will skip
+		 */
+		set_mappings(&data);
+		validate_port_mapping(&data);
+		igt_assert_f(port_connector_mapping(&data),
+			     "Error in port mapping");
+	}
+	igt_describe("Hotplug test for all ports mentioned in igtrc");
+	igt_subtest_with_dynamic("sim-hpd")
+	{
+		for (i = 0; i < data.port_mapping_count; i++) {
+			connector = drmModeGetConnector(data.fd,
+							data.port_maps[i].connector_id);
+			igt_dynamic_f("%s-%d",
+				      kmstest_connector_type_str(connector->connector_type),
+				      connector->connector_type_id)
+			test_simulation_hotplug(&data, i);
+		}
+	}
+
+	igt_fixture {
+		close(data.fd);
+	}
+}
-- 
2.25.1

[igt-dev] [PATCH i-g-t 2/2] tests/meson: added test to meson.build

[Kunal Joshi]

Added tests to meson.build

Cc: Karthik B S <karthik.b.s@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/meson.build b/tests/meson.build
index 974cb433b..ca479acf2 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -268,6 +268,7 @@ intel_kms_progs = [
 	'kms_psr2_su',
 	'kms_psr_stress_test',
 	'kms_pwrite_crc',
+	'kms_simulation_hpd',
 ]
 
 intel_xe_progs = [
-- 
2.25.1

[igt-dev] ✗ Fi.CI.BUILD: failure for Add test for hotplug validation in simulation

[Patchwork]

== Series Details ==

Series: Add test for hotplug validation in simulation
URL   : https://patchwork.freedesktop.org/series/124491/
State : failure

== Summary ==

IGT patchset build failed on latest successful build
8abfd4fd5c71c882e90410aac2afba7331904b2b lib/intel_blt: Add check to see if blt commands are supported by the platforms

Tail of build.log:
[1598/1644] Linking target tools/xe_reg.
[1599/1644] Linking target tools/intel_watermark.
[1600/1644] Linking target tools/intel_gvtg_test.
[1601/1644] Linking target runner/testdata/successtest.
[1602/1644] Linking target tools/intel_residency.
[1603/1644] Linking target tools/intel_reg.
[1604/1644] Linking target runner/testdata/abort-simple.
[1605/1644] Linking target runner/testdata/dynamic.
[1606/1644] Generating gem_stress.testlist with a meson_exe.py custom command.
[1607/1644] Linking target runner/testdata/no-subtests.
[1608/1644] Linking target tools/amd_hdmi_compliance.
[1609/1644] Linking target tools/msm_dp_compliance.
[1610/1644] Linking target runner/igt_comms_decoder.
[1611/1644] Linking target runner/runner_json_test.
[1612/1644] Linking target tools/lsgpu.
[1613/1644] Linking target runner/igt_runner.
[1614/1644] Linking target runner/testdata/abort-dynamic.
[1615/1644] Linking target runner/igt_results.
[1616/1644] Linking target tools/intel_dp_compliance.
[1617/1644] Linking target runner/testdata/skippers.
[1618/1644] Linking target runner/testdata/abort.
[1619/1644] Linking target runner/testdata/abort-fixture.
[1620/1644] Linking target runner/igt_resume.
[1621/1644] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_mtlgt3.c.o'.
[1622/1644] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
[1623/1644] Linking target runner/runner_test.
[1624/1644] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_acmgt1.c.o'.
[1625/1644] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_acmgt2.c.o'.
[1626/1644] Compiling C object 'lib/76b5a35@@i915_perf@sha/meson-generated_.._i915_perf_metrics_acmgt3.c.o'.
[1627/1644] Linking target lib/libi915_perf.so.1.5.
[1628/1644] Generating symbol file 'lib/76b5a35@@i915_perf@sha/libi915_perf.so.1.5.symbols'.
[1629/1644] Linking target tools/i915-perf/i915-perf-configs.
[1630/1644] Linking target tools/i915-perf/i915-perf-reader.
[1631/1644] Linking target tools/i915-perf/i915-perf-recorder.
[1632/1644] Linking target tests/core_hotunplug.
[1633/1644] Linking target tests/gem_barrier_race.
[1634/1644] Linking target tests/perf.
[1635/1644] Generating gem_barrier_race.testlist with a meson_exe.py custom command.
[1636/1644] Generating perf.testlist with a meson_exe.py custom command.
[1637/1644] Generating core_hotunplug.testlist with a meson_exe.py custom command.
[1638/1644] Generating xe_tests.rst with a custom command.
[1639/1644] Generating i915_tests.rst with a custom command.
[1640/1644] Generating kms_tests.rst with a custom command.
FAILED: docs/testplan/kms_tests.rst 
/usr/src/igt-gpu-tools/scripts/igt_doc.py --config /usr/src/igt-gpu-tools/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /opt/igt/build
Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
Please refer: docs/test_documentation.md for more details
[1641/1644] Generating xe_tests.html with a custom command.
[1642/1644] Generating i915_tests.html with a custom command.
ninja: build stopped: subcommand failed.

[igt-dev] ✗ GitLab.Pipeline: warning for Add test for hotplug validation in simulation

[Patchwork]

== Series Details ==

Series: Add test for hotplug validation in simulation
URL   : https://patchwork.freedesktop.org/series/124491/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/999056 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/49725139):
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  [1641/1644] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
  [1642/1644] Generating i915_tests.html with a custom command.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/728] Generating version.h with a custom command.
  [2/4] Linking target runner/runner_test.
  [3/4] Generating kms_tests.rst with a custom command.
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  ninja: build stopped: subcommand failed.
  section_end:1696157499:step_script
  section_start:1696157499:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1696157500:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/49725134):
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  [1647/1650] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
  [1648/1650] Generating i915_tests.html with a custom command.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/730] Generating version.h with a custom command.
  [2/4] Linking target runner/runner_test.
  [3/4] Generating kms_tests.rst with a custom command.
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  ninja: build stopped: subcommand failed.
  section_end:1696157511:step_script
  section_start:1696157511:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1696157512:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/49725138):
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  [1649/1650] Generating i915_tests.html with a custom command.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/730] Generating version.h with a custom command.
  [2/3] Generating kms_tests.rst with a custom command.
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  ninja: build stopped: subcommand failed.
  section_end:1696157529:step_script
  section_start:1696157529:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1696157529:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libdrm-nouveau has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/49725137):
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  [1491/1494] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
  [1492/1494] Generating i915_tests.html with a custom command.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/684] Generating version.h with a custom command.
  [2/4] Linking target runner/runner_test.
  [3/4] Generating kms_tests.rst with a custom command.
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  ninja: build stopped: subcommand failed.
  section_end:1696157499:step_script
  section_start:1696157499:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1696157500:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/49725135):
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  [1647/1650] Compiling C object 'runner/527aa9f@@runner_test@exe/runner_tests.c.o'.
  [1648/1650] Generating i915_tests.html with a custom command.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/730] Generating version.h with a custom command.
  [2/4] Linking target runner/runner_test.
  [3/4] Generating kms_tests.rst with a custom command.
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  ninja: build stopped: subcommand failed.
  section_end:1696157511:step_script
  section_start:1696157511:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1696157512:cleanup_file_variables
  ERROR: Job failed: exit code 1
  

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/49725136):
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  [1647/1650] Compiling C object 'runner/runner@@runner_test@exe/runner_tests.c.o'.
  [1648/1650] Generating i915_tests.html with a custom command.
  ninja: build stopped: subcommand failed.
  ninja: Entering directory `build'
  [1/730] Generating version.h with a custom command.
  [2/4] Linking target runner/runner_test.
  [3/4] Generating kms_tests.rst with a custom command.
  FAILED: docs/testplan/kms_tests.rst 
  /builds/gfx-ci/igt-ci-tags/scripts/igt_doc.py --config /builds/gfx-ci/igt-ci-tags/tests/intel/kms_test_config.json --rest docs/testplan/kms_tests.rst --check-testlist --igt-build-path /builds/gfx-ci/igt-ci-tags/build
  Warning: Missing documentation for igt@kms_simulation_hpd@sim-hpd
  Please refer: docs/test_documentation.md for more details
  ninja: build stopped: subcommand failed.
  section_end:1696157509:step_script
  section_start:1696157509:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1696157510:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/999056

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Modem, Bhanuprakash]

Hi Kunal,

On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
> Test to validate hotplug in simulation environment we
> have scratch pad register 0x4f080 from which we can
> trigger uevents such as HPD, VBLANK..etc, Idea is to
> have port mapping placed in igtrcthrough which test
> can write to 0x4f080 and check if we get hotplug

In first glance, do we really need to upstream this test? I am pretty 
sure, no one (including Intel) is going to use this test from upstream 
repo (We don't have any simulation environment in public CI).

So, we can't merge this.

+ Kamil, thoughts?

- Bhanu

> 
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> 
> Kunal Joshi (2):
>    tests/kms_simulation_hpd: New test for hotplug validation
>    tests/meson: added test to meson.build
> 
>   tests/intel/kms_simulation_hpd.c | 534 +++++++++++++++++++++++++++++++
>   tests/meson.build                |   1 +
>   2 files changed, 535 insertions(+)
>   create mode 100644 tests/intel/kms_simulation_hpd.c
> 

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Modem, Bhanuprakash]

Forgot to add Kamil to the TO/CC list.

On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
> Hi Kunal,
> 
> On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
>> Test to validate hotplug in simulation environment we
>> have scratch pad register 0x4f080 from which we can
>> trigger uevents such as HPD, VBLANK..etc, Idea is to
>> have port mapping placed in igtrcthrough which test
>> can write to 0x4f080 and check if we get hotplug
> 
> In first glance, do we really need to upstream this test? I am pretty 
> sure, no one (including Intel) is going to use this test from upstream 
> repo (We don't have any simulation environment in public CI).
> 
> So, we can't merge this.
> 
> + Kamil, thoughts?
> 
> - Bhanu
> 
>>
>> Cc: Karthik B S <karthik.b.s@intel.com>
>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>>
>> Kunal Joshi (2):
>>    tests/kms_simulation_hpd: New test for hotplug validation
>>    tests/meson: added test to meson.build
>>
>>   tests/intel/kms_simulation_hpd.c | 534 +++++++++++++++++++++++++++++++
>>   tests/meson.build                |   1 +
>>   2 files changed, 535 insertions(+)
>>   create mode 100644 tests/intel/kms_simulation_hpd.c
>>

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Juha-Pekka Heikkila]

On 4.10.2023 8.48, Modem, Bhanuprakash wrote:
> Forgot to add Kamil to the TO/CC list.
> 
> On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
>> Hi Kunal,
>>
>> On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
>>> Test to validate hotplug in simulation environment we
>>> have scratch pad register 0x4f080 from which we can
>>> trigger uevents such as HPD, VBLANK..etc, Idea is to
>>> have port mapping placed in igtrcthrough which test
>>> can write to 0x4f080 and check if we get hotplug
>>
>> In first glance, do we really need to upstream this test? I am pretty 
>> sure, no one (including Intel) is going to use this test from upstream 
>> repo (We don't have any simulation environment in public CI).
>>
>> So, we can't merge this.
>>
>> + Kamil, thoughts?
>>

Not sure why this wouldn't fit in upstream? It is valid igt test, will 
be of interest only for Intel guys hence in in intel directory and when 
in upstream it will not be causing issues during backports. We anyway 
already have more generic tests taking into account if they're being run 
in simulated environments.

/Juha-Pekka

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Kamil Konieczny]

Hi Juha-Pekka,

On 2023-10-04 at 11:15:25 +0300, Juha-Pekka Heikkila wrote:
> On 4.10.2023 8.48, Modem, Bhanuprakash wrote:
> > Forgot to add Kamil to the TO/CC list.
> > 
> > On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
> > > Hi Kunal,
> > > 
> > > On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
> > > > Test to validate hotplug in simulation environment we
> > > > have scratch pad register 0x4f080 from which we can
> > > > trigger uevents such as HPD, VBLANK..etc, Idea is to
> > > > have port mapping placed in igtrcthrough which test
> > > > can write to 0x4f080 and check if we get hotplug
> > > 
> > > In first glance, do we really need to upstream this test? I am
> > > pretty sure, no one (including Intel) is going to use this test from
> > > upstream repo (We don't have any simulation environment in public
> > > CI).
> > > 
> > > So, we can't merge this.
> > > 
> > > + Kamil, thoughts?
> > > 
> 
> Not sure why this wouldn't fit in upstream? It is valid igt test, will be of
> interest only for Intel guys hence in in intel directory and when in
> upstream it will not be causing issues during backports. We anyway already
> have more generic tests taking into account if they're being run in
> simulated environments.
> 
> /Juha-Pekka
> 

imho this should not be upstreamed as any user outside Intel
will not be able to run it. Why it cannot be a subtest with
some generic test like kms_hotplug.c with only timeout increased
for simulation? Such test may be in upstream if it will work
with existing hardware in CI.

Regards,
Kamil

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Modem, Bhanuprakash]

On Wed-04-10-2023 01:45 pm, Juha-Pekka Heikkila wrote:
> On 4.10.2023 8.48, Modem, Bhanuprakash wrote:
>> Forgot to add Kamil to the TO/CC list.
>>
>> On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
>>> Hi Kunal,
>>>
>>> On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
>>>> Test to validate hotplug in simulation environment we
>>>> have scratch pad register 0x4f080 from which we can
>>>> trigger uevents such as HPD, VBLANK..etc, Idea is to
>>>> have port mapping placed in igtrcthrough which test
>>>> can write to 0x4f080 and check if we get hotplug
>>>
>>> In first glance, do we really need to upstream this test? I am pretty 
>>> sure, no one (including Intel) is going to use this test from 
>>> upstream repo (We don't have any simulation environment in public CI).
>>>
>>> So, we can't merge this.
>>>
>>> + Kamil, thoughts?
>>>
> 
> Not sure why this wouldn't fit in upstream? It is valid igt test, will 
> be of interest only for Intel guys hence in in intel directory and when 
> in upstream it will not be causing issues during backports. We anyway 
> already have more generic tests taking into account if they're being run 
> in simulated environments.

Right, as we are going to keep these tests inside tests/intel directory, 
it's ok to merge.

- Bhanu

> 
> /Juha-Pekka
> 

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Joshi, Kunal1]

Hello Kamil,

On 10/4/2023 4:06 PM, Kamil Konieczny wrote:
> Hi Juha-Pekka,
>
> On 2023-10-04 at 11:15:25 +0300, Juha-Pekka Heikkila wrote:
>> On 4.10.2023 8.48, Modem, Bhanuprakash wrote:
>>> Forgot to add Kamil to the TO/CC list.
>>>
>>> On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
>>>> Hi Kunal,
>>>>
>>>> On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
>>>>> Test to validate hotplug in simulation environment we
>>>>> have scratch pad register 0x4f080 from which we can
>>>>> trigger uevents such as HPD, VBLANK..etc, Idea is to
>>>>> have port mapping placed in igtrcthrough which test
>>>>> can write to 0x4f080 and check if we get hotplug
>>>> In first glance, do we really need to upstream this test? I am
>>>> pretty sure, no one (including Intel) is going to use this test from
>>>> upstream repo (We don't have any simulation environment in public
>>>> CI).
>>>>
>>>> So, we can't merge this.
>>>>
>>>> + Kamil, thoughts?
>>>>
>> Not sure why this wouldn't fit in upstream? It is valid igt test, will be of
>> interest only for Intel guys hence in in intel directory and when in
>> upstream it will not be causing issues during backports. We anyway already
>> have more generic tests taking into account if they're being run in
>> simulated environments.
>>
>> /Juha-Pekka
>>
> imho this should not be upstreamed as any user outside Intel
> will not be able to run it. Why it cannot be a subtest with
> some generic test like kms_hotplug.c with only timeout increased
> for simulation? Such test may be in upstream if it will work
> with existing hardware in CI.
>
> Regards,
> Kamil

This test will only work in presi environment, for testing hotplug in 
hardware we have kms_chamelium_hpd,
But we can have it in upstream as someday we may require to run upstream 
igt's on presi.

Any thoughts bhanu and JP?

Thanks and Regards
Kunal Joshi

Re: [igt-dev] [PATCH i-g-t 0/2] Add test for hotplug validation in simulation

[Modem, Bhanuprakash]

Hi Kunal,

On Thu-26-10-2023 12:08 pm, Joshi, Kunal1 wrote:
> Hello Kamil,
> 
> On 10/4/2023 4:06 PM, Kamil Konieczny wrote:
>> Hi Juha-Pekka,
>>
>> On 2023-10-04 at 11:15:25 +0300, Juha-Pekka Heikkila wrote:
>>> On 4.10.2023 8.48, Modem, Bhanuprakash wrote:
>>>> Forgot to add Kamil to the TO/CC list.
>>>>
>>>> On Tue-03-10-2023 02:42 pm, Modem, Bhanuprakash wrote:
>>>>> Hi Kunal,
>>>>>
>>>>> On Sun-01-10-2023 04:00 pm, Kunal Joshi wrote:
>>>>>> Test to validate hotplug in simulation environment we
>>>>>> have scratch pad register 0x4f080 from which we can
>>>>>> trigger uevents such as HPD, VBLANK..etc, Idea is to
>>>>>> have port mapping placed in igtrcthrough which test
>>>>>> can write to 0x4f080 and check if we get hotplug
>>>>> In first glance, do we really need to upstream this test? I am
>>>>> pretty sure, no one (including Intel) is going to use this test from
>>>>> upstream repo (We don't have any simulation environment in public
>>>>> CI).
>>>>>
>>>>> So, we can't merge this.
>>>>>
>>>>> + Kamil, thoughts?
>>>>>
>>> Not sure why this wouldn't fit in upstream? It is valid igt test, 
>>> will be of
>>> interest only for Intel guys hence in in intel directory and when in
>>> upstream it will not be causing issues during backports. We anyway 
>>> already
>>> have more generic tests taking into account if they're being run in
>>> simulated environments.
>>>
>>> /Juha-Pekka
>>>
>> imho this should not be upstreamed as any user outside Intel
>> will not be able to run it. Why it cannot be a subtest with
>> some generic test like kms_hotplug.c with only timeout increased
>> for simulation? Such test may be in upstream if it will work
>> with existing hardware in CI.
>>
>> Regards,
>> Kamil
> 
> This test will only work in presi environment, for testing hotplug in 
> hardware we have kms_chamelium_hpd,
> But we can have it in upstream as someday we may require to run upstream 
> igt's on presi.
> 
> Any thoughts bhanu and JP?

As mentioned in previous replies, I am fine to upstream these changes as 
we are keeping these tests inside the "tests/intel" directory, and 
non-intel users are not going to use these tests.

- Bhanu

> 
> Thanks and Regards
> Kunal Joshi
> 
>