From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>
Subject: [i-g-t v3 2/9] tests/kms_vrr: Move vtest_ns into data_t
Date: Mon, 18 Dec 2023 13:52:00 +0530 [thread overview]
Message-ID: <20231218082207.32719-3-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231218082207.32719-1-bhanuprakash.modem@intel.com>
From: Sean Paul <seanpaul@chromium.org>
vtest_ns is derived from data->range which is fixed. Move it into data_t
and generate it once in prepare_test().
v2: (Bhanu)
- Rebase
Cc: Mark Yacoub <markyacoub@chromium.org>
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vrr.c | 36 +++++++++++++++---------------------
1 file changed, 15 insertions(+), 21 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index dda716ff3..505bad44b 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -100,6 +100,12 @@ typedef struct range {
unsigned int max;
} range_t;
+typedef struct vtest_ns {
+ uint64_t min;
+ uint64_t mid;
+ uint64_t max;
+} vtest_ns_t;
+
typedef struct data {
igt_display_t display;
int drm_fd;
@@ -107,14 +113,9 @@ typedef struct data {
igt_fb_t fb[2];
range_t range;
drmModeModeInfo switch_modes[RR_MODES_COUNT];
+ vtest_ns_t vtest_ns;
} data_t;
-typedef struct vtest_ns {
- uint64_t min;
- uint64_t mid;
- uint64_t max;
-} vtest_ns_t;
-
typedef void (*test_t)(data_t*, enum pipe, igt_output_t*, uint32_t);
/* Converts a timespec structure to nanoseconds. */
@@ -232,18 +233,6 @@ get_vrr_range(data_t *data, igt_output_t *output)
return range;
}
-/* Returns vrr test frequency for min, mid & max range. */
-static vtest_ns_t get_test_rate_ns(range_t range)
-{
- vtest_ns_t vtest_ns;
-
- vtest_ns.min = rate_from_refresh(range.min);
- vtest_ns.mid = rate_from_refresh(((range.max + range.min) / 2));
- vtest_ns.max = rate_from_refresh(range.max);
-
- return vtest_ns;
-}
-
/* Returns true if driver supports VRR. */
static bool has_vrr(igt_output_t *output)
{
@@ -276,6 +265,11 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)
mode = *igt_output_get_mode(output);
+ data->vtest_ns.min = rate_from_refresh(data->range.min);
+ data->vtest_ns.mid = rate_from_refresh(
+ (data->range.min + data->range.max) / 2);
+ data->vtest_ns.max = rate_from_refresh(data->range.max);
+
/* Prepare resources */
igt_create_color_fb(data->drm_fd, mode.hdisplay, mode.vdisplay,
DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
@@ -341,7 +335,7 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe,
uint64_t start_ns, last_event_ns, target_ns;
uint32_t total_flip = 0, total_pass = 0;
bool front = false;
- vtest_ns_t vtest_ns = get_test_rate_ns(data->range);
+ vtest_ns_t vtest_ns = data->vtest_ns;
/* Align with the flip completion event to speed up convergence. */
do_flip(data, &data->fb[0]);
@@ -418,7 +412,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
prepare_test(data, output, pipe);
range = data->range;
- vtest_ns = get_test_rate_ns(range);
+ vtest_ns = data->vtest_ns;
rate = vtest_ns.mid;
igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
@@ -512,7 +506,7 @@ test_seamless_rr_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint3
kmstest_dump_mode(&data->switch_modes[HIGH_RR_MODE]);
prepare_test(data, output, pipe);
- vtest_ns = get_test_rate_ns(data->range);
+ vtest_ns = data->vtest_ns;
if (vrr)
set_vrr_on_pipe(data, pipe, false, true);
--
2.40.0
next prev parent reply other threads:[~2023-12-18 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 8:21 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-18 8:21 ` [i-g-t v3 1/9] tests/kms_vrr: Move fb0 and fb1 to an array Bhanuprakash Modem
2023-12-18 8:22 ` Bhanuprakash Modem [this message]
2023-12-18 8:22 ` [i-g-t v3 3/9] tests/kms_vrr: Allow test rate to be altered from the command line Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 4/9] tests/kms_vrr: Allow test duration to be specified " Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 5/9] tests/kms_vrr: Change the pattern displayed in the test Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 6/9] tests/kms_vrr: Add ability to flip static image for flicker profiling Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 7/9] tests/kms_vrr: Allow for multiple rates in a test Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 8/9] tests/kms_vrr: Add a max/min test to oscillate between rates Bhanuprakash Modem
2023-12-18 8:22 ` [i-g-t v3 9/9] HAX/DO_NOT_MERGE: Test VRR only in BAT Bhanuprakash Modem
2023-12-18 20:24 ` ✗ Fi.CI.BAT: failure for tests/kms_vrr: Modify kms_vrr to allow flicker profiling (rev2) Patchwork
2023-12-18 21:12 ` ✗ CI.xeBAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-19 2:06 [i-g-t v3 0/9] tests/kms_vrr: Modify kms_vrr to allow flicker profiling Bhanuprakash Modem
2023-12-19 2:06 ` [i-g-t v3 2/9] tests/kms_vrr: Move vtest_ns into data_t Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218082207.32719-3-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox